[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #5265: Exclude Mid-Tier cache servers from CDN Snapshots

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #5265:
URL: https://github.com/apache/trafficcontrol/pull/5265#discussion_r529063955



##########
File path: traffic_monitor/todata/todata.go
##########
@@ -156,6 +157,14 @@ func (d TODataThreadsafe) Update(to towrap.TrafficOpsSessionThreadsafe, cdn stri
 		return fmt.Errorf("Error getting last CRConfig: %v", err)
 	}
 
+	monitoring, err := to.TrafficMonitorConfigMap(cdn)
+	if err != nil {
+		return fmt.Errorf("error getting monitoring configuration: %v", err)

Review comment:
       I think it depends on how often this error is actually hit. Isn't this on the order of every minute or so (its TO polling interval)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org