You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by ru...@apache.org on 2026/09/18 05:47:04 UTC

(spark) branch branch-4.x updated: [MINOR][CONNECT][PYTHON][TEST] Remove stale fallback parity tests

This is an automated email from the ASF dual-hosted git repository.

zhengruifeng pushed a commit to branch branch-4.x
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-4.x by this push:
     new 760df86b7414 [MINOR][CONNECT][PYTHON][TEST] Remove stale fallback parity tests
760df86b7414 is described below

commit 760df86b74148b9e3b8f0da491d3f4fa9dfc40b1
Author: Ruifeng Zheng <ru...@apache.org>
AuthorDate: Fri Sep 18 13:46:38 2026 +0800

    [MINOR][CONNECT][PYTHON][TEST] Remove stale fallback parity tests
    
    ### What changes were proposed in this pull request?
    
    Remove four skipped fallback test overrides from the Python Spark Connect Arrow parity suite.
    
    ### Why are the changes needed?
    
    The corresponding tests do not exist in the classic `ArrowTestsMixin`. Connect parity suites should not introduce test methods without classic counterparts, and the skipped methods would call nonexistent parent methods if enabled.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    - `conda run -n spark-dev-313 python -m py_compile python/pyspark/sql/tests/connect/arrow/test_parity_arrow.py`
    - `git diff --check`
    
    No runtime tests were needed because the removed test methods were unconditionally skipped.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    Generated-by: OpenAI Codex (GPT-5)
    
    Closes #58883 from zhengruifeng/py-connect-arrow-test-layout-dev-7.
    
    Authored-by: Ruifeng Zheng <ru...@apache.org>
    Signed-off-by: Ruifeng Zheng <ru...@foxmail.com>
    (cherry picked from commit 80416f3b0a0305cd282619244b8b6f1ad39fedc1)
    Signed-off-by: Ruifeng Zheng <ru...@foxmail.com>
---
 .../pyspark/sql/tests/connect/arrow/test_parity_arrow.py | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/python/pyspark/sql/tests/connect/arrow/test_parity_arrow.py b/python/pyspark/sql/tests/connect/arrow/test_parity_arrow.py
index 20ce29c93eab..d3004db20360 100644
--- a/python/pyspark/sql/tests/connect/arrow/test_parity_arrow.py
+++ b/python/pyspark/sql/tests/connect/arrow/test_parity_arrow.py
@@ -24,14 +24,6 @@ from pyspark.testing.pandasutils import PandasOnSparkTestUtils
 
 
 class ArrowParityTests(ArrowTestsMixin, ReusedConnectTestCase, PandasOnSparkTestUtils):
-    @unittest.skip("Spark Connect does not support fallback.")
-    def test_createDataFrame_fallback_disabled(self):
-        super().test_createDataFrame_fallback_disabled()
-
-    @unittest.skip("Spark Connect does not support fallback.")
-    def test_createDataFrame_fallback_enabled(self):
-        super().test_createDataFrame_fallback_enabled()
-
     def test_createDataFrame_pandas_with_map_type(self):
         self.check_createDataFrame_pandas_with_map_type(True)
 
@@ -114,14 +106,6 @@ class ArrowParityTests(ArrowTestsMixin, ReusedConnectTestCase, PandasOnSparkTest
     def test_toPandas_with_array_type(self):
         self.check_toPandas_with_array_type(True)
 
-    @unittest.skip("Spark Connect does not support fallback.")
-    def test_toPandas_fallback_disabled(self):
-        super().test_toPandas_fallback_disabled()
-
-    @unittest.skip("Spark Connect does not support fallback.")
-    def test_toPandas_fallback_enabled(self):
-        super().test_toPandas_fallback_enabled()
-
     def test_toPandas_with_map_type(self):
         self.check_toPandas_with_map_type(True)
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org