[jira] [Closed] (TAP5-2366) Backport: In certain development cases when switching from insecure to secure, BaseURLSource will still include :443 in the URL

["Jochen Kemnade (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TAP5-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jochen Kemnade closed TAP5-2366.
--------------------------------
       Resolution: Fixed
    Fix Version/s: 5.4

Sounds as if this can be closed

> Backport: In certain development cases when switching from insecure to secure, BaseURLSource will still include :443 in the URL
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-2366
>                 URL: https://issues.apache.org/jira/browse/TAP5-2366
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.6
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.4
>
>
> An error in the code means that when secure is true and the port is set to 443, then ":443" is appended:
>         int port = secure ? secureHostPort : hostPort;
>         String portSuffix = "";
>         if (port <= 0) { 
>             port = request.getServerPort();
>             int schemeDefaultPort = request.isSecure() ? 443 : 80;
>             portSuffix = port == schemeDefaultPort ? "" : ":" + port;
>         }
>         else if (secure && port != 443) portSuffix = ":" + port;
>         else if (port != 80) portSuffix = ":" + port;
>         
>         String hostname = "".equals(this.hostname) ? request.getServerName() : this.hostname.startsWith("$") ? System.getenv(this.hostname.substring(1)) : this.hostname;
>         
>         return String.format("%s://%s%s", secure ? "https" : "http", hostname, portSuffix);
> secure == true && port != 443 is false, so
> port != 80 is evaluated, it true, so
> ":443" is appended.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)