You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Cassie <do...@apache.org> on 2008/05/28 00:14:36 UTC
Re: svn commit: r660732 - in /incubator/shindig/trunk/java:
common/pom.xml gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java
gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java
social-api/pom.xml
Louis - this adding of the version for the google-collect package is
redundant. You can see in the root pom.xml that we already specify the
version. This way the same version is kept for all sub packages. Can
you please revert this social-api/pom.xml change?
You may also want to check if commons-io version is already specified
and perhaps revert that change as well.
Thanks.
- Cassie
On Tue, May 27, 2008 at 11:56 PM, Louis Ryan <lr...@google.com> wrote:
> ... apparently submitted bug fix for truncated content in CSS & HTML
> rewriting too by accident.
>
> On Tue, May 27, 2008 at 2:54 PM, <lr...@apache.org> wrote:
>
>> Author: lryan
>> Date: Tue May 27 14:54:14 2008
>> New Revision: 660732
>>
>> URL: http://svn.apache.org/viewvc?rev=660732&view=rev
>> Log:
>> Make versions specific for commons and google-collections
>>
>> Modified:
>> incubator/shindig/trunk/java/common/pom.xml
>>
>> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java
>>
>> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java
>> incubator/shindig/trunk/java/social-api/pom.xml
>>
>> Modified: incubator/shindig/trunk/java/common/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/shindig/trunk/java/common/pom.xml?rev=660732&r1=660731&r2=660732&view=diff
>>
>> ==============================================================================
>> --- incubator/shindig/trunk/java/common/pom.xml (original)
>> +++ incubator/shindig/trunk/java/common/pom.xml Tue May 27 14:54:14 2008
>> @@ -52,6 +52,7 @@
>> <dependency>
>> <groupId>commons-io</groupId>
>> <artifactId>commons-io</artifactId>
>> + <version>1.4</version>
>> </dependency>
>> <dependency>
>> <groupId>org.hamcrest</groupId>
>>
>> Modified:
>> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java?rev=660732&r1=660731&r2=660732&view=diff
>>
>> ==============================================================================
>> ---
>> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java
>> (original)
>> +++
>> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java
>> Tue May 27 14:54:14 2008
>> @@ -64,6 +64,7 @@
>> }
>> writer.write(token.text);
>> }
>> + writer.flush();
>> } catch (ParseException pe) {
>> pe.printStackTrace();
>> } catch (IOException ioe) {
>>
>> Modified:
>> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java?rev=660732&r1=660731&r2=660732&view=diff
>>
>> ==============================================================================
>> ---
>> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java
>> (original)
>> +++
>> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java
>> Tue May 27 14:54:14 2008
>> @@ -96,6 +96,7 @@
>> if (currentTransformer != null) {
>> writer.write(currentTransformer.close());
>> }
>> + writer.flush();
>> } catch (ParseException pe) {
>> pe.printStackTrace();
>> } catch (IOException ioe) {
>>
>> Modified: incubator/shindig/trunk/java/social-api/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/shindig/trunk/java/social-api/pom.xml?rev=660732&r1=660731&r2=660732&view=diff
>>
>> ==============================================================================
>> --- incubator/shindig/trunk/java/social-api/pom.xml (original)
>> +++ incubator/shindig/trunk/java/social-api/pom.xml Tue May 27 14:54:14
>> 2008
>> @@ -66,6 +66,7 @@
>> <dependency>
>> <groupId>com.google.code.google-collections</groupId>
>> <artifactId>google-collect</artifactId>
>> + <version>snapshot-20080321</version>
>> </dependency>
>> <dependency>
>> <groupId>org.apache.abdera</groupId>
>>
>>
>>
>
Re: svn commit: r660732 - in /incubator/shindig/trunk/java: common/pom.xml gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java social-api/pom.xml
Posted by Louis Ryan <lr...@google.com>.
Done.
On Tue, May 27, 2008 at 3:17 PM, Louis Ryan <lr...@google.com> wrote:
> Sure, I was seeing a weirdo build problem but no doubt a weirdo me problem.
>
>
> On Tue, May 27, 2008 at 3:14 PM, Cassie <do...@apache.org> wrote:
>
>> Louis - this adding of the version for the google-collect package is
>> redundant. You can see in the root pom.xml that we already specify the
>> version. This way the same version is kept for all sub packages. Can
>> you please revert this social-api/pom.xml change?
>>
>> You may also want to check if commons-io version is already specified
>> and perhaps revert that change as well.
>>
>> Thanks.
>> - Cassie
>>
>>
>> On Tue, May 27, 2008 at 11:56 PM, Louis Ryan <lr...@google.com> wrote:
>> > ... apparently submitted bug fix for truncated content in CSS & HTML
>> > rewriting too by accident.
>> >
>> > On Tue, May 27, 2008 at 2:54 PM, <lr...@apache.org> wrote:
>> >
>> >> Author: lryan
>> >> Date: Tue May 27 14:54:14 2008
>> >> New Revision: 660732
>> >>
>> >> URL: http://svn.apache.org/viewvc?rev=660732&view=rev
>> >> Log:
>> >> Make versions specific for commons and google-collections
>> >>
>> >> Modified:
>> >> incubator/shindig/trunk/java/common/pom.xml
>> >>
>> >>
>> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java
>> >>
>> >>
>> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java
>> >> incubator/shindig/trunk/java/social-api/pom.xml
>> >>
>> >> Modified: incubator/shindig/trunk/java/common/pom.xml
>> >> URL:
>> >>
>> http://svn.apache.org/viewvc/incubator/shindig/trunk/java/common/pom.xml?rev=660732&r1=660731&r2=660732&view=diff
>> >>
>> >>
>> ==============================================================================
>> >> --- incubator/shindig/trunk/java/common/pom.xml (original)
>> >> +++ incubator/shindig/trunk/java/common/pom.xml Tue May 27 14:54:14
>> 2008
>> >> @@ -52,6 +52,7 @@
>> >> <dependency>
>> >> <groupId>commons-io</groupId>
>> >> <artifactId>commons-io</artifactId>
>> >> + <version>1.4</version>
>> >> </dependency>
>> >> <dependency>
>> >> <groupId>org.hamcrest</groupId>
>> >>
>> >> Modified:
>> >>
>> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java
>> >> URL:
>> >>
>> http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java?rev=660732&r1=660731&r2=660732&view=diff
>> >>
>> >>
>> ==============================================================================
>> >> ---
>> >>
>> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java
>> >> (original)
>> >> +++
>> >>
>> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java
>> >> Tue May 27 14:54:14 2008
>> >> @@ -64,6 +64,7 @@
>> >> }
>> >> writer.write(token.text);
>> >> }
>> >> + writer.flush();
>> >> } catch (ParseException pe) {
>> >> pe.printStackTrace();
>> >> } catch (IOException ioe) {
>> >>
>> >> Modified:
>> >>
>> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java
>> >> URL:
>> >>
>> http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java?rev=660732&r1=660731&r2=660732&view=diff
>> >>
>> >>
>> ==============================================================================
>> >> ---
>> >>
>> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java
>> >> (original)
>> >> +++
>> >>
>> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java
>> >> Tue May 27 14:54:14 2008
>> >> @@ -96,6 +96,7 @@
>> >> if (currentTransformer != null) {
>> >> writer.write(currentTransformer.close());
>> >> }
>> >> + writer.flush();
>> >> } catch (ParseException pe) {
>> >> pe.printStackTrace();
>> >> } catch (IOException ioe) {
>> >>
>> >> Modified: incubator/shindig/trunk/java/social-api/pom.xml
>> >> URL:
>> >>
>> http://svn.apache.org/viewvc/incubator/shindig/trunk/java/social-api/pom.xml?rev=660732&r1=660731&r2=660732&view=diff
>> >>
>> >>
>> ==============================================================================
>> >> --- incubator/shindig/trunk/java/social-api/pom.xml (original)
>> >> +++ incubator/shindig/trunk/java/social-api/pom.xml Tue May 27 14:54:14
>> >> 2008
>> >> @@ -66,6 +66,7 @@
>> >> <dependency>
>> >> <groupId>com.google.code.google-collections</groupId>
>> >> <artifactId>google-collect</artifactId>
>> >> + <version>snapshot-20080321</version>
>> >> </dependency>
>> >> <dependency>
>> >> <groupId>org.apache.abdera</groupId>
>> >>
>> >>
>> >>
>> >
>>
>
>
Re: svn commit: r660732 - in /incubator/shindig/trunk/java: common/pom.xml gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java social-api/pom.xml
Posted by Louis Ryan <lr...@google.com>.
Sure, I was seeing a weirdo build problem but no doubt a weirdo me problem.
On Tue, May 27, 2008 at 3:14 PM, Cassie <do...@apache.org> wrote:
> Louis - this adding of the version for the google-collect package is
> redundant. You can see in the root pom.xml that we already specify the
> version. This way the same version is kept for all sub packages. Can
> you please revert this social-api/pom.xml change?
>
> You may also want to check if commons-io version is already specified
> and perhaps revert that change as well.
>
> Thanks.
> - Cassie
>
>
> On Tue, May 27, 2008 at 11:56 PM, Louis Ryan <lr...@google.com> wrote:
> > ... apparently submitted bug fix for truncated content in CSS & HTML
> > rewriting too by accident.
> >
> > On Tue, May 27, 2008 at 2:54 PM, <lr...@apache.org> wrote:
> >
> >> Author: lryan
> >> Date: Tue May 27 14:54:14 2008
> >> New Revision: 660732
> >>
> >> URL: http://svn.apache.org/viewvc?rev=660732&view=rev
> >> Log:
> >> Make versions specific for commons and google-collections
> >>
> >> Modified:
> >> incubator/shindig/trunk/java/common/pom.xml
> >>
> >>
> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java
> >>
> >>
> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java
> >> incubator/shindig/trunk/java/social-api/pom.xml
> >>
> >> Modified: incubator/shindig/trunk/java/common/pom.xml
> >> URL:
> >>
> http://svn.apache.org/viewvc/incubator/shindig/trunk/java/common/pom.xml?rev=660732&r1=660731&r2=660732&view=diff
> >>
> >>
> ==============================================================================
> >> --- incubator/shindig/trunk/java/common/pom.xml (original)
> >> +++ incubator/shindig/trunk/java/common/pom.xml Tue May 27 14:54:14 2008
> >> @@ -52,6 +52,7 @@
> >> <dependency>
> >> <groupId>commons-io</groupId>
> >> <artifactId>commons-io</artifactId>
> >> + <version>1.4</version>
> >> </dependency>
> >> <dependency>
> >> <groupId>org.hamcrest</groupId>
> >>
> >> Modified:
> >>
> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java
> >> URL:
> >>
> http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java?rev=660732&r1=660731&r2=660732&view=diff
> >>
> >>
> ==============================================================================
> >> ---
> >>
> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java
> >> (original)
> >> +++
> >>
> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRewriter.java
> >> Tue May 27 14:54:14 2008
> >> @@ -64,6 +64,7 @@
> >> }
> >> writer.write(token.text);
> >> }
> >> + writer.flush();
> >> } catch (ParseException pe) {
> >> pe.printStackTrace();
> >> } catch (IOException ioe) {
> >>
> >> Modified:
> >>
> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java
> >> URL:
> >>
> http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java?rev=660732&r1=660731&r2=660732&view=diff
> >>
> >>
> ==============================================================================
> >> ---
> >>
> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java
> >> (original)
> >> +++
> >>
> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HtmlRewriter.java
> >> Tue May 27 14:54:14 2008
> >> @@ -96,6 +96,7 @@
> >> if (currentTransformer != null) {
> >> writer.write(currentTransformer.close());
> >> }
> >> + writer.flush();
> >> } catch (ParseException pe) {
> >> pe.printStackTrace();
> >> } catch (IOException ioe) {
> >>
> >> Modified: incubator/shindig/trunk/java/social-api/pom.xml
> >> URL:
> >>
> http://svn.apache.org/viewvc/incubator/shindig/trunk/java/social-api/pom.xml?rev=660732&r1=660731&r2=660732&view=diff
> >>
> >>
> ==============================================================================
> >> --- incubator/shindig/trunk/java/social-api/pom.xml (original)
> >> +++ incubator/shindig/trunk/java/social-api/pom.xml Tue May 27 14:54:14
> >> 2008
> >> @@ -66,6 +66,7 @@
> >> <dependency>
> >> <groupId>com.google.code.google-collections</groupId>
> >> <artifactId>google-collect</artifactId>
> >> + <version>snapshot-20080321</version>
> >> </dependency>
> >> <dependency>
> >> <groupId>org.apache.abdera</groupId>
> >>
> >>
> >>
> >
>