You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by caofangkun <gi...@git.apache.org> on 2014/12/24 05:00:43 UTC
[GitHub] storm pull request: STORM-596: remove config topology.receiver.buf...
GitHub user caofangkun opened a pull request:
https://github.com/apache/storm/pull/363
STORM-596: remove config topology.receiver.buffer.size
topology.receiver.buffer.size has no effect and not necessary for now.
Should we just remove it ?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/caofangkun/apache-storm storm-596
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/363.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #363
----
commit 97ae36e42abc961fbcc54dd77c80bafff30dce7e
Author: caofangkun <ca...@gmail.com>
Date: 2014-12-22T08:18:08Z
Merge pull request #2 from apache/master
Merge from trunk to caofangkun
commit cad1505deb214facb0fb70e24034e30f79a973da
Author: caofangkun <ca...@gmail.com>
Date: 2014-12-24T03:44:25Z
STORM-596: remove config topology.receiver.buffer.size
commit 986ad60bf065c8c3dd965b5c2cfd33d71229385b
Author: caofangkun <ca...@gmail.com>
Date: 2014-12-24T03:56:12Z
STORM-596: rm defaults.yaml.orig Config.java.orig
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-596: remove config topology.receiver.buf...
Posted by caofangkun <gi...@git.apache.org>.
Github user caofangkun commented on the pull request:
https://github.com/apache/storm/pull/363#issuecomment-73459763
@harshach
Could you please have a review on this PR? Thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-596: remove config topology.receiver.buf...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/363#issuecomment-78316822
This is technically a non-backwards compatible change, but I think it is OK. I am +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-596: remove config topology.receiver.buf...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/363#discussion_r29286966
--- Diff: storm-core/src/clj/backtype/storm/daemon/worker.clj ---
@@ -355,8 +355,7 @@
(:storm-id worker)
(:receiver-thread-count worker)
(:port worker)
- (:transfer-local-fn worker)
- (-> worker :storm-conf (get TOPOLOGY-RECEIVER-BUFFER-SIZE))
+ (:transfer-local-fn worker))
--- End diff --
There is an extra ')' here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-596: remove config topology.receiver.buf...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/363#issuecomment-104753517
No one else has decided to review this, and it still compiles and I am still +1 so I will merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-596: remove config topology.receiver.buf...
Posted by Lewuathe <gi...@git.apache.org>.
Github user Lewuathe commented on the pull request:
https://github.com/apache/storm/pull/363#issuecomment-68353816
@caofangkun I think correct behaviour is restricting the max size of `batched` ArrayList within given `max-buffer-size` . But if you mean this parameter is not necessary anyway, removing at all is a option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-596: remove config topology.receiver.buf...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/363
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---