You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/05/09 23:49:38 UTC
[kudu-CR] KUDU-2671 relax requirement for partition range specification
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18509
Change subject: KUDU-2671 relax requirement for partition range specification
......................................................................
KUDU-2671 relax requirement for partition range specification
As of now (see [1]), the number of hash dimensions in a per-range custom
hash schema must be the same for all the ranges in a table. With that,
it's possible to relax the requirements on specifying partition key
ranges for a GetTableLocations RPC. That allows legacy Kudu clients
to work with tables having custom hash schemas per range. If necessary,
it's possible to make the requirements stricter by setting
--require_new_spec_for_custom_hash_schema_range_bound=true.
This is a follow-up to [1].
[1] https://github.com/apache/kudu/commit/6998193e69eeda497f912d1d806470c95b591ad4
Change-Id: Idfdae92f6baee5e8f197cba41c8e51120f9b4d58
---
M src/kudu/master/catalog_manager-test.cc
M src/kudu/master/catalog_manager.cc
2 files changed, 39 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/18509/1
--
To view, visit http://gerrit.cloudera.org:8080/18509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idfdae92f6baee5e8f197cba41c8e51120f9b4d58
Gerrit-Change-Number: 18509
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-2671 relax requirement for partition range specification
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18509 )
Change subject: KUDU-2671 relax requirement for partition range specification
......................................................................
KUDU-2671 relax requirement for partition range specification
As of now (see [1]), the number of hash dimensions in a per-range custom
hash schema must be the same for all the ranges in a table. With that,
it's possible to relax the requirements on specifying partition key
ranges for a GetTableLocations RPC. That allows legacy Kudu clients
to work with tables having custom hash schemas per range. If necessary,
it's possible to make the requirements stricter by setting
--require_new_spec_for_custom_hash_schema_range_bound=true.
This is a follow-up to [1].
[1] https://github.com/apache/kudu/commit/6998193e69eeda497f912d1d806470c95b591ad4
Change-Id: Idfdae92f6baee5e8f197cba41c8e51120f9b4d58
Reviewed-on: http://gerrit.cloudera.org:8080/18509
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/master/catalog_manager-test.cc
M src/kudu/master/catalog_manager.cc
2 files changed, 39 insertions(+), 12 deletions(-)
Approvals:
Attila Bukor: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idfdae92f6baee5e8f197cba41c8e51120f9b4d58
Gerrit-Change-Number: 18509
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 relax requirement for partition range specification
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18509 )
Change subject: KUDU-2671 relax requirement for partition range specification
......................................................................
Patch Set 1: Verified+1
Unrelated test failures:
* DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
* org.apache.kudu.spark.kudu.DefaultSourceTest
--
To view, visit http://gerrit.cloudera.org:8080/18509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfdae92f6baee5e8f197cba41c8e51120f9b4d58
Gerrit-Change-Number: 18509
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 May 2022 17:49:34 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 relax requirement for partition range specification
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18509 )
Change subject: KUDU-2671 relax requirement for partition range specification
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfdae92f6baee5e8f197cba41c8e51120f9b4d58
Gerrit-Change-Number: 18509
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 May 2022 17:41:50 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 relax requirement for partition range specification
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-2671 relax requirement for partition range specification
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Idfdae92f6baee5e8f197cba41c8e51120f9b4d58
Gerrit-Change-Number: 18509
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>