You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mdeshmu (via GitHub)" <gi...@apache.org> on 2023/07/16 06:31:22 UTC

[GitHub] [superset] mdeshmu opened a new pull request, #24708: Test pyhive 0.7.1.dev0 with python 3.11

mdeshmu opened a new pull request, #24708:
URL: https://github.com/apache/superset/pull/24708

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   Test pyhive 0.7.1.dev0 with python 3.11
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] mdeshmu closed pull request #24708: Test pyhive 0.7.1.dev0 with python 3.11

Posted by "mdeshmu (via GitHub)" <gi...@apache.org>.
mdeshmu closed pull request #24708: Test pyhive 0.7.1.dev0 with python 3.11
URL: https://github.com/apache/superset/pull/24708


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #24708: Test pyhive 0.7.1.dev0 with python 3.11

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24708:
URL: https://github.com/apache/superset/pull/24708#issuecomment-1636996447

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24708?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#24708](https://app.codecov.io/gh/apache/superset/pull/24708?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7d32ec2) into [master](https://app.codecov.io/gh/apache/superset/commit/0328dd270467e71260bfa85078beb7b38a87877b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0328dd2) will **decrease** coverage by `10.81%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 7d32ec2 differs from pull request most recent head 9e5f891. Consider uploading reports for the commit 9e5f891 to get more accurate results
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #24708       +/-   ##
   ===========================================
   - Coverage   68.97%   58.17%   -10.81%     
   ===========================================
     Files        1901     1901               
     Lines       74008    74020       +12     
     Branches     8183     8183               
   ===========================================
   - Hits        51047    43060     -7987     
   - Misses      20840    28839     +7999     
     Partials     2121     2121               
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `?` | |
   | postgres | `?` | |
   | presto | `54.02% <55.55%> (+<0.01%)` | :arrow_up: |
   | python | `60.85% <100.00%> (-22.60%)` | :arrow_down: |
   | sqlite | `?` | |
   | unit | `54.84% <100.00%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [superset/common/chart\_data.py](https://app.codecov.io/gh/apache/superset/pull/24708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbW9uL2NoYXJ0X2RhdGEucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/sql\_parse.py](https://app.codecov.io/gh/apache/superset/pull/24708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `95.50% <100.00%> (-1.07%)` | :arrow_down: |
   
   ... and [293 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24708/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org