[GitHub] [incubator-superset] etr2460 opened a new pull request #8231: [SQL Lab] Fix bug when filtering on results that include nulls

[GitBox <gi...@apache.org>]

etr2460 opened a new pull request #8231: [SQL Lab] Fix bug when filtering on results that include nulls
URL: https://github.com/apache/incubator-superset/pull/8231
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Fixes a `TypeError: Cannot read property 'toString' of null` when you filter results in SQL Lab and the results set includes null values. Also adds a unit test to confirm the fix.
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Test filtering when the results set includes null values. Also run unit tests.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @graceguo-supercat @betodealmeida @michellethomas @xtinec 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org