[jira] [Commented] (DERBY-6082) Investigate if openOnServer_ field in org.apache.derby.client.am.Statement is still needed.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-6082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815744#comment-13815744 ] 

ASF subversion and git services commented on DERBY-6082:
--------------------------------------------------------

Commit 1539540 from [~dyret] in branch 'code/trunk'
[ https://svn.apache.org/r1539540 ]

DERBY-6082: Removed re-prepares trigged by openOnServer_

Changed piggy-backing of prepare of preparedStatementForAutogeneratedKeys_ so that it doesn't need openOnServer_ 

Removed MaterialStatement.markClosedOnServer and implementation since it did not do anything.

Since this reduced ClientStatement.markClosedOnServer() to a cleanup-method for section_, it was removed and section_ was encapsulated as a private member where setSection is responsible for cleanup.

Patch file derby-6082a.diff. (+ review comment)

> Investigate if openOnServer_ field in org.apache.derby.client.am.Statement is still needed.
> -------------------------------------------------------------------------------------------
>
>                 Key: DERBY-6082
>                 URL: https://issues.apache.org/jira/browse/DERBY-6082
>             Project: Derby
>          Issue Type: Task
>          Components: Network Client
>    Affects Versions: 10.10.1.1
>            Reporter: Mamta A. Satoor
>            Assignee: Dyre Tjeldvoll
>         Attachments: derby-6082a.diff
>
>
> While working on DERBY-6053, there was some discussion over openOnServer_ field in org.apache.derby.client.am.Statement. This field has following comment in Statement class
>     // This means a DERBY server-side section for this statement is in the prepared state. 
>     // A client-side jdbc statement may remain open across commits (openOnClient=true), 
>     // but the server-side DERBY section moves to an unprepared state (openOnServer=false) across commits, 
>     // requiring an implicit re-prepare "under the covers" by the driver. 
>     // Unprepared jdbc query statements still have prepared sections on the server. 
>     // This openOnServer_ only has implications for preparedstatement 
> Kathey commented following on that field in DERBY-6053
> *******************************************************************************
>  I do not think that comment is true about statements not staying prepared across commits.
> If I prepare a statement and execute it twice with a commit in between from client, I do not see a reprepare in the derby.log . I think maybe the openOnServer_ property may be a relic of some place or time in the original code base when that was true.
> *******************************************************************************



--
This message was sent by Atlassian JIRA
(v6.1#6144)