You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/10/09 03:07:15 UTC
[GitHub] [ozone] ChenSammi opened a new pull request #2725: HDDS-5844. Provide capability to config ratis grpcLogAppender max pending request and log write buffer size
ChenSammi opened a new pull request #2725:
URL: https://github.com/apache/ozone/pull/2725
https://issues.apache.org/jira/browse/HDDS-5844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi edited a comment on pull request #2725: HDDS-5844. Provide capability to config ratis grpcLogAppender max pending request and log write buffer size
Posted by GitBox <gi...@apache.org>.
ChenSammi edited a comment on pull request #2725:
URL: https://github.com/apache/ozone/pull/2725#issuecomment-942883124
>
>
> @ChenSammi , the patch looks ok. Any specfic reason to make these explicitly configurable?
Hey @bshashikant , we'm tring to find a set of recommended ratis property configurations for a new high density HDD cluster. We'd like to have this ratis property tuning capability in Ozone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on pull request #2725: HDDS-5844. Provide capability to config ratis grpcLogAppender max pending request and log write buffer size
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #2725:
URL: https://github.com/apache/ozone/pull/2725#issuecomment-942064468
@ChenSammi , the patch looks ok. Any specfic reason to make these configurable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant edited a comment on pull request #2725: HDDS-5844. Provide capability to config ratis grpcLogAppender max pending request and log write buffer size
Posted by GitBox <gi...@apache.org>.
bshashikant edited a comment on pull request #2725:
URL: https://github.com/apache/ozone/pull/2725#issuecomment-942064468
@ChenSammi , the patch looks ok. Any specfic reason to make these explicitly configurable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a change in pull request #2725: HDDS-5844. Provide capability to config ratis grpcLogAppender max pending request and log write buffer size
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on a change in pull request #2725:
URL: https://github.com/apache/ozone/pull/2725#discussion_r737113523
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
##########
@@ -413,7 +415,10 @@ private void setRaftSegmentAndWriteBufferSize(RaftProperties properties) {
RaftServerConfigKeys.Log.setSegmentSizeMax(properties,
SizeInBytes.valueOf(raftSegmentSize));
RaftServerConfigKeys.Log.setWriteBufferSize(properties,
- SizeInBytes.valueOf(raftSegmentSize));
+ SizeInBytes.valueOf(conf.getObject(DatanodeRatisServerConfig.class)
Review comment:
Hey @bharatviswa504 , besides the new added properties which can be handled alternatively by adding Ozone prefix, I'd like to seperate the raft log write buffer size with raft log file size. Any specific reason that these two properties value should use the same value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on pull request #2725: HDDS-5844. Provide capability to config ratis grpcLogAppender max pending request and log write buffer size
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #2725:
URL: https://github.com/apache/ozone/pull/2725#issuecomment-942938582
@ChenSammi In Datanode we can add any ratis GRPC config by appending with hdds.ratis.raft.grpc.<<ratis property>> and hdds.ratis.raft.server.<<ratisconfig>>. The idea behind this is we donot need to we can add any ratis config with out any code changes.
`we'm tring to find a set of recommended ratis property configurations for a new high density HDD`
For this we can have doc update in our documentation which we feel recommended and explain about them instead of adding to code, so that end users can know about them, than adding to these Java classes. Thoughts??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2725: HDDS-5844. Provide capability to config ratis grpcLogAppender max pending request and log write buffer size
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2725:
URL: https://github.com/apache/ozone/pull/2725#discussion_r775479911
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
##########
@@ -413,7 +415,10 @@ private void setRaftSegmentAndWriteBufferSize(RaftProperties properties) {
RaftServerConfigKeys.Log.setSegmentSizeMax(properties,
SizeInBytes.valueOf(raftSegmentSize));
RaftServerConfigKeys.Log.setWriteBufferSize(properties,
- SizeInBytes.valueOf(raftSegmentSize));
+ SizeInBytes.valueOf(conf.getObject(DatanodeRatisServerConfig.class)
Review comment:
@bharatviswa504 @bshashikant can you please answer @ChenSammi's question about max. segment size vs. write buffer size?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] github-actions[bot] commented on pull request #2725: HDDS-5844. Provide capability to config ratis grpcLogAppender max pending request and log write buffer size
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2725:
URL: https://github.com/apache/ozone/pull/2725#issuecomment-1014966194
Thank you very much for the patch. I am closing this PR __temporarily__ as there was no activity recently and it is waiting for response from its author.
It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.
It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.
If you need ANY help to finish this PR, please [contact the community](https://github.com/apache/hadoop-ozone#contact) on the mailing list or the slack channel."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] github-actions[bot] closed pull request #2725: HDDS-5844. Provide capability to config ratis grpcLogAppender max pending request and log write buffer size
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #2725:
URL: https://github.com/apache/ozone/pull/2725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant edited a comment on pull request #2725: HDDS-5844. Provide capability to config ratis grpcLogAppender max pending request and log write buffer size
Posted by GitBox <gi...@apache.org>.
bshashikant edited a comment on pull request #2725:
URL: https://github.com/apache/ozone/pull/2725#issuecomment-942064468
@ChenSammi , the patch looks ok. Any specfic reason to make these explicitly configurable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2725: HDDS-5844. Provide capability to config ratis grpcLogAppender max pending request and log write buffer size
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2725:
URL: https://github.com/apache/ozone/pull/2725#issuecomment-942883124
>
>
> @ChenSammi , the patch looks ok. Any specfic reason to make these explicitly configurable?
Hey shashi, we'm tring to find a set of recommended ratis property configurations for a new high density HDD cluster. We'd like to have this ratis property tuning capability in Ozone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on pull request #2725: HDDS-5844. Provide capability to config ratis grpcLogAppender max pending request and log write buffer size
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #2725:
URL: https://github.com/apache/ozone/pull/2725#issuecomment-942064468
@ChenSammi , the patch looks ok. Any specfic reason to make these configurable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 edited a comment on pull request #2725: HDDS-5844. Provide capability to config ratis grpcLogAppender max pending request and log write buffer size
Posted by GitBox <gi...@apache.org>.
bharatviswa504 edited a comment on pull request #2725:
URL: https://github.com/apache/ozone/pull/2725#issuecomment-942938582
@ChenSammi In Datanode we can add any ratis GRPC config by appending with hdds.ratis.raft.grpc.`ratis config` and hdds.ratis.raft.server.`ratisconfig`. The idea behind this is we donot need to we can add any ratis config with out any code changes.
`we'm tring to find a set of recommended ratis property configurations for a new high density HDD`
For this we can have doc update in our documentation which we feel recommended and explain about them instead of adding to code, so that end users can know about them, than adding to these Java classes. Thoughts??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 edited a comment on pull request #2725: HDDS-5844. Provide capability to config ratis grpcLogAppender max pending request and log write buffer size
Posted by GitBox <gi...@apache.org>.
bharatviswa504 edited a comment on pull request #2725:
URL: https://github.com/apache/ozone/pull/2725#issuecomment-942938582
@ChenSammi In Datanode we can add any ratis GRPC config by appending with hdds.ratis.raft.grpc.<ratis config> and hdds.ratis.raft.server.<ratisconfig>. The idea behind this is we donot need to we can add any ratis config with out any code changes.
`we'm tring to find a set of recommended ratis property configurations for a new high density HDD`
For this we can have doc update in our documentation which we feel recommended and explain about them instead of adding to code, so that end users can know about them, than adding to these Java classes. Thoughts??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2725: HDDS-5844. Provide capability to config ratis grpcLogAppender max pending request and log write buffer size
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2725:
URL: https://github.com/apache/ozone/pull/2725#issuecomment-1001547392
/pending skip adding new properties (prefer prefix-based approach)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org