You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/15 14:28:24 UTC
[GitHub] [arrow] jonkeane opened a new pull request #10052: ARROW-12406: [R] fix checkbashims violation in configure
jonkeane opened a new pull request #10052:
URL: https://github.com/apache/arrow/pull/10052
Fix checkbashim foo=bar; export foo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #10052: ARROW-12406: [R] fix checkbashims violation in configure
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #10052:
URL: https://github.com/apache/arrow/pull/10052#discussion_r614162265
##########
File path: r/configure
##########
@@ -148,7 +148,7 @@ else
if [ "$UNAME" = "Darwin" ] && [ "${OPENSSL_ROOT_DIR}" = "" ]; then
brew --prefix openssl >/dev/null 2>&1
if [ $? -eq 0 ]; then
- export OPENSSL_ROOT_DIR="$(brew --prefix openssl)"
+ OPENSSL_ROOT_DIR="$(brew --prefix openssl)"; export OPENSSL_ROOT_DIR
Review comment:
(insert BDR quote about how `$()` was a completely unnecessary change in bash)
```suggestion
OPENSSL_ROOT_DIR="`brew --prefix openssl`"; export OPENSSL_ROOT_DIR
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10052: ARROW-12406: [R] fix checkbashims violation in configure
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10052:
URL: https://github.com/apache/arrow/pull/10052#issuecomment-820506682
R CI from my branch:
https://github.com/jonkeane/arrow/actions/runs/752347395
And crossbow manual build (there is still noise and a separate failure, but this issue is fixed):
https://github.com/ursacomputing/crossbow/runs/2353713416?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10052: ARROW-12406: [R] fix checkbashims violation in configure
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10052:
URL: https://github.com/apache/arrow/pull/10052#issuecomment-820509298
What remains of the checkbashism has been around since February (before we added the line that this PR fixes)
https://github.com/ursacomputing/crossbow/runs/1985368794?check_suite_focus=true#step:7:181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #10052: ARROW-12406: [R] Fix checkbashism violation in configure
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #10052:
URL: https://github.com/apache/arrow/pull/10052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10052: ARROW-12406: [R] Fix checkbashism violation in configure
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10052:
URL: https://github.com/apache/arrow/pull/10052#issuecomment-820570819
https://issues.apache.org/jira/browse/ARROW-12406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org