You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/07 17:18:06 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #8145: ARROW-9967: [Python] Add compute module docs + expose more option classes

pitrou commented on a change in pull request #8145:
URL: https://github.com/apache/arrow/pull/8145#discussion_r501180479



##########
File path: python/pyarrow/_compute.pyx
##########
@@ -669,3 +669,13 @@ cdef class StrptimeOptions(FunctionOptions):
 
     cdef const CFunctionOptions* get_options(self) except NULL:
         return self.strptime_options.get()
+
+cdef class VarianceOptions(FunctionOptions):
+    cdef:
+        unique_ptr[CVarianceOptions] variance_options

Review comment:
       I'm not sure why `unique_ptr` is used in some of the other classes, but it shouldn't be necessary. See `MinMaxOptions` for an example without.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org