You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Sander Striker <st...@apache.org> on 2003/05/27 21:07:22 UTC
[VOTE]: Apache 2.0.46
Hi,
I'd like to call a vote to release STRIKER_2_0_46_PRE2
as httpd-2.0.46.
After the usual +1s, ;), I'll do the final T&R.
Thanks,
Sander
Re: mod_expires is broken was Re: [VOTE]: Apache 2.0.46
Posted by Bill Stoddard <bi...@wstoddard.com>.
Jeff Trawick wrote:
> Justin Erenkrantz wrote:
>
>> --On Tuesday, May 27, 2003 1:29 PM -0700 Justin Erenkrantz
>> <ju...@erenkrantz.com> wrote:
>
>
>> ExpiresDefault is busted.
>>
>> The offending line is mod_expires.c:531.
>>
>> t = apr_table_overlay(r->pool, notes->expfields, t);
>>
>> apr_table_overlay may create a new table
>
> always does, right? (or the doc is wrong :) )
>
> It shouldn't matter whether the Expires and Cache-Control fields are
> added to headers_out or err_headers_out at this point in the filter
> chain, so shouldn't this work as a replacement?
>
> r->headers_out =
> apr_table_overlay(r->pool, notes->expfields, r->headers_out);
>
That looks right to me.
Bill
Re: mod_expires is broken was Re: [VOTE]: Apache 2.0.46
Posted by Jeff Trawick <tr...@attglobal.net>.
Justin Erenkrantz wrote:
> --On Tuesday, May 27, 2003 1:29 PM -0700 Justin Erenkrantz
> <ju...@erenkrantz.com> wrote:
> ExpiresDefault is busted.
>
> The offending line is mod_expires.c:531.
>
> t = apr_table_overlay(r->pool, notes->expfields, t);
>
> apr_table_overlay may create a new table
always does, right? (or the doc is wrong :) )
It shouldn't matter whether the Expires and Cache-Control fields are
added to headers_out or err_headers_out at this point in the filter
chain, so shouldn't this work as a replacement?
r->headers_out =
apr_table_overlay(r->pool, notes->expfields, r->headers_out);
RE: mod_expires is broken was Re: [VOTE]: Apache 2.0.46
Posted by Sander Striker <st...@apache.org>.
> From: Justin Erenkrantz [mailto:justin@erenkrantz.com]
> Sent: Tuesday, May 27, 2003 11:19 PM
> --On Tuesday, May 27, 2003 1:29 PM -0700 Justin Erenkrantz
> <ju...@erenkrantz.com> wrote:
>
> > httpd-test's perl-framework is failing on the expires test. Am looking into
> > it now to see what is going on, but does anyone else see this? -- justin
>
> ExpiresDefault is busted.
>
> The offending line is mod_expires.c:531.
>
> t = apr_table_overlay(r->pool, notes->expfields, t);
>
> apr_table_overlay may create a new table, so the original pointer has to be
> updated as well. I'm trying to figure out what the proper fix is to this.
> The code makes it hard to figure out what t should be reset to in a clean
> manner.
>
> Using a ** might work, but that's lame. -- justin
Okay. Considering that reverting modules/metadata/mod_expires.c r1.39.2.2
doesn't lead to a regression with respect to 2.0.45, I'm considering that to
be the best option.
I'll drop it from the tag. Next release, which is hopefully a but quicker
in succession to 2.0.46 than 2.0.46 is to 2.0.45, can have a proper fix.
Sander
mod_expires is broken was Re: [VOTE]: Apache 2.0.46
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Tuesday, May 27, 2003 1:29 PM -0700 Justin Erenkrantz
<ju...@erenkrantz.com> wrote:
> httpd-test's perl-framework is failing on the expires test. Am looking into
> it now to see what is going on, but does anyone else see this? -- justin
ExpiresDefault is busted.
The offending line is mod_expires.c:531.
t = apr_table_overlay(r->pool, notes->expfields, t);
apr_table_overlay may create a new table, so the original pointer has to be
updated as well. I'm trying to figure out what the proper fix is to this.
The code makes it hard to figure out what t should be reset to in a clean
manner.
Using a ** might work, but that's lame. -- justin
Re: [VOTE]: Apache 2.0.46
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Tuesday, May 27, 2003 9:07 PM +0200 Sander Striker <st...@apache.org>
wrote:
> Hi,
>
> I'd like to call a vote to release STRIKER_2_0_46_PRE2
> as httpd-2.0.46.
>
> After the usual +1s, ;), I'll do the final T&R.
httpd-test's perl-framework is failing on the expires test. Am looking into
it now to see what is going on, but does anyone else see this? -- justin
FAILED tests 2, 9, 13, 17, 21, 25, 29, 33, 37, 41, 45, 49
Failed 12/92 tests, 86.96% okay
Failed Test Stat Wstat Total Fail Failed List of Failed
-------------------------------------------------------------------------------
modules/expires.t 92 12 13.04% 2 9 13 17 21 25 29 33 37 41 45
49
RE: [VOTE]: Apache 2.0.46
Posted by Sander Striker <st...@apache.org>.
> From: Andre Malo [mailto:nd@perlig.de]
> Sent: Wednesday, May 28, 2003 2:24 AM
> * Sander Striker wrote:
>
> > Hi,
> >
> > I'd like to call a vote to release STRIKER_2_0_46_PRE2
> > as httpd-2.0.46.
>
> Please bump docs/manual/content-negotiation.* and docs/manual/env.* back to
> pre2. (prefer-language isn't in yet)
Will do. Thanks for the heads up. Prolly a stale viewcvs page I was looking
at...
Sander
Re: [VOTE]: Apache 2.0.46
Posted by André Malo <nd...@perlig.de>.
* Sander Striker wrote:
> Hi,
>
> I'd like to call a vote to release STRIKER_2_0_46_PRE2
> as httpd-2.0.46.
Please bump docs/manual/content-negotiation.* and docs/manual/env.* back to
pre2. (prefer-language isn't in yet)
nd
--
+++++[>++++++<-]>++>++++++[>++++++++++++<-]>++.<++++[>++++++++++<-]>+++.--.+.<
<.>++++[>----<-]>---.<+++[>++++<-]>+.+.+++++.<+++[>----<-]>.---.<+++[>++++<-]>
+.<<.>+++++[>-------<-]>+.<+++++[>++++<-]>+.<+++[>++++<-]>+.------.<<.>++++++
[>------<-]>.<+++++[>+++++<-]>.++.++++++++.------.<+++[>++++<-]>+.
Re: [VOTE]: Apache 2.0.46
Posted by Bill Stoddard <bi...@wstoddard.com>.
Justin Erenkrantz wrote:
> --On Tuesday, May 27, 2003 9:07 PM +0200 Sander Striker
> <st...@apache.org> wrote:
>
>> I'd like to call a vote to release STRIKER_2_0_46_PRE2
>> as httpd-2.0.46.
>
>
> +1 on _PRE3 (which is _PRE2 minus mod_expires brokenness) for Solaris,
> Darwin, and FreeBSD. -- justin
+1 (with or w/o repaired mod_expires) on Win2K.
Bill
Re: [VOTE]: Apache 2.0.46
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Tuesday, May 27, 2003 9:07 PM +0200 Sander Striker <st...@apache.org>
wrote:
> I'd like to call a vote to release STRIKER_2_0_46_PRE2
> as httpd-2.0.46.
+1 on _PRE3 (which is _PRE2 minus mod_expires brokenness) for Solaris, Darwin,
and FreeBSD. -- justin
Re: [VOTE]: Apache 2.0.46
Posted by Bill Stoddard <bi...@wstoddard.com>.
Bill Stoddard wrote:
> Jeff Trawick wrote:
>
>> Sander Striker wrote:
>>
>>> Hi,
>>>
>>> I'd like to call a vote to release STRIKER_2_0_46_PRE2
>>> as httpd-2.0.46.
>>
>>
>>
>> +1 (assuming the mod_expires change reverted)
>
>
> or fixed? Check my latest commit.
okay, forget that. It will be in 2.0.47
Bill
Re: [VOTE]: Apache 2.0.46
Posted by Bill Stoddard <bi...@wstoddard.com>.
Jeff Trawick wrote:
> Sander Striker wrote:
>
>> Hi,
>>
>> I'd like to call a vote to release STRIKER_2_0_46_PRE2
>> as httpd-2.0.46.
>
>
> +1 (assuming the mod_expires change reverted)
or fixed? Check my latest commit.
Bill
Re: [VOTE]: Apache 2.0.46
Posted by Jeff Trawick <tr...@attglobal.net>.
Sander Striker wrote:
> Hi,
>
> I'd like to call a vote to release STRIKER_2_0_46_PRE2
> as httpd-2.0.46.
+1 (assuming the mod_expires change reverted)