You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Graeme Steyn (JIRA)" <de...@myfaces.apache.org> on 2007/12/21 03:34:43 UTC
[jira] Created: (TRINIDAD-880) Clientside validation errors when
using PPR
Clientside validation errors when using PPR
-------------------------------------------
Key: TRINIDAD-880
URL: https://issues.apache.org/jira/browse/TRINIDAD-880
Project: MyFaces Trinidad
Issue Type: Bug
Affects Versions: 1.2.4-core, 1.2.3-core
Environment: Windows XP Pro SP2, Facelets 1.1.13, Sun Java System Application Server 9.1, JSF1.2_07-b03
Reporter: Graeme Steyn
To reproduce the problem deploy the attached sample application and execute the following sequence of actions.
1. All radio buttons should be blank when form is first displayed - press "Submit" - validation error occurs for first question (expected).
2. Select "Yes" for "Is English your first language?" - press "Submit" - validation error is cleared and form re-displayed.
3. Select "No" for "Is English your first language?" - press "Submit" - validation error occurs for second question (expected).
4. Select "Yes" for "Is English your first language?" - ppr results in second question being disabled, not required and clears validation message.
5. Press "Submit" - validation error occurs for second question (fault).
6. Select "No" for "Is English your first language?"
7. Select "Yes" for second question. Notice that a new required field appears.
8. Press "Submit" - validation error occurs for the new field (expected).
8. Select "No" for second question. The additional required field disappears.
9. Press "Submit" - Error appears: "Field Error [certDetails] - Enter a value" (fault).
10. Acknowledge and select "Yes" for "Is English your first language?" - press "Submit" - 2 validation error messages occur (fault).
Using Firebug, it appears that the ppr is taking place correctly, but checking the DOM for _english_Validators shows that all three validators are eventually listed.
I am assuming that this is what is causing the problem, as when the lower two fields are disabled/hidden, the validators are not removed from _english_Validators.
It appears that the problem may be related to "TRINIDAD-96 - Validators should be added incrementally, not set as a whole". The problem is not present in Trinidad 1.2.2,
but does appear in 1.2.3 and 1.2.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-880) Clientside validation errors when
using PPR
Posted by "Gerhard Petracek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564344#action_12564344 ]
Gerhard Petracek commented on TRINIDAD-880:
-------------------------------------------
hello graeme,
i tried your sample app. with trinidad 1.2.5.
TRINIDAD-842 solves point 9 of your description.
-> please remove point 9
> Clientside validation errors when using PPR
> -------------------------------------------
>
> Key: TRINIDAD-880
> URL: https://issues.apache.org/jira/browse/TRINIDAD-880
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.3-core, 1.2.4-core, 1.2.5-core
> Environment: Windows XP Pro SP2, Facelets 1.1.13, Sun Java System Application Server 9.1, JSF1.2_07-b03
> Reporter: Graeme Steyn
> Attachments: TRINIDAD880.zip
>
>
> To reproduce the problem deploy the attached sample application and execute the following sequence of actions.
> 1. All radio buttons should be blank when form is first displayed - press "Submit" - validation error occurs for first question (expected).
> 2. Select "Yes" for "Is English your first language?" - press "Submit" - validation error is cleared and form re-displayed.
> 3. Select "No" for "Is English your first language?" - press "Submit" - validation error occurs for second question (expected).
> 4. Select "Yes" for "Is English your first language?" - ppr results in second question being disabled, not required and clears validation message.
> 5. Press "Submit" - validation error occurs for second question (fault).
> 6. Select "No" for "Is English your first language?"
> 7. Select "Yes" for second question. Notice that a new required field appears.
> 8. Press "Submit" - validation error occurs for the new field (expected).
> 8. Select "No" for second question. The additional required field disappears.
> 9. Press "Submit" - Error appears: "Field Error [certDetails] - Enter a value" (fault).
> 10. Acknowledge and select "Yes" for "Is English your first language?" - press "Submit" - 2 validation error messages occur (fault).
> Using Firebug, it appears that the ppr is taking place correctly, but checking the DOM for _english_Validators shows that all three validators are eventually listed.
> I am assuming that this is what is causing the problem, as when the lower two fields are disabled/hidden, the validators are not removed from _english_Validators.
> It appears that the problem may be related to "TRINIDAD-96 - Validators should be added incrementally, not set as a whole". The problem is not present in Trinidad 1.2.2,
> but does appear in 1.2.3 and 1.2.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-880) Clientside validation errors when
using PPR
Posted by "Gerhard Petracek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564770#action_12564770 ]
Gerhard Petracek commented on TRINIDAD-880:
-------------------------------------------
hello graeme,
thank you for updating the information!
the open issue (short description):
there is a ppr validation issue if the value of a required attribute changed in the meantime (e.g. false -> true -> false).
workaround (in your case):
in my opinion it doesn't make sense to display a disabled input component which doesn't provide information (a "default value")
-> use the rendered attribute instead of disabling the component.
(+ partialTriggers at a component above (e.g. at the parent) - you already implemented a valid constellation)
regards,
gerhard
> Clientside validation errors when using PPR
> -------------------------------------------
>
> Key: TRINIDAD-880
> URL: https://issues.apache.org/jira/browse/TRINIDAD-880
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.3-core, 1.2.4-core, 1.2.5-core
> Environment: Windows XP Pro SP2, Facelets 1.1.13, Sun Java System Application Server 9.1, JSF1.2_07-b03
> Reporter: Graeme Steyn
> Attachments: TRINIDAD880.zip
>
>
> To reproduce the problem change the POM for the attached sample application to use Trinidad 1.2.5, build, deploy and execute the following sequence of actions.
> 1. All radio buttons should be blank when form is first displayed - press "Submit" - validation error occurs for first question (expected).
> 2. Select "Yes" for "Is English your first language?" - press "Submit" - validation error is cleared and form re-displayed.
> 3. Select "No" for "Is English your first language?" - press "Submit" - validation error occurs for second question (expected).
> 4. Select "Yes" for "Is English your first language?" - ppr results in second question being disabled, not required and clears validation message.
> 5. Press "Submit" - validation error occurs for second question (fault).
> 6. Select "No" for "Is English your first language?"
> 7. Select "Yes" for second question. Notice that a new required field appears.
> 8. Press "Submit" - validation error occurs for the new field (expected).
> 8. Select "No" for second question. The additional required field disappears.
> 9. Press "Submit" - Works as expected due to TRINIDAD-842 fix (Used to produce an error for core-1.2.3 and 1.2.4).
> 10. Select "Yes" for "Is English your first language?" - press "Submit" - validation error messages occurs for 2nd question (fault).
> Using Firebug, it appears that the ppr is taking place correctly, but checking the DOM for _english_Validators shows that all three validators are eventually listed.
> I am assuming that this is what is causing the problem, as when the lower two fields are disabled/hidden, the validators are not removed from _english_Validators.
> It appears that the problem may be related to "TRINIDAD-96 - Validators should be added incrementally, not set as a whole". The problem is not present in Trinidad 1.2.2,
> but does appear in 1.2.3, 1.2.4 and 1.2.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-880) Clientside validation errors when
using PPR
Posted by "Graeme Steyn (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565279#action_12565279 ]
Graeme Steyn commented on TRINIDAD-880:
---------------------------------------
Hi Gerhard,
Thank you for the advice. I have implemented the suggested change and it provides a far more elegant solution.
Thank you.
Graeme.
> Clientside validation errors when using PPR
> -------------------------------------------
>
> Key: TRINIDAD-880
> URL: https://issues.apache.org/jira/browse/TRINIDAD-880
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.3-core, 1.2.4-core, 1.2.5-core
> Environment: Windows XP Pro SP2, Facelets 1.1.13, Sun Java System Application Server 9.1, JSF1.2_07-b03
> Reporter: Graeme Steyn
> Attachments: TRINIDAD880.zip
>
>
> To reproduce the problem change the POM for the attached sample application to use Trinidad 1.2.5, build, deploy and execute the following sequence of actions.
> 1. All radio buttons should be blank when form is first displayed - press "Submit" - validation error occurs for first question (expected).
> 2. Select "Yes" for "Is English your first language?" - press "Submit" - validation error is cleared and form re-displayed.
> 3. Select "No" for "Is English your first language?" - press "Submit" - validation error occurs for second question (expected).
> 4. Select "Yes" for "Is English your first language?" - ppr results in second question being disabled, not required and clears validation message.
> 5. Press "Submit" - validation error occurs for second question (fault).
> 6. Select "No" for "Is English your first language?"
> 7. Select "Yes" for second question. Notice that a new required field appears.
> 8. Press "Submit" - validation error occurs for the new field (expected).
> 8. Select "No" for second question. The additional required field disappears.
> 9. Press "Submit" - Works as expected due to TRINIDAD-842 fix (Used to produce an error for core-1.2.3 and 1.2.4).
> 10. Select "Yes" for "Is English your first language?" - press "Submit" - validation error messages occurs for 2nd question (fault).
> Using Firebug, it appears that the ppr is taking place correctly, but checking the DOM for _english_Validators shows that all three validators are eventually listed.
> I am assuming that this is what is causing the problem, as when the lower two fields are disabled/hidden, the validators are not removed from _english_Validators.
> It appears that the problem may be related to "TRINIDAD-96 - Validators should be added incrementally, not set as a whole". The problem is not present in Trinidad 1.2.2,
> but does appear in 1.2.3, 1.2.4 and 1.2.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (TRINIDAD-880) Clientside validation errors when
using PPR
Posted by "Graeme Steyn (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Graeme Steyn reopened TRINIDAD-880:
-----------------------------------
Please refer to the previous comment. The fix does not work for the sample in Trinidad 1.2.5.
> Clientside validation errors when using PPR
> -------------------------------------------
>
> Key: TRINIDAD-880
> URL: https://issues.apache.org/jira/browse/TRINIDAD-880
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.3-core, 1.2.4-core, 1.2.5-core
> Environment: Windows XP Pro SP2, Facelets 1.1.13, Sun Java System Application Server 9.1, JSF1.2_07-b03
> Reporter: Graeme Steyn
> Attachments: TRINIDAD880.zip
>
>
> To reproduce the problem deploy the attached sample application and execute the following sequence of actions.
> 1. All radio buttons should be blank when form is first displayed - press "Submit" - validation error occurs for first question (expected).
> 2. Select "Yes" for "Is English your first language?" - press "Submit" - validation error is cleared and form re-displayed.
> 3. Select "No" for "Is English your first language?" - press "Submit" - validation error occurs for second question (expected).
> 4. Select "Yes" for "Is English your first language?" - ppr results in second question being disabled, not required and clears validation message.
> 5. Press "Submit" - validation error occurs for second question (fault).
> 6. Select "No" for "Is English your first language?"
> 7. Select "Yes" for second question. Notice that a new required field appears.
> 8. Press "Submit" - validation error occurs for the new field (expected).
> 8. Select "No" for second question. The additional required field disappears.
> 9. Press "Submit" - Error appears: "Field Error [certDetails] - Enter a value" (fault).
> 10. Acknowledge and select "Yes" for "Is English your first language?" - press "Submit" - 2 validation error messages occur (fault).
> Using Firebug, it appears that the ppr is taking place correctly, but checking the DOM for _english_Validators shows that all three validators are eventually listed.
> I am assuming that this is what is causing the problem, as when the lower two fields are disabled/hidden, the validators are not removed from _english_Validators.
> It appears that the problem may be related to "TRINIDAD-96 - Validators should be added incrementally, not set as a whole". The problem is not present in Trinidad 1.2.2,
> but does appear in 1.2.3 and 1.2.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.