You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/11/09 20:49:12 UTC
[GitHub] [iceberg] djsstarburst opened a new pull request #1745: Update Presto documentation link
djsstarburst opened a new pull request #1745:
URL: https://github.com/apache/iceberg/pull/1745
Current and relatively complete documentation for the Iceberg Presto
connector was added to Presto in July. This PR removes the pointer
to the obsolete Presto README.md file, and changes the link to point
to the Iceberg Presto connector documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] electrum commented on a change in pull request #1745: Update Presto documentation link
Posted by GitBox <gi...@apache.org>.
electrum commented on a change in pull request #1745:
URL: https://github.com/apache/iceberg/pull/1745#discussion_r520128646
##########
File path: site/docs/presto.md
##########
@@ -17,4 +17,4 @@
# Presto
-Iceberg connector is part of Presto SQL's master branch, although support for many features is still under development. Current status of the connector is detailed in the [presto-iceberg README](https://github.com/prestosql/presto/blob/master/presto-iceberg/README.md).
+Iceberg connector is part of Presto SQL's master branch, and feature development is complete. Connector documentation can be found in [Presto Iceberg Connector](https://github.com/prestosql/presto/blob/master/presto-docs/src/main/sphinx/connector/iceberg.rst).
Review comment:
We should link to the published documentation and not the source code: https://prestosql.io/docs/current/connector/iceberg.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1745: Update Presto documentation link
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1745:
URL: https://github.com/apache/iceberg/pull/1745
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] djsstarburst commented on a change in pull request #1745: Update Presto documentation link
Posted by GitBox <gi...@apache.org>.
djsstarburst commented on a change in pull request #1745:
URL: https://github.com/apache/iceberg/pull/1745#discussion_r520130501
##########
File path: site/docs/presto.md
##########
@@ -17,4 +17,4 @@
# Presto
-Iceberg connector is part of Presto SQL's master branch, although support for many features is still under development. Current status of the connector is detailed in the [presto-iceberg README](https://github.com/prestosql/presto/blob/master/presto-iceberg/README.md).
+Iceberg connector is part of Presto SQL's master branch, and feature development is complete. Connector documentation can be found in [Presto Iceberg Connector](https://github.com/prestosql/presto/blob/master/presto-docs/src/main/sphinx/connector/iceberg.rst).
Review comment:
Good point; changed and force-pushed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] mosabua commented on a change in pull request #1745: Update Presto documentation link
Posted by GitBox <gi...@apache.org>.
mosabua commented on a change in pull request #1745:
URL: https://github.com/apache/iceberg/pull/1745#discussion_r520161359
##########
File path: site/docs/presto.md
##########
@@ -17,4 +17,4 @@
# Presto
-Iceberg connector is part of Presto SQL's master branch, although support for many features is still under development. Current status of the connector is detailed in the [presto-iceberg README](https://github.com/prestosql/presto/blob/master/presto-iceberg/README.md).
+Iceberg connector is part of Presto SQL's master branch, and feature development is complete. Connector documentation can be found in [Presto Iceberg Connector](https://prestosql.io/docs/current/connector/iceberg.html).
Review comment:
How about rewording it a bit to something like this:
```
The Iceberg connector is available with Presto SQL. It is feature complete and usage details can be found in the [documentation](https://prestosql.io/docs/current/connector/iceberg.html).
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] mosabua commented on a change in pull request #1745: Update Presto documentation link
Posted by GitBox <gi...@apache.org>.
mosabua commented on a change in pull request #1745:
URL: https://github.com/apache/iceberg/pull/1745#discussion_r520161359
##########
File path: site/docs/presto.md
##########
@@ -17,4 +17,4 @@
# Presto
-Iceberg connector is part of Presto SQL's master branch, although support for many features is still under development. Current status of the connector is detailed in the [presto-iceberg README](https://github.com/prestosql/presto/blob/master/presto-iceberg/README.md).
+Iceberg connector is part of Presto SQL's master branch, and feature development is complete. Connector documentation can be found in [Presto Iceberg Connector](https://prestosql.io/docs/current/connector/iceberg.html).
Review comment:
How about rewording it a bit to something like this:
```
The Iceberg connector is available with Presto SQL. It is feature complete, and usage details can be found in the [documentation](https://prestosql.io/docs/current/connector/iceberg.html).
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] electrum commented on pull request #1745: Update Presto documentation link
Posted by GitBox <gi...@apache.org>.
electrum commented on pull request #1745:
URL: https://github.com/apache/iceberg/pull/1745#issuecomment-724454774
@rdblue good idea. I agree it’s better to just link to the Presto documentation, since it’s complete and always up to date.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1745: Update Presto documentation link
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1745:
URL: https://github.com/apache/iceberg/pull/1745#issuecomment-724348545
Thanks, @djsstarburst! Great to have this updated.
Are there any plans to add documentation for Presto to this page? If not, then we might reformat this to just link from the top bar rather than having a page with the link.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] djsstarburst commented on a change in pull request #1745: Update Presto documentation link
Posted by GitBox <gi...@apache.org>.
djsstarburst commented on a change in pull request #1745:
URL: https://github.com/apache/iceberg/pull/1745#discussion_r520175544
##########
File path: site/docs/presto.md
##########
@@ -17,4 +17,4 @@
# Presto
-Iceberg connector is part of Presto SQL's master branch, although support for many features is still under development. Current status of the connector is detailed in the [presto-iceberg README](https://github.com/prestosql/presto/blob/master/presto-iceberg/README.md).
+Iceberg connector is part of Presto SQL's master branch, and feature development is complete. Connector documentation can be found in [Presto Iceberg Connector](https://prestosql.io/docs/current/connector/iceberg.html).
Review comment:
Indeed that's better; updated and force-pushed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org