You are viewing a plain text version of this content. The canonical link for it is here.

Posted to mapreduce-issues@hadoop.apache.org by "Devaraj K (JIRA)" <ji...@apache.org> on 2011/07/12 20:37:59 UTC

[jira] [Commented] (MAPREDUCE-2661) MR-279: Accessing MapTaskImpl from TaskImpl

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064062#comment-13064062 ] 

Devaraj K commented on MAPREDUCE-2661:
--------------------------------------

I feel it is not correct to give the getSplitsAsString() implementation details of MapTaskImpl.java and ReduceTaskImpl.java  in TaskImpl.java.

TaskImpl.java can provide default implementation of getSplitsAsString() instead of making it as abstract and returning with empty string in ReduceTaskImpl.java.


> MR-279: Accessing MapTaskImpl from TaskImpl
> -------------------------------------------
>
>                 Key: MAPREDUCE-2661
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2661.patch, MAPREDUCE-2661_rev2.patch
>
>
> We are directly accessing MapTaskImpl in TaskImpl.InitialScheduleTransition.transition(..). It'll be better to reorganize the code so each subclass can provide its own behavior instead of explicitly checking for the subclass type. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira