You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/27 01:57:33 UTC

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6750: [AutoScheduler] New layout rewrite option: Weight pre-transpose

merrymercy commented on a change in pull request #6750:
URL: https://github.com/apache/incubator-tvm/pull/6750#discussion_r512368268



##########
File path: python/tvm/auto_scheduler/compute_dag.py
##########
@@ -50,6 +50,11 @@ class ComputeDAG(Object):
     compute : Union[List[Tensor], str, Schedule]
         Input/output tensors or workload key for a compute declaration.
     """
+    LAYOUT_REWRITE_TABLE = {
+        "NoRewrite": 0,
+        "RewriteWithPlaceholder": 1,
+        "RewriteWithPreTranspose": 2,
+    }

Review comment:
       Why do we use strings? Can we just use variables like this?
   https://github.com/apache/incubator-tvm/blob/8d56164107ac2be9f2f53f13de202a7bbf1c1c66/python/tvm/auto_scheduler/measure.py#L464-L472




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org