You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@paimon.apache.org by lz...@apache.org on 2024/04/02 09:00:55 UTC
(paimon) branch master updated: [core] Fix failed tests in FileStoreCommitTest (#3145)
This is an automated email from the ASF dual-hosted git repository.
lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/paimon.git
The following commit(s) were added to refs/heads/master by this push:
new 945f22900 [core] Fix failed tests in FileStoreCommitTest (#3145)
945f22900 is described below
commit 945f22900cf15979b7c8719e4fc2657b7ea0ee77
Author: tsreaper <ts...@gmail.com>
AuthorDate: Tue Apr 2 17:00:50 2024 +0800
[core] Fix failed tests in FileStoreCommitTest (#3145)
---
.../main/java/org/apache/paimon/operation/FileStoreCommitImpl.java | 2 +-
.../test/java/org/apache/paimon/operation/FileStoreCommitTest.java | 5 -----
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java b/paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
index 19819357c..83508adf0 100644
--- a/paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
+++ b/paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
@@ -94,7 +94,7 @@ import static org.apache.paimon.utils.BranchManager.DEFAULT_MAIN_BRANCH;
*
* <p>NOTE: If you want to modify this class, any exception during commit MUST NOT BE IGNORED. They
* must be thrown to restart the job. It is recommended to run FileStoreCommitTest thousands of
- * times to make sure that your changes is correct.
+ * times to make sure that your changes are correct.
*/
public class FileStoreCommitImpl implements FileStoreCommit {
diff --git a/paimon-core/src/test/java/org/apache/paimon/operation/FileStoreCommitTest.java b/paimon-core/src/test/java/org/apache/paimon/operation/FileStoreCommitTest.java
index 4524aba51..26cb564ca 100644
--- a/paimon-core/src/test/java/org/apache/paimon/operation/FileStoreCommitTest.java
+++ b/paimon-core/src/test/java/org/apache/paimon/operation/FileStoreCommitTest.java
@@ -559,11 +559,6 @@ public class FileStoreCommitTest {
.isInstanceOf(RuntimeException.class)
.hasMessageContaining("Give up committing.");
}
-
- // commit without check, should pass
- for (int i = 0; i < 3; i++) {
- store.newCommit().commit(committables.get(0), Collections.emptyMap());
- }
}
@Test