You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/15 02:35:59 UTC
[GitHub] [pulsar] AnonHxy opened a new pull request, #15604: [broker]Tidy dispatchRateLimiter init
AnonHxy opened a new pull request, #15604:
URL: https://github.com/apache/pulsar/pull/15604
### Motivation
Tidy up the code updating rate limiter to make it more clear.
### Modifications
* Pick `updateSubscribeRateLimiter()` out of `initializeRateLimiterIfNeeded` to make the code more clear.
### Verifying this change.
* Also rename `initializeRateLimiterIfNeeded` to `initializeDispatchRateLimiterIfNeeded`
- [x] Make sure that the change passes the CI checks.
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #15604: [broker]Tidy dispatchRateLimiter init
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15604:
URL: https://github.com/apache/pulsar/pull/15604#issuecomment-1127256575
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #15604: [cleanup][broker]Tidy dispatchRateLimiter init
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #15604:
URL: https://github.com/apache/pulsar/pull/15604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15604: [cleanup][broker]Tidy dispatchRateLimiter init
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #15604:
URL: https://github.com/apache/pulsar/pull/15604#discussion_r875410081
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -321,15 +321,18 @@ public CompletableFuture<Void> initialize() {
isEncryptionRequired = false;
updatePublishDispatcher();
updateResourceGroupLimiter(optPolicies);
- initializeRateLimiterIfNeeded();
+ initializeDispatchRateLimiterIfNeeded();
+ updateSubscribeRateLimiter();
Review Comment:
Before this, we forget to update `updateSubscribeRateLimiter` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on a diff in pull request #15604: [cleanup][broker]Tidy dispatchRateLimiter init
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on code in PR #15604:
URL: https://github.com/apache/pulsar/pull/15604#discussion_r875412785
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -321,15 +321,18 @@ public CompletableFuture<Void> initialize() {
isEncryptionRequired = false;
updatePublishDispatcher();
updateResourceGroupLimiter(optPolicies);
- initializeRateLimiterIfNeeded();
+ initializeDispatchRateLimiterIfNeeded();
+ updateSubscribeRateLimiter();
Review Comment:
No, before this, the `updateSubscribeRateLimiter ` is inside the `initializeDispatchRateLimiterIfNeeded `
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -321,15 +321,18 @@ public CompletableFuture<Void> initialize() {
isEncryptionRequired = false;
updatePublishDispatcher();
updateResourceGroupLimiter(optPolicies);
- initializeRateLimiterIfNeeded();
+ initializeDispatchRateLimiterIfNeeded();
+ updateSubscribeRateLimiter();
Review Comment:
No, before this, the `updateSubscribeRateLimiter ` is inside the `initializeDispatchRateLimiterIfNeeded ` @Technoboy-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #15604: [broker]Tidy dispatchRateLimiter init
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15604:
URL: https://github.com/apache/pulsar/pull/15604#issuecomment-1126883347
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15604: [cleanup][broker]Tidy dispatchRateLimiter init
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #15604:
URL: https://github.com/apache/pulsar/pull/15604#discussion_r875420272
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -321,15 +321,18 @@ public CompletableFuture<Void> initialize() {
isEncryptionRequired = false;
updatePublishDispatcher();
updateResourceGroupLimiter(optPolicies);
- initializeRateLimiterIfNeeded();
+ initializeDispatchRateLimiterIfNeeded();
+ updateSubscribeRateLimiter();
Review Comment:
ah. ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #15604: [broker]Tidy dispatchRateLimiter init
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15604:
URL: https://github.com/apache/pulsar/pull/15604#issuecomment-1127532134
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #15604: [broker]Tidy dispatchRateLimiter init
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15604:
URL: https://github.com/apache/pulsar/pull/15604#issuecomment-1127314075
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #15604: [broker]Tidy dispatchRateLimiter init
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15604:
URL: https://github.com/apache/pulsar/pull/15604#issuecomment-1126897987
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #15604: [broker]Tidy dispatchRateLimiter init
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15604:
URL: https://github.com/apache/pulsar/pull/15604#issuecomment-1127761728
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #15604: [broker]Tidy dispatchRateLimiter init
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15604:
URL: https://github.com/apache/pulsar/pull/15604#issuecomment-1127536514
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #15604: [broker]Tidy dispatchRateLimiter init
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15604:
URL: https://github.com/apache/pulsar/pull/15604#issuecomment-1127161108
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #15604: [broker]Tidy dispatchRateLimiter init
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15604:
URL: https://github.com/apache/pulsar/pull/15604#issuecomment-1128497463
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #15604: [broker]Tidy dispatchRateLimiter init
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15604:
URL: https://github.com/apache/pulsar/pull/15604#issuecomment-1127664280
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #15604: [broker]Tidy dispatchRateLimiter init
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15604:
URL: https://github.com/apache/pulsar/pull/15604#issuecomment-1127971822
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org