You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2018/07/05 01:56:56 UTC
spark git commit: [SPARK-17213][SPARK-17213][FOLLOW-UP] Improve the
test of
Repository: spark
Updated Branches:
refs/heads/master bf764a33b -> 489a5294d
[SPARK-17213][SPARK-17213][FOLLOW-UP] Improve the test of
## What changes were proposed in this pull request?
This is a minor improvement for the test of SPARK-17213
## How was this patch tested?
N/A
Author: Xiao Li <ga...@gmail.com>
Closes #21716 from gatorsmile/testMaster23.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/489a5294
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/489a5294
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/489a5294
Branch: refs/heads/master
Commit: 489a5294d106130beda1509e3cbbaf707a3d703d
Parents: bf764a3
Author: Xiao Li <ga...@gmail.com>
Authored: Thu Jul 5 09:56:48 2018 +0800
Committer: hyukjinkwon <gu...@apache.org>
Committed: Thu Jul 5 09:56:48 2018 +0800
----------------------------------------------------------------------
.../parquet/ParquetFilterSuite.scala | 28 +++++++++++---------
1 file changed, 16 insertions(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/489a5294/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
index 8b96c84..f2c0bda 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
@@ -618,21 +618,25 @@ class ParquetFilterSuite extends QueryTest with ParquetTest with SharedSQLContex
}
test("SPARK-17213: Broken Parquet filter push-down for string columns") {
- withTempPath { dir =>
- import testImplicits._
+ Seq(true, false).foreach { vectorizedEnabled =>
+ withSQLConf(SQLConf.PARQUET_VECTORIZED_READER_ENABLED.key -> vectorizedEnabled.toString) {
+ withTempPath { dir =>
+ import testImplicits._
- val path = dir.getCanonicalPath
- // scalastyle:off nonascii
- Seq("a", "é").toDF("name").write.parquet(path)
- // scalastyle:on nonascii
+ val path = dir.getCanonicalPath
+ // scalastyle:off nonascii
+ Seq("a", "é").toDF("name").write.parquet(path)
+ // scalastyle:on nonascii
- assert(spark.read.parquet(path).where("name > 'a'").count() == 1)
- assert(spark.read.parquet(path).where("name >= 'a'").count() == 2)
+ assert(spark.read.parquet(path).where("name > 'a'").count() == 1)
+ assert(spark.read.parquet(path).where("name >= 'a'").count() == 2)
- // scalastyle:off nonascii
- assert(spark.read.parquet(path).where("name < 'é'").count() == 1)
- assert(spark.read.parquet(path).where("name <= 'é'").count() == 2)
- // scalastyle:on nonascii
+ // scalastyle:off nonascii
+ assert(spark.read.parquet(path).where("name < 'é'").count() == 1)
+ assert(spark.read.parquet(path).where("name <= 'é'").count() == 2)
+ // scalastyle:on nonascii
+ }
+ }
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org