You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by rachel-carvalho <gi...@git.apache.org> on 2015/04/13 20:37:54 UTC
[GitHub] cordova-lib pull request: Orientation preference now updates value...
GitHub user rachel-carvalho opened a pull request:
https://github.com/apache/cordova-lib/pull/207
Orientation preference now updates value for iPad
As dicussed in #128 (more specifically https://github.com/apache/cordova-lib/pull/128#issuecomment-89316079), currently setting this:
```xml
<preference name="Orientation" value="landscape"/>
```
doesn't affect the iPad.
So I added code and specs for updating `UISupportedInterfaceOrientations~ipad`, as well as `UISupportedInterfaceOrientations`.
This is my first time contributing to Cordova, sorry if something is missing! All input is welcome :)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rachel-carvalho/cordova-lib pref-orientation-ipad
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/207.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #207
----
commit 6f0b9a4c1433c745218c529d6d2deedce5624925
Author: Rachel Carvalho <ra...@gmail.com>
Date: 2015-04-13T18:27:15Z
Orientation preference now updates `UISupportedInterfaceOrientations~ipad` too
(as discussed in Github #128)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Orientation preference now updates value...
Posted by mmrko <gi...@git.apache.org>.
Github user mmrko commented on the pull request:
https://github.com/apache/cordova-lib/pull/207#issuecomment-93660630
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Orientation preference now updates value...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/207#issuecomment-100025000
Hi Rachel - can you update the title with a prefix of CB-6462 CB-6026 (to enable some auto-tracking with JIRA)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6462 CB-6026 Orientation preference n...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/207#issuecomment-100069439
Integrated: https://git1-us-west.apache.org/repos/asf?p=cordova-lib.git;a=commit;h=93ab6b61
You can close this issue now, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6462 CB-6026 Orientation preference n...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/207#issuecomment-100042422
CB-8783 affects iPad as well, by inspecting the existing code (not yours).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6462 CB-6026 Orientation preference n...
Posted by christoph-neumann <gi...@git.apache.org>.
Github user christoph-neumann commented on the pull request:
https://github.com/apache/cordova-lib/pull/207#issuecomment-143042865
How are we supposed to set iPhone and iPad differently now? My app is portrait only for iPhones, but portrait and landscape for iPads. We need a way to have a different policy for iPhones and iPads.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6462 CB-6026 Orientation preference n...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/207#issuecomment-143048648
Hmm never did thought of that scenario. Not sure how we would tackle this -- I suggest filing a feature request at issues.cordova.io so we can discuss.
My suggestion is a separate one, something like "Orientation~ipad". If only "Orientation" is set, it sets it for both. If "Orientation~ipad" is set, it overrides the iPad setting that was set in "Orientation". We won't need one for "Orientation~iphone" I don't think but we might have to for completeness.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6462 CB-6026 Orientation preference n...
Posted by christoph-neumann <gi...@git.apache.org>.
Github user christoph-neumann commented on the pull request:
https://github.com/apache/cordova-lib/pull/207#issuecomment-143053886
@shazron Done. Thanks for looking into it! https://issues.apache.org/jira/browse/CB-9703
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6462 CB-6026 Orientation preference n...
Posted by rachel-carvalho <gi...@git.apache.org>.
Github user rachel-carvalho commented on the pull request:
https://github.com/apache/cordova-lib/pull/207#issuecomment-100033206
Done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6462 CB-6026 Orientation preference n...
Posted by rachel-carvalho <gi...@git.apache.org>.
Github user rachel-carvalho closed the pull request at:
https://github.com/apache/cordova-lib/pull/207
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org