You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2021/01/06 23:58:31 UTC
[GitHub] [ofbiz-framework] ieugen opened a new pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar
ieugen opened a new pull request #250:
URL: https://github.com/apache/ofbiz-framework/pull/250
* There is a bug in XML parsing within jar files (JarURLConnection)
* Setting setUseCaches(boolean) solves it
Fixed: OFBIZ-12118
Explanation: There is a bug when parsing xml inside a jar via URL.
https://issues.apache.org/jira/browse/OFBIZ-12118?focusedCommentId=17260119&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17260119
Thanks: Girish and Daniel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] danwatford commented on pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar
Posted by GitBox <gi...@apache.org>.
danwatford commented on pull request #250:
URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-758190643
Merged in commit c9ee8421639a9d9b623d012531d76eddce1dcb48
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] ieugen commented on pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar
Posted by GitBox <gi...@apache.org>.
ieugen commented on pull request #250:
URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-758067795
Thanks @danwatford .
How can we merge this PR in trunk?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] ieugen commented on pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar
Posted by GitBox <gi...@apache.org>.
ieugen commented on pull request #250:
URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-758204999
It's such a pain with merging these.
I am an Apache committer and if the tests passed, and all you should have been able to just merge the PR instead of having to do the commit again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] danwatford commented on pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar
Posted by GitBox <gi...@apache.org>.
danwatford commented on pull request #250:
URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-758538114
Hi @ieugen ,
It was my first commit so I was very keen to ensure I followed ofbiz conventions.
However there are examples in the git log of merge commits being used rather than committers applying patches. The good thing about merge commits is that the original author is shown in the log and systems like GitHub profiles can better represent individual developers' activities.
In this case I wanted to add an extra comment about why we needed to disable caching in URLConnections, but perhaps better would have been to ask you to commit the comment and squash your commits accordingly.
I'm happy to revisit and alter my committer workflow in line with community guidelines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] danwatford commented on pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar
Posted by GitBox <gi...@apache.org>.
danwatford commented on pull request #250:
URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-757871611
Hi @ieugen ,
I tried running the integration steps again today, this time carefully double checking and recording my steps and am happy to report that integration tests are running.
For completeness I include my steps to run the integration tests against trunk and against the PR below:
```
$ git checkout trunk
$ git pull
$ ./gradlew cleanAll
# Merge tools to build docker containers
$ git merge --no-commit --squash docker-from-gradle
$ ./gradlew buildOfbizBaseDockerImage
$ ./gradlew buildOfbizDockerImage
# Run integration tests against trunk. Bind mount the logs folder for test results.
$ docker run -it --rm --mount type=bind,source=$PWD/runtime/logs,destination=/ofbiz/runtime/logs ofbiz:latest "ofbiz --test"
# Fetch and merge the PR, autostashing the docker-from-gradle changes.
$ git fetch origin pull/250/head:pr250
$ git merge --no-commit --squash --autostash pr250
# Rebuild the docker images with the PR included.
$ ./gradlew buildOfbizDockerImage
# Run the integration tests against the PR
$ docker run -it --rm --mount type=bind,source=$PWD/runtime/logs,destination=/ofbiz/runtime/logs ofbiz:latest "ofbiz --test"
```
The docker-from-gradle branch is available here (https://github.com/danwatford/ofbiz-framework/tree/docker-from-gradle) and includes gradle tasks to build docker images as discussed in this thread (https://lists.apache.org/thread.html/r40fd679818a37e113b469add51755b1097a2b02d3961e71a2cfe928d%40%3Cdev.ofbiz.apache.org%3E)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] danwatford closed pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar
Posted by GitBox <gi...@apache.org>.
danwatford closed pull request #250:
URL: https://github.com/apache/ofbiz-framework/pull/250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #250:
URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-755787484
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=250&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=250&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=250&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=250&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=250&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=250&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=250&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=250&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=250&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=250&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=250&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=250&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=250) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=250&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=250&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] danwatford commented on pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar
Posted by GitBox <gi...@apache.org>.
danwatford commented on pull request #250:
URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-757397683
Hi @ieugen,
I'm getting some integration test failures with the caching change.
Please could you double check by running:
`./gradlew "ofbiz --test"`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] danwatford commented on pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar
Posted by GitBox <gi...@apache.org>.
danwatford commented on pull request #250:
URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-757397683
Hi @ieugen,
I'm getting some integration test failures with the caching change.
Please could you double check by running:
`./gradlew "ofbiz --test"`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] ieugen commented on pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar
Posted by GitBox <gi...@apache.org>.
ieugen commented on pull request #250:
URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-757729683
Thanks @danwatford ,
It passes on my system.
I'll probably run the tests inside the container.
```
> Task :createTestReports
Trying to override old definition of datatype junitreport
BUILD SUCCESSFUL in 4m 6s
5 actionable tasks: 2 executed, 3 up-to-date
```
Can you try other JVM version ?
I'm using adoptopenjdk via sdkman.io .
```
java -version
openjdk version "1.8.0_275"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_275-b01)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.275-b01, mixed mode)
```
I've pushed ofbiz images on Docker hub for amd64 and arm64 (Raspberry PI ).
I've started the arm64 on raspberry pi and it works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] ieugen commented on pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar
Posted by GitBox <gi...@apache.org>.
ieugen commented on pull request #250:
URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-758591931
Thanks, I'm happy that my change got accepted.
Let's see what we can do for the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org