You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/25 12:36:17 UTC

[GitHub] [pulsar] 315157973 opened a new pull request #7661: fix batchReceiveAsync not completed exceptionally when closing Consumer

315157973 opened a new pull request #7661:
URL: https://github.com/apache/pulsar/pull/7661


   
   
   
   Fixes #7580
   
   
   ### Motivation
   CompletableFuture<Messages<T>> from Consumer.batchReceiveAsync() not completed exceptionnally when closing Consumer.
   
   ### Modifications
   pendingBatchReceives was not cleaned up when the connection was closed, so I added pendingBatchReceives cleanup.
   
   ### Verifying this change
   unit test:
   org.apache.pulsar.client.api.SimpleProducerConsumerTest#testReceiveAsyncCompletedWhenClosing
   
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy merged pull request #7661: fix batchReceiveAsync not completed exceptionally when closing Consumer

Posted by GitBox <gi...@apache.org>.

wolfstudy merged pull request #7661:
URL: https://github.com/apache/pulsar/pull/7661


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org