[jira] [Commented] (FLINK-5748) Make the ExecutionGraph's FutureExecutor a ScheduledExecutionService

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859427#comment-15859427 ] 

ASF GitHub Bot commented on FLINK-5748:
---------------------------------------

GitHub user StephanEwen opened a pull request:

    https://github.com/apache/flink/pull/3289

    [FLINK-5748] [jobmanager] Make the 'future executor' a ScheduledExecutorService

    This pull request changes the JobManager's Executor for Futures and Callbacks to be a `ScheduledExecutorService`. That is needed for more efficient handling of scheduled actions, like delayed restarts, timeouts, etc.
    
    The main changes in this pull request are
    
      1. Adjusting the setup logic of the JobManager (and it derived classes for Yarn / Mesos / ...) to use a ScheduledExecutorService
      
      2. Adjusting all the tests that manually create a JobManager to create a `ScheduledExecutor` instead
         of an `Executor`. There are a lot of tests that needed to be touched...
     
    ### Tests
    
    There are some tests that relied on that fact that the future executor is a *direct executor* that synchronously invokes the `Runnable`. This PR hence adds a `ScheduledDirectExecutorService` that executes immediately executable tasks synchronously, but supports scheduling of tasks as well (which will naturally not be executed synchronously).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink scheduled_future_executor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3289
    
----
commit bb05c5cd633a5e978defdd70a43090ba60624e02
Author: Stephan Ewen <se...@apache.org>
Date:   2017-02-08T19:51:46Z

    [FLINK-5748] [jobmanager] Make the 'future executor' a ScheduledExecutorService

----


> Make the ExecutionGraph's FutureExecutor a ScheduledExecutionService
> --------------------------------------------------------------------
>
>                 Key: FLINK-5748
>                 URL: https://issues.apache.org/jira/browse/FLINK-5748
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>             Fix For: 1.3.0
>
>
> To handle timeouts and other scheduled actions more efficiently, the {{ExecutionGraph}} should use a {{ScheduledExecutorService}} for its futures and callbacks.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)