[jira] [Resolved] (MATH-1353) "EmpiricalDistribution" has various shortcomings

["Gilles Sadowski (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MATH-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gilles Sadowski resolved MATH-1353.
-----------------------------------
    Resolution: Won't Do

Note that the issues mentioned in this report have been fixed as part of MATH-1616; they are marked with (/) in the description; suggested new functionality, that was not implemented, is marked with (x).


> "EmpiricalDistribution" has various shortcomings
> ------------------------------------------------
>
>                 Key: MATH-1353
>                 URL: https://issues.apache.org/jira/browse/MATH-1353
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Gilles Sadowski
>            Priority: Minor
>              Labels: refactoring
>             Fix For: 4.X
>
>
> (/) Class uses file IO (CM should not be concerned with data persistence)
> (/) Class uses the "java.net" API (ditto)
> (/) I'd think that the core functionality could be provided without supporting data loading (from a file or a URL).
> (x) Data input would be via any of
>  * Collection
>  * Iterable
>  * Stream (Java 8)
> (/) A redesign goal should be to make the class immutable.
> (/) E.g. data source must be set in the constructor (rather than via a "load" method); there would thus be a one-to-one correspondence between data source and distribution instance.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)