You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "wangxfholly (via GitHub)" <gi...@apache.org> on 2026/08/29 02:48:16 UTC

[PR] Fix incomplete metadata loading [shardingsphere]

wangxfholly opened a new pull request, #39629:
URL: https://github.com/apache/shardingsphere/pull/39629

   Fixes #ISSUSE_ID.
   
   Changes proposed in this pull request:
     -
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   - [ ] I have disclosed the tool and affected files or scope for any material AI assistance, as required by the [AI-assisted contribution policy].
   
   [AI-assisted contribution policy]: https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix incomplete metadata loading [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed pull request #39629: Fix incomplete metadata loading
URL: https://github.com/apache/shardingsphere/pull/39629


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix incomplete metadata loading [shardingsphere]

Posted by "wangxfholly (via GitHub)" <gi...@apache.org>.
wangxfholly commented on PR #39629:
URL: https://github.com/apache/shardingsphere/pull/39629#issuecomment-5459875873

   Title:
     Fix #39084: Fail fast on incomplete metadata loading
   
     Body:
     Fixes #39084
   
     Metadata loading now fails fast when expected table metadata is missing or incomplete.
   
     - Propagate dialect loader SQLExceptions instead of silently falling back.
     - Validate loaded tables with database-specific identifier semantics.
     - Fail when the default loader cannot find a table.
     - Cancel remaining tasks after a failure and preserve interruption status.
     - Add regression tests for missing metadata, exception propagation, cancellation, and interruption.
   
     Tests:
     - MetaDataLoaderTest
     - TableMetaDataLoaderTest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix incomplete metadata loading [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39629:
URL: https://github.com/apache/shardingsphere/pull/39629#issuecomment-5700523365

   Please resolve conflicts first


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix incomplete metadata loading [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39629:
URL: https://github.com/apache/shardingsphere/pull/39629#issuecomment-5990334745

   Thank you for your contribution. Since there has been no response or update following the review feedback and the request to resolve conflicts, I’m closing this PR for now.
   
   If you’d like to continue working on this, please address the outstanding feedback and resolve the conflicts, then request reopening or submit an updated PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org