You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "JWT007 (via GitHub)" <gi...@apache.org> on 2025/01/07 10:07:29 UTC

[I] LoggerConfig.RootLogger.Builder#withtFilter (typo in metthod name / only partially fixed) (logging-log4j2)

JWT007 opened a new issue, #3369:
URL: https://github.com/apache/logging-log4j2/issues/3369

   **Log4j 2.24**
   
   In LoggerConfig.Builder, an original typo existed in the '`withtFilter`' method (extra 't' in name).
   
   This was fixed by deprecating the original method and adding the correct 'withFilter' method.
   
   ```
           /**  @deprecated Use {@link #withFilter(Filter)} instead  */
           @Deprecated
           public B withtFilter(final Filter filter) { ... }
   
           public B withFilter(final Filter filter) { ... }
   ```
   
   However, it was not fixed in the nested `LoggerConfig.RootLogger.Builder` implementation - there the name is still incorrect.
   
   The nested builder method should also be deprecated and '`withFilter`' added to replace it with the correct name.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] LoggerConfig.RootLogger.Builder#withtFilter (typo in method name / only partially fixed) (logging-log4j2)

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on issue #3369:
URL: https://github.com/apache/logging-log4j2/issues/3369#issuecomment-2575653552

   @JWT007,
   
   Thanks! Do you mind making a PR with this change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] LoggerConfig.RootLogger.Builder#withtFilter (typo in method name / only partially fixed) (logging-log4j2)

Posted by "JWT007 (via GitHub)" <gi...@apache.org>.
JWT007 commented on issue #3369:
URL: https://github.com/apache/logging-log4j2/issues/3369#issuecomment-2651803537

   @ppkarwasz - it took me a while but I added tthe change log entry for 2.25.0
   
   I also fixed spotless problem and updated package versions for baseline


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] LoggerConfig.RootLogger.Builder#withtFilter (typo in method name / only partially fixed) [logging-log4j2]

Posted by "ramanathan1504 (via GitHub)" <gi...@apache.org>.
ramanathan1504 closed issue #3369: LoggerConfig.RootLogger.Builder#withtFilter (typo in method name / only partially fixed)
URL: https://github.com/apache/logging-log4j2/issues/3369


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] LoggerConfig.RootLogger.Builder#withtFilter (typo in method name / only partially fixed) (logging-log4j2)

Posted by "JWT007 (via GitHub)" <gi...@apache.org>.
JWT007 commented on issue #3369:
URL: https://github.com/apache/logging-log4j2/issues/3369#issuecomment-2576452763

   @ppkarwasz - made quick change - PR workflow awaiting approval:
   
   https://github.com/apache/logging-log4j2/pull/3372


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org