You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2015/10/22 09:24:01 UTC
[GitHub] spark pull request: [SPARK-11256] Mark all Stage/ResultStage/Shuff...
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/9219
[SPARK-11256] Mark all Stage/ResultStage/ShuffleMapStage internal state as private.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rxin/spark stage-cleanup1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9219.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9219
----
commit f9939cab7332a4818b0fd0c7b348e6aa368f890e
Author: Reynold Xin <rx...@databricks.com>
Date: 2015-10-22T07:21:05Z
More minor cleanup of Stage/ResultStage/ShuffleMapStage code.
All internal states are now marked as private, and need to go through accessor methods.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11256] Mark all Stage/ResultStage/Shuff...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9219#issuecomment-150159386
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11256] Mark all Stage/ResultStage/Shuff...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9219#issuecomment-150130688
cc @kayousterhout
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11256] Mark all Stage/ResultStage/Shuff...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9219#issuecomment-150130918
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11256] Mark all Stage/ResultStage/Shuff...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9219#issuecomment-150130962
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11256] Mark all Stage/ResultStage/Shuff...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9219#issuecomment-153382502
Going to merge this since this mostly just cleans up code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11256] Mark all Stage/ResultStage/Shuff...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9219#issuecomment-150159388
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44140/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11256] Mark all Stage/ResultStage/Shuff...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9219#issuecomment-150159239
**[Test build #44140 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44140/consoleFull)** for PR 9219 at commit [`f9939ca`](https://github.com/apache/spark/commit/f9939cab7332a4818b0fd0c7b348e6aa368f890e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11256] Mark all Stage/ResultStage/Shuff...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9219#issuecomment-150131640
**[Test build #44140 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44140/consoleFull)** for PR 9219 at commit [`f9939ca`](https://github.com/apache/spark/commit/f9939cab7332a4818b0fd0c7b348e6aa368f890e).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11256] Mark all Stage/ResultStage/Shuff...
Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/9219#discussion_r42764498
--- Diff: core/src/main/scala/org/apache/spark/scheduler/ShuffleMapStage.scala ---
@@ -43,35 +43,53 @@ private[spark] class ShuffleMapStage(
val shuffleDep: ShuffleDependency[_, _, _])
extends Stage(id, rdd, numTasks, parents, firstJobId, callSite) {
+ private[this] var _mapStageJobs: List[ActiveJob] = Nil
--- End diff --
This is if multiple threads submit the same stage with submitMapStage. You're not bypassing the DAGScheduler when you do adaptive execution, you're just telling it to run a map stage even if there's no result stage downstream. But it still does all its standard stuff to figure out previous stages to launch, track dependencies when recovering from failures, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11256] Mark all Stage/ResultStage/Shuff...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9219#discussion_r42717892
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
@@ -535,10 +535,8 @@ class DAGScheduler(
jobIdToActiveJob -= job.jobId
activeJobs -= job
job.finalStage match {
- case r: ResultStage =>
- r.resultOfJob = None
- case m: ShuffleMapStage =>
- m.mapStageJobs = m.mapStageJobs.filter(_ != job)
+ case r: ResultStage => r.removeActiveJob()
--- End diff --
one thing i'm thinking is whether we should move "removeActiveJob" and "addActiveJob" to Stage, and have both ResultStage and ShuffleMapStage implement those.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11256] Mark all Stage/ResultStage/Shuff...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9219
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11256] Mark all Stage/ResultStage/Shuff...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9219#discussion_r42717979
--- Diff: core/src/main/scala/org/apache/spark/scheduler/ShuffleMapStage.scala ---
@@ -43,35 +43,53 @@ private[spark] class ShuffleMapStage(
val shuffleDep: ShuffleDependency[_, _, _])
extends Stage(id, rdd, numTasks, parents, firstJobId, callSite) {
+ private[this] var _mapStageJobs: List[ActiveJob] = Nil
--- End diff --
cc @mateiz can you explain when we can have more than one active jobs for a stage? Does this only happen if we do adaptive query execution and bypass the existing DAGScheduler to run shuffle map stages?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org