You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ah...@apache.org on 2019/12/03 21:51:29 UTC
[royale-asjs] branch develop updated (602df8f -> 3403e32)
This is an automated email from the ASF dual-hosted git repository.
aharui pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git.
from 602df8f Merge branch 'develop' of https://github.com/apache/royale-asjs into develop
new d2fac6c this was already implemented in TextInput. It can't go here as TextArea does not use an HTMLInputElement
new 3403e32 off by one. Should fix #585
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../main/royale/mx/controls/beads/layouts/AdvancedDataGridLayout.as | 2 +-
.../main/royale/spark/components/supportClasses/SkinnableTextBase.as | 5 -----
2 files changed, 1 insertion(+), 6 deletions(-)
[royale-asjs] 01/02: this was already implemented in TextInput. It
can't go here as TextArea does not use an HTMLInputElement
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit d2fac6c507ecfada85be46749179459660a0d4fc
Author: Alex Harui <ah...@apache.org>
AuthorDate: Tue Dec 3 13:50:34 2019 -0800
this was already implemented in TextInput. It can't go here as TextArea does not use an HTMLInputElement
---
.../main/royale/spark/components/supportClasses/SkinnableTextBase.as | 5 -----
1 file changed, 5 deletions(-)
diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/SkinnableTextBase.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/SkinnableTextBase.as
index 5bb371b..8f6f098 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/SkinnableTextBase.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/SkinnableTextBase.as
@@ -1238,11 +1238,6 @@ public class SkinnableTextBase extends SkinnableComponent
return;
_maxChars = value;
- COMPILE::JS
- {
- (element as HTMLInputElement).maxLength = value;
- //dispatchEvent(new Event('htmlTextChanged'));
- }
}
//----------------------------------
[royale-asjs] 02/02: off by one. Should fix #585
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit 3403e3249e94cb76a2f892a8e1f5e0c55783c924
Author: Alex Harui <ah...@apache.org>
AuthorDate: Tue Dec 3 13:51:10 2019 -0800
off by one. Should fix #585
---
.../src/main/royale/mx/controls/beads/layouts/AdvancedDataGridLayout.as | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/beads/layouts/AdvancedDataGridLayout.as b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/beads/layouts/AdvancedDataGridLayout.as
index b7c309d..1e031e5 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/beads/layouts/AdvancedDataGridLayout.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/beads/layouts/AdvancedDataGridLayout.as
@@ -95,7 +95,7 @@ package mx.controls.beads.layouts
// do the proportional sizing of columns
var borderMetrics:EdgeData = (ValuesManager.valuesImpl as IBorderPaddingMarginValuesImpl).getBorderMetrics(_strand as IUIBase);
var useWidth:Number = uiHost.width - (borderMetrics.left + borderMetrics.right);
- var useHeight:Number = uiHost.height - (borderMetrics.top + borderMetrics.bottom) - header.height;
+ var useHeight:Number = uiHost.height - (borderMetrics.top + borderMetrics.bottom) - header.height - 1;
var displayedColumns:Array = (uiHost.view as IDataGridView).columnLists;
if (!displayedColumns) return retval;
var n:int = displayedColumns.length;