You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2022/06/10 06:54:30 UTC
Change in asterixdb[master]: [NO ISSUE][EXT] Add NullableDecl interface
From Till Westmann <ti...@apache.org>:
Till Westmann has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16525 )
Change subject: [NO ISSUE][EXT] Add NullableDecl interface
......................................................................
[NO ISSUE][EXT] Add NullableDecl interface
- user model changes: no
- storage format changes: no
- interface changes: added NullableDecl interface
Change-Id: I42f01b80892b3d1d7a4125bc1efab004126d2150
---
A asterixdb/asterix-external-data/src/main/java/org/checkerframework/checker/nullness/compatqual/NullableDecl.java
1 file changed, 26 insertions(+), 0 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/16525/1
diff --git a/asterixdb/asterix-external-data/src/main/java/org/checkerframework/checker/nullness/compatqual/NullableDecl.java b/asterixdb/asterix-external-data/src/main/java/org/checkerframework/checker/nullness/compatqual/NullableDecl.java
new file mode 100644
index 0000000..77bda7c
--- /dev/null
+++ b/asterixdb/asterix-external-data/src/main/java/org/checkerframework/checker/nullness/compatqual/NullableDecl.java
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.checkerframework.checker.nullness.compatqual;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+@Retention(RetentionPolicy.RUNTIME)
+public @interface NullableDecl {
+}
\ No newline at end of file
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16525
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I42f01b80892b3d1d7a4125bc1efab004126d2150
Gerrit-Change-Number: 16525
Gerrit-PatchSet: 1
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-MessageType: newchange
Change in asterixdb[master]: [NO ISSUE][EXT] Add NullableDecl interface
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Jenkins <je...@fulliautomatix.ics.uci.edu>:
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16525 )
Change subject: [NO ISSUE][EXT] Add NullableDecl interface
......................................................................
Patch Set 2: Contrib+1
Graphix Compatibility Tests Successful
https://asterix-jenkins.ics.uci.edu/job/graphix-compat/139/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16525
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I42f01b80892b3d1d7a4125bc1efab004126d2150
Gerrit-Change-Number: 16525
Gerrit-PatchSet: 2
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <hu...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-CC: Till Westmann <ti...@couchbase.com>
Gerrit-Comment-Date: Fri, 10 Jun 2022 17:57:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][EXT] Add NullableDecl interface
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Till Westmann <ti...@apache.org>:
Till Westmann has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16525 )
Change subject: [NO ISSUE][EXT] Add NullableDecl interface
......................................................................
[NO ISSUE][EXT] Add NullableDecl interface
- user model changes: no
- storage format changes: no
- interface changes: added NullableDecl interface
Change-Id: I42f01b80892b3d1d7a4125bc1efab004126d2150
---
A asterixdb/asterix-external-data/src/main/java/org/checkerframework/checker/nullness/compatqual/NullableDecl.java
1 file changed, 26 insertions(+), 0 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/16525/1
diff --git a/asterixdb/asterix-external-data/src/main/java/org/checkerframework/checker/nullness/compatqual/NullableDecl.java b/asterixdb/asterix-external-data/src/main/java/org/checkerframework/checker/nullness/compatqual/NullableDecl.java
new file mode 100644
index 0000000..77bda7c
--- /dev/null
+++ b/asterixdb/asterix-external-data/src/main/java/org/checkerframework/checker/nullness/compatqual/NullableDecl.java
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.checkerframework.checker.nullness.compatqual;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+@Retention(RetentionPolicy.RUNTIME)
+public @interface NullableDecl {
+}
\ No newline at end of file
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16525
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I42f01b80892b3d1d7a4125bc1efab004126d2150
Gerrit-Change-Number: 16525
Gerrit-PatchSet: 1
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-MessageType: newchange
Change in asterixdb[master]: [NO ISSUE][EXT] Add NullableDecl interface
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Till Westmann <ti...@couchbase.com>:
Till Westmann has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16525 )
Change subject: [NO ISSUE][EXT] Add NullableDecl interface
......................................................................
[NO ISSUE][EXT] Add NullableDecl interface
- user model changes: no
- storage format changes: no
- interface changes: added NullableDecl interface
Change-Id: I42f01b80892b3d1d7a4125bc1efab004126d2150
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16525
Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Michael Blow <mb...@apache.org>
---
A asterixdb/asterix-external-data/src/main/java/org/checkerframework/checker/nullness/compatqual/NullableDecl.java
1 file changed, 33 insertions(+), 0 deletions(-)
Approvals:
Michael Blow: Looks good to me, approved
Jenkins: Verified; ; Verified
diff --git a/asterixdb/asterix-external-data/src/main/java/org/checkerframework/checker/nullness/compatqual/NullableDecl.java b/asterixdb/asterix-external-data/src/main/java/org/checkerframework/checker/nullness/compatqual/NullableDecl.java
new file mode 100644
index 0000000..a4cb401
--- /dev/null
+++ b/asterixdb/asterix-external-data/src/main/java/org/checkerframework/checker/nullness/compatqual/NullableDecl.java
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.checkerframework.checker.nullness.compatqual;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+/*
+ * This is a clean room implementation of the NullableDecl interface based
+ * on 3 requirements:
+ * 1. shall be an @interface named NullableDecl
+ * 2. shall be in the org.checkerframework.checker.nullness.compatqual package
+ * 3. the rention policy for the interface shall be RUNTIME
+ */
+@Retention(RetentionPolicy.RUNTIME)
+public @interface NullableDecl {
+}
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16525
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I42f01b80892b3d1d7a4125bc1efab004126d2150
Gerrit-Change-Number: 16525
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <hu...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@couchbase.com>
Gerrit-MessageType: merged
Change in asterixdb[master]: [NO ISSUE][EXT] Add NullableDecl interface
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Till Westmann <ti...@apache.org>:
Hello Hussain Towaileb, Jenkins, Michael Blow,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16525
to look at the new patch set (#2).
Change subject: [NO ISSUE][EXT] Add NullableDecl interface
......................................................................
[NO ISSUE][EXT] Add NullableDecl interface
- user model changes: no
- storage format changes: no
- interface changes: added NullableDecl interface
Change-Id: I42f01b80892b3d1d7a4125bc1efab004126d2150
---
A asterixdb/asterix-external-data/src/main/java/org/checkerframework/checker/nullness/compatqual/NullableDecl.java
1 file changed, 33 insertions(+), 0 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/16525/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16525
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I42f01b80892b3d1d7a4125bc1efab004126d2150
Gerrit-Change-Number: 16525
Gerrit-PatchSet: 2
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Hussain Towaileb <hu...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-CC: Till Westmann <ti...@couchbase.com>
Gerrit-MessageType: newpatchset