[GitHub] [arrow] pitrou commented on a diff in pull request #13461: ARROW-16873: [Python] Clear PYTHONFAULTHANDLER when spawning child subprocess on run_debug_memory_pool tests

[GitBox <gi...@apache.org>]

pitrou commented on code in PR #13461:
URL: https://github.com/apache/arrow/pull/13461#discussion_r910065750


##########
ci/scripts/python_test.sh:
##########
@@ -54,4 +54,4 @@ export PYARROW_TEST_ORC
 export PYARROW_TEST_PARQUET
 export PYARROW_TEST_S3
 
-pytest -r s -v ${PYTEST_ARGS} --pyargs pyarrow
+pytest -r P -v ${PYTEST_ARGS} --pyargs pyarrow

Review Comment:
   Hmm, why the change? Should we undo it?



##########
python/pyarrow/tests/test_memory.py:
##########
@@ -188,6 +188,10 @@ def run_debug_memory_pool(pool_factory, env_value):
     code = f"""if 1:
         import ctypes
         import pyarrow as pa
+        import faulthandler
+        if faulthandler.is_enabled():
+            faulthandler.disable()
+        print("faulthandler.is_enabled(): ", faulthandler.is_enabled())

Review Comment:
   ```suggestion
           # ARROW-16873: some Python installs enable faulthandler by default,
           # which could dump a spurious stack trace if the following crashes
           import faulthandler
           faulthandler.disable()
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org