You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "r-sidd (via GitHub)" <gi...@apache.org> on 2023/06/05 19:23:32 UTC
[GitHub] [nifi] r-sidd opened a new pull request, #7341: NIFI-11643: Upgrade geoip2 to 4.0.1
r-sidd opened a new pull request, #7341:
URL: https://github.com/apache/nifi/pull/7341
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-11643](https://issues.apache.org/jira/browse/NIFI-11643)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] r-sidd commented on pull request #7341: NIFI-11643: Upgrade geoip2 to 4.0.1
Posted by "r-sidd (via GitHub)" <gi...@apache.org>.
r-sidd commented on PR #7341:
URL: https://github.com/apache/nifi/pull/7341#issuecomment-1579861542
> Thanks @r-sidd, this upgrade looks good for the main branch. This cannot be backported to the support branch due to Java 11 requirements, but this is helpful for the next major release version. +1 merging
Cool 🫡
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #7341: NIFI-11643: Upgrade geoip2 to 4.0.1
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory closed pull request #7341: NIFI-11643: Upgrade geoip2 to 4.0.1
URL: https://github.com/apache/nifi/pull/7341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] r-sidd commented on pull request #7341: NIFI-11643: Upgrade geoip2 to 4.0.1
Posted by "r-sidd (via GitHub)" <gi...@apache.org>.
r-sidd commented on PR #7341:
URL: https://github.com/apache/nifi/pull/7341#issuecomment-1577883822
> Version 4.0.1 includes changes from [3.0.0](https://github.com/maxmind/GeoIP2-java/releases/tag/v3.0.0) that require Java 11 as the minimum version, so this should be suitable for inclusion on the main branch, but cannot be backported to the version 1 support branch.
Cool, how should we go about it 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] r-sidd commented on pull request #7341: NIFI-11643: Upgrade geoip2 to 4.0.1
Posted by "r-sidd (via GitHub)" <gi...@apache.org>.
r-sidd commented on PR #7341:
URL: https://github.com/apache/nifi/pull/7341#issuecomment-1577356161
@exceptionfactory can you review this pls? Build success in local 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org