[jira] [Commented] (CTAKES-265) isDuplicate iterates over set

["Tim Miller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CTAKES-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820583#comment-13820583 ] 

Tim Miller commented on CTAKES-265:
-----------------------------------

Just realized that probably this isn't a big deal since it is only within a single lookup window?

> isDuplicate iterates over set
> -----------------------------
>
>                 Key: CTAKES-265
>                 URL: https://issues.apache.org/jira/browse/CTAKES-265
>             Project: cTAKES
>          Issue Type: Improvement
>          Components: ctakes-dictionary-lookup
>            Reporter: Tim Miller
>            Priority: Minor
>
> The private method isDuplicate() in DictionaryLookupAnnotator is used to filter out duplicates from its lookups. It does so by keeping a Set object full of objects its seen before, and then does a lookup by manually iterating over all the elements. I don't see any reason why it shouldn't just call the contains() method of Set, which I do not believe could possibly be slower. Probably much faster in fact. Any thoughts or suggestions?



--
This message was sent by Atlassian JIRA
(v6.1#6144)