You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@karaf.apache.org by Jean-Baptiste Onofré <jb...@nanthrax.net> on 2011/05/17 09:45:46 UTC
[PROPOSAL] Shell commands context support
Hi all,
Thanks the high Karaf adoption level, we have projects that provide
Karaf shell commands.
For instance, I added Karaf commands for Camel and I'm working in the
same area for ACE.
Currently, Camel Karaf commands look like:
camel:list-contexts
camel:list-routes
camel:stop-route
camel:info-route
camel:show-route
camel:info-context
What do you think about supporting a kind of commands context ?
For instance, the user could do:
karaf@root> cd camel
karaf@root> #camel> route:list
karaf@root> #camel> route:stop
karaf@root> cd ..
karaf@root> cd ace
karaf@root> #ace> distribution:list
karaf@root> cd ..
Regards
JB
Re: [PROPOSAL] Shell commands context support
Posted by Christian Schneider <ch...@die-schneider.net>.
I like the idea of context switching. I have seen a similar thing in
cisco routers. See their tutorial for inspriation:
http://www.cisco.com/warp/cpropub/45/tutorial.htm
I am not sure if the style they used is applicable for karaf but it is
always useful to look at mature implementations when defining such features.
Christian
Am 17.05.2011 09:45, schrieb Jean-Baptiste Onofré:
> Hi all,
>
> Thanks the high Karaf adoption level, we have projects that provide
> Karaf shell commands.
> For instance, I added Karaf commands for Camel and I'm working in the
> same area for ACE.
>
> Currently, Camel Karaf commands look like:
> camel:list-contexts
> camel:list-routes
> camel:stop-route
> camel:info-route
> camel:show-route
> camel:info-context
>
> What do you think about supporting a kind of commands context ?
>
> For instance, the user could do:
>
> karaf@root> cd camel
> karaf@root> #camel> route:list
> karaf@root> #camel> route:stop
> karaf@root> cd ..
> karaf@root> cd ace
> karaf@root> #ace> distribution:list
> karaf@root> cd ..
>
> Regards
> JB
>
--
Christian Schneider
http://www.liquid-reality.de
CXF and Camel Architect
Re: [PROPOSAL] Shell commands context support
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
+1 sure.
Else the end users will be lost :)
FYI, I raised KARAF-647 about this topic. Feel free to add your comments.
Regards
JB
On 05/18/2011 04:21 PM, mikevan wrote:
> We should also provide some mechanism from the console to list all of the
> available contexts.
>
>
> Andreas Pieber wrote:
>>
>> I think we should provide two methods here: one to store "command
>> context" (e.g. for camel context) and one for switching into
>> subcommand context. I'm not sure if we can handle this in the same
>> way.
>>
>> I think it would be fine to be able to do:
>>
>> root@karaf> camel:ctx xya
>> root@karaf #xya> camel:someCommand
>> root@karaf #xya> shell camel
>> root@karaf /camel/ #xya> someCommand
>> root@karaf /camel/ #xya> shell
>> root@karaf #xya>
>> ...
>>
>> I think you get my point. The shell part should be directly part of
>> karaf. For the ctx part we may be able to provide some general logic?
>>
>> Kind regards,
>> Andreas
>>
>> On Tue, May 17, 2011 at 10:24 PM, James Strachan
>> <james@fusesource.com> wrote:
>>> On 17 May 2011 20:54, mikevan<mvangeertruy@comcast.net> wrote:
>>>> Not really. I'm just thinking from an end-user perspective and how to
>>>> use
>>>> commands associated with a specfiic set of features. For example, if we
>>>> want to use camel-specific commands, what would the most intuitive way
>>>> be?
>>>> In previous posts, there were references to "context", which I (likely
>>>> misread) thought referred to a given set of shell-commands associated
>>>> with a
>>>> given feature. Ioannis referred to this is switching contexts, which
>>>> also
>>>> may be a bit misleading.
>>>
>>> There's only one camel shell. However CamelContext is a quite
>>> different camel thing; kinda like a Spring ApplicationContext or web
>>> application context; there can be many of them inside any Karaf
>>> container. Some commands in the camel shell refer to a specific
>>> CamelContext instance which folks may wish to default to use across
>>> different commands.
>>>
>>> So the part of this thread talking about associating camel contexts to
>>> the camel commands was analogous to associating web commands to a
>>> particular web application - so its not really related to switching or
>>> entering/leaving shells, its more to do with environment variables
>>> that commands use (to use the unix shell analogy).
>>>
>>> --
>>> James
>>> -------
>>> FuseSource
>>> Email: james@fusesource.com
>>> Web: http://fusesource.com
>>> Twitter: jstrachan, fusenews
>>> Blog: http://macstrac.blogspot.com/
>>>
>>> Connect at CamelOne May 24-26
>>> The Open Source Integration Conference
>>> http://camelone.com/
>>>
>>
>
>
> -----
> Mike Van (aka karafman)
> Karaf Team (Contributor)
> --
> View this message in context: http://karaf.922171.n3.nabble.com/PROPOSAL-Shell-commands-context-support-tp2951532p2957140.html
> Sent from the Karaf - Dev mailing list archive at Nabble.com.
Re: [PROPOSAL] Shell commands context support
Posted by mikevan <mv...@comcast.net>.
We should also provide some mechanism from the console to list all of the
available contexts.
Andreas Pieber wrote:
>
> I think we should provide two methods here: one to store "command
> context" (e.g. for camel context) and one for switching into
> subcommand context. I'm not sure if we can handle this in the same
> way.
>
> I think it would be fine to be able to do:
>
> root@karaf> camel:ctx xya
> root@karaf #xya> camel:someCommand
> root@karaf #xya> shell camel
> root@karaf /camel/ #xya> someCommand
> root@karaf /camel/ #xya> shell
> root@karaf #xya>
> ...
>
> I think you get my point. The shell part should be directly part of
> karaf. For the ctx part we may be able to provide some general logic?
>
> Kind regards,
> Andreas
>
> On Tue, May 17, 2011 at 10:24 PM, James Strachan
> <james@fusesource.com> wrote:
>> On 17 May 2011 20:54, mikevan <mvangeertruy@comcast.net> wrote:
>>> Not really. I'm just thinking from an end-user perspective and how to
>>> use
>>> commands associated with a specfiic set of features. For example, if we
>>> want to use camel-specific commands, what would the most intuitive way
>>> be?
>>> In previous posts, there were references to "context", which I (likely
>>> misread) thought referred to a given set of shell-commands associated
>>> with a
>>> given feature. Ioannis referred to this is switching contexts, which
>>> also
>>> may be a bit misleading.
>>
>> There's only one camel shell. However CamelContext is a quite
>> different camel thing; kinda like a Spring ApplicationContext or web
>> application context; there can be many of them inside any Karaf
>> container. Some commands in the camel shell refer to a specific
>> CamelContext instance which folks may wish to default to use across
>> different commands.
>>
>> So the part of this thread talking about associating camel contexts to
>> the camel commands was analogous to associating web commands to a
>> particular web application - so its not really related to switching or
>> entering/leaving shells, its more to do with environment variables
>> that commands use (to use the unix shell analogy).
>>
>> --
>> James
>> -------
>> FuseSource
>> Email: james@fusesource.com
>> Web: http://fusesource.com
>> Twitter: jstrachan, fusenews
>> Blog: http://macstrac.blogspot.com/
>>
>> Connect at CamelOne May 24-26
>> The Open Source Integration Conference
>> http://camelone.com/
>>
>
-----
Mike Van (aka karafman)
Karaf Team (Contributor)
--
View this message in context: http://karaf.922171.n3.nabble.com/PROPOSAL-Shell-commands-context-support-tp2951532p2957140.html
Sent from the Karaf - Dev mailing list archive at Nabble.com.
Re: [PROPOSAL] Shell commands context support
Posted by Andreas Pieber <an...@gmail.com>.
I think we should provide two methods here: one to store "command
context" (e.g. for camel context) and one for switching into
subcommand context. I'm not sure if we can handle this in the same
way.
I think it would be fine to be able to do:
root@karaf> camel:ctx xya
root@karaf #xya> camel:someCommand
root@karaf #xya> shell camel
root@karaf /camel/ #xya> someCommand
root@karaf /camel/ #xya> shell
root@karaf #xya>
...
I think you get my point. The shell part should be directly part of
karaf. For the ctx part we may be able to provide some general logic?
Kind regards,
Andreas
On Tue, May 17, 2011 at 10:24 PM, James Strachan <ja...@fusesource.com> wrote:
> On 17 May 2011 20:54, mikevan <mv...@comcast.net> wrote:
>> Not really. I'm just thinking from an end-user perspective and how to use
>> commands associated with a specfiic set of features. For example, if we
>> want to use camel-specific commands, what would the most intuitive way be?
>> In previous posts, there were references to "context", which I (likely
>> misread) thought referred to a given set of shell-commands associated with a
>> given feature. Ioannis referred to this is switching contexts, which also
>> may be a bit misleading.
>
> There's only one camel shell. However CamelContext is a quite
> different camel thing; kinda like a Spring ApplicationContext or web
> application context; there can be many of them inside any Karaf
> container. Some commands in the camel shell refer to a specific
> CamelContext instance which folks may wish to default to use across
> different commands.
>
> So the part of this thread talking about associating camel contexts to
> the camel commands was analogous to associating web commands to a
> particular web application - so its not really related to switching or
> entering/leaving shells, its more to do with environment variables
> that commands use (to use the unix shell analogy).
>
> --
> James
> -------
> FuseSource
> Email: james@fusesource.com
> Web: http://fusesource.com
> Twitter: jstrachan, fusenews
> Blog: http://macstrac.blogspot.com/
>
> Connect at CamelOne May 24-26
> The Open Source Integration Conference
> http://camelone.com/
>
Re: [PROPOSAL] Shell commands context support
Posted by James Strachan <ja...@fusesource.com>.
On 17 May 2011 20:54, mikevan <mv...@comcast.net> wrote:
> Not really. I'm just thinking from an end-user perspective and how to use
> commands associated with a specfiic set of features. For example, if we
> want to use camel-specific commands, what would the most intuitive way be?
> In previous posts, there were references to "context", which I (likely
> misread) thought referred to a given set of shell-commands associated with a
> given feature. Ioannis referred to this is switching contexts, which also
> may be a bit misleading.
There's only one camel shell. However CamelContext is a quite
different camel thing; kinda like a Spring ApplicationContext or web
application context; there can be many of them inside any Karaf
container. Some commands in the camel shell refer to a specific
CamelContext instance which folks may wish to default to use across
different commands.
So the part of this thread talking about associating camel contexts to
the camel commands was analogous to associating web commands to a
particular web application - so its not really related to switching or
entering/leaving shells, its more to do with environment variables
that commands use (to use the unix shell analogy).
--
James
-------
FuseSource
Email: james@fusesource.com
Web: http://fusesource.com
Twitter: jstrachan, fusenews
Blog: http://macstrac.blogspot.com/
Connect at CamelOne May 24-26
The Open Source Integration Conference
http://camelone.com/
Re: [PROPOSAL] Shell commands context support
Posted by mikevan <mv...@comcast.net>.
Not really. I'm just thinking from an end-user perspective and how to use
commands associated with a specfiic set of features. For example, if we
want to use camel-specific commands, what would the most intuitive way be?
In previous posts, there were references to "context", which I (likely
misread) thought referred to a given set of shell-commands associated with a
given feature. Ioannis referred to this is switching contexts, which also
may be a bit misleading.
So, to revise my statement, I'm not really referring to any specific
"context" rather I'm referring to how we provide access to feature-specific
commands. Currently, using the web commands as an example, when you install
the "web" feature, you get access to all of the web-commands. However, you
simply type web:something to use them.
In the above proposal, we're saying, hey why not have them notify karaf what
command-set (which feature) we want to use, and then allow the usage of
those commands.
Karaf@root> web:list
Becomes:
karaf@root> ctx:changeContext web
karaf@root> #web list
karaf@root> ctx.changeContext root
This way, if a bundle-vendor decides they want to use a feature-specific set
of commands for "foo", we have a way for users to access those commands.
But for clarity's sake, perhaps "shell" is better than "ctx"./
karaf@root> shell:changeCommandSet web
karaf@root> #web list
karaf@root> shell:changeCommandSet root
Is that clear as mud? Again, this is just how I understand the proposal.
Feel free to correct me, throw darts, bricks, etc...
James Strachan-2 wrote:
>
> You seem to be arguing about 2 completely separate things; how do we
> switch between command shells and secondly how should we define which
> CamelContext object from a potential list of things the various camel
> commands operate on.
>
> In terms of switching shells, I don't see why the shell name can't be
> used as a command & proper error reporting used if folks tab complete
> or mistype a command. Worst case "shell camel" would be fine I think.
>
> In terms of defining the camel context ID used for the camel commands;
> sure that'd be either a variable in the shell, an argument/option to
> the commands or some kind of camel:setcontext command. I wasn't
> proposing typing in the camelContext ID from JMX and have that start a
> sub shell if thats what you thought I meant.
>
>
> On 17 May 2011 15:17, mikevan <mvangeertruy@comcast.net> wrote:
>> I think its still misleading. What do we do if Camel's feature repository
>> has
>> a "camel" feature defined? While we can ensure that camel doesn't define
>> a
>> "camel" feature, this wont' always be the case. Also, how do we handle
>> the
>> event where a user types in a command that isn't defined, do we always
>> assume that command is a context? This will make it difficult to debug.
>> If
>> a user fat-fingers a command, and they get an error stating that
>> "command"
>> doesn't exist as a context, it will not tell them what the actual issue
>> is
>> (the command they typed doesn't exist). For these reasons, I suggest we
>> make switching contexts more obvious.
>>
>> karaf@root> ctx:switchContext camel
>> karaf@root> #camel> route:list
>> karaf@root> #camel> ctx:switchContext root
>> karaf@root> la
>>
>> By creating a command that specifically switches the context, we are
>> making
>> it clear to the system user exactly what they are doing, and we can
>> provide
>> errors based on the switching of a context.
>>
>>
>>
>> James Strachan-2 wrote:
>>>
>>> Maybe you need to define a variable for the camel context ID that the
>>> camel shell uses when listing stuff?
>>>
>>> On 17 May 2011 09:53, Claus Ibsen <claus.ibsen@gmail.com> wrote:
>>>> On Tue, May 17, 2011 at 10:32 AM, James Strachan
>>>> <james@fusesource.com> wrote:
>>>>> To feel more unixy, why not just use the name of the shell as the
>>>>> command?
>>>>>
>>>>> karaf@root> camel
>>>>> karaf@root> #camel> route:list
>>>>> karaf@root> #camel> route:stop
>>>>> karaf@root> exit
>>>>> karaf@root> ace
>>>>> karaf@root> #ace> distribution:list
>>>>> karaf@root> exit
>>>>>
>>>>> Or failing that "shell" would seem a good choice
>>>>>
>>>>> karaf@root> shell camel
>>>>> karaf@root> #camel> route:list
>>>>> karaf@root> #camel> route:stop
>>>>> karaf@root> exit
>>>>> karaf@root> shell ace
>>>>> karaf@root> #ace> distribution:list
>>>>> karaf@root> exit
>>>>>
>>>>>
>>>>
>>>> So if I have 3 camel apps in Karaf.
>>>>
>>>> And they each have an unique camel id. Lets call them
>>>>
>>>> wicketCamel
>>>> fooCamel
>>>> barCamel
>>>>
>>>> So what would that shell command exactly be?
>>>>
>>>> shell wicketCamel
>>>> shell camel
>>>> shell camel wicketCamel
>>>>
>>>> I guess you can either go into
>>>> - camel mode without having picked a specific camel context to use
>>>> - camel mode having picked a specific context
>>>>
>>>> Or is that overkill
>>>>
>>>> shell camel -> camel mode without picking a specific camel context
>>>> shell camel wicketCamel -> to pick the wicketCamel app
>>>>
>>>> So in the latter case, when I do a
>>>> route-list
>>>>
>>>> It only shows the routes from wicketCamel
>>>>
>>>>
>>>>
>>>>
>>>>> On 17 May 2011 09:22, Ioannis Canellos <iocanel@gmail.com>
>>>>> wrote:
>>>>>> +1 for the idea.
>>>>>>
>>>>>> I would like to propose however to context switch using an other
>>>>>> command
>>>>>> instead of "cd" because "cd" will cause confusion. I would propose
>>>>>> ctx
>>>>>> instead.
>>>>>>
>>>>>> --
>>>>>> *Ioannis Canellos*
>>>>>> *
>>>>>> http://iocanel.blogspot.com
>>>>>>
>>>>>> Apache Karaf <http://karaf.apache.org/> Committer & PMC
>>>>>> Apache ServiceMix <http://servicemix.apache.org/> Committer
>>>>>> *
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> James
>>>>> -------
>>>>> FuseSource
>>>>> Email: james@fusesource.com
>>>>> Web: http://fusesource.com
>>>>> Twitter: jstrachan, fusenews
>>>>> Blog: http://macstrac.blogspot.com/
>>>>>
>>>>> Connect at CamelOne May 24-26
>>>>> The Open Source Integration Conference
>>>>> http://camelone.com/
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Claus Ibsen
>>>> -----------------
>>>> FuseSource
>>>> Email: cibsen@fusesource.com
>>>> Web: http://fusesource.com
>>>> CamelOne 2011: http://fusesource.com/camelone2011/
>>>> Twitter: davsclaus, fusenews
>>>> Blog: http://davsclaus.blogspot.com/
>>>> Author of Camel in Action: http://www.manning.com/ibsen/
>>>>
>>>
>>>
>>>
>>> --
>>> James
>>> -------
>>> FuseSource
>>> Email: james@fusesource.com
>>> Web: http://fusesource.com
>>> Twitter: jstrachan, fusenews
>>> Blog: http://macstrac.blogspot.com/
>>>
>>> Connect at CamelOne May 24-26
>>> The Open Source Integration Conference
>>> http://camelone.com/
>>>
>>
>>
>> -----
>> Mike Van (aka karafman)
>> Karaf Team (Contributor)
>> --
>> View this message in context:
>> http://karaf.922171.n3.nabble.com/PROPOSAL-Shell-commands-context-support-tp2951532p2952678.html
>> Sent from the Karaf - Dev mailing list archive at Nabble.com.
>>
>
>
>
> --
> James
> -------
> FuseSource
> Email: james@fusesource.com
> Web: http://fusesource.com
> Twitter: jstrachan, fusenews
> Blog: http://macstrac.blogspot.com/
>
> Connect at CamelOne May 24-26
> The Open Source Integration Conference
> http://camelone.com/
>
-----
Mike Van (aka karafman)
Karaf Team (Contributor)
--
View this message in context: http://karaf.922171.n3.nabble.com/PROPOSAL-Shell-commands-context-support-tp2951532p2953988.html
Sent from the Karaf - Dev mailing list archive at Nabble.com.
Re: [PROPOSAL] Shell commands context support
Posted by James Strachan <ja...@fusesource.com>.
You seem to be arguing about 2 completely separate things; how do we
switch between command shells and secondly how should we define which
CamelContext object from a potential list of things the various camel
commands operate on.
In terms of switching shells, I don't see why the shell name can't be
used as a command & proper error reporting used if folks tab complete
or mistype a command. Worst case "shell camel" would be fine I think.
In terms of defining the camel context ID used for the camel commands;
sure that'd be either a variable in the shell, an argument/option to
the commands or some kind of camel:setcontext command. I wasn't
proposing typing in the camelContext ID from JMX and have that start a
sub shell if thats what you thought I meant.
On 17 May 2011 15:17, mikevan <mv...@comcast.net> wrote:
> I think its still misleading. What do we do if Camel's feature repository has
> a "camel" feature defined? While we can ensure that camel doesn't define a
> "camel" feature, this wont' always be the case. Also, how do we handle the
> event where a user types in a command that isn't defined, do we always
> assume that command is a context? This will make it difficult to debug. If
> a user fat-fingers a command, and they get an error stating that "command"
> doesn't exist as a context, it will not tell them what the actual issue is
> (the command they typed doesn't exist). For these reasons, I suggest we
> make switching contexts more obvious.
>
> karaf@root> ctx:switchContext camel
> karaf@root> #camel> route:list
> karaf@root> #camel> ctx:switchContext root
> karaf@root> la
>
> By creating a command that specifically switches the context, we are making
> it clear to the system user exactly what they are doing, and we can provide
> errors based on the switching of a context.
>
>
>
> James Strachan-2 wrote:
>>
>> Maybe you need to define a variable for the camel context ID that the
>> camel shell uses when listing stuff?
>>
>> On 17 May 2011 09:53, Claus Ibsen <claus.ibsen@gmail.com> wrote:
>>> On Tue, May 17, 2011 at 10:32 AM, James Strachan
>>> <james@fusesource.com> wrote:
>>>> To feel more unixy, why not just use the name of the shell as the
>>>> command?
>>>>
>>>> karaf@root> camel
>>>> karaf@root> #camel> route:list
>>>> karaf@root> #camel> route:stop
>>>> karaf@root> exit
>>>> karaf@root> ace
>>>> karaf@root> #ace> distribution:list
>>>> karaf@root> exit
>>>>
>>>> Or failing that "shell" would seem a good choice
>>>>
>>>> karaf@root> shell camel
>>>> karaf@root> #camel> route:list
>>>> karaf@root> #camel> route:stop
>>>> karaf@root> exit
>>>> karaf@root> shell ace
>>>> karaf@root> #ace> distribution:list
>>>> karaf@root> exit
>>>>
>>>>
>>>
>>> So if I have 3 camel apps in Karaf.
>>>
>>> And they each have an unique camel id. Lets call them
>>>
>>> wicketCamel
>>> fooCamel
>>> barCamel
>>>
>>> So what would that shell command exactly be?
>>>
>>> shell wicketCamel
>>> shell camel
>>> shell camel wicketCamel
>>>
>>> I guess you can either go into
>>> - camel mode without having picked a specific camel context to use
>>> - camel mode having picked a specific context
>>>
>>> Or is that overkill
>>>
>>> shell camel -> camel mode without picking a specific camel context
>>> shell camel wicketCamel -> to pick the wicketCamel app
>>>
>>> So in the latter case, when I do a
>>> route-list
>>>
>>> It only shows the routes from wicketCamel
>>>
>>>
>>>
>>>
>>>> On 17 May 2011 09:22, Ioannis Canellos <iocanel@gmail.com> wrote:
>>>>> +1 for the idea.
>>>>>
>>>>> I would like to propose however to context switch using an other
>>>>> command
>>>>> instead of "cd" because "cd" will cause confusion. I would propose ctx
>>>>> instead.
>>>>>
>>>>> --
>>>>> *Ioannis Canellos*
>>>>> *
>>>>> http://iocanel.blogspot.com
>>>>>
>>>>> Apache Karaf <http://karaf.apache.org/> Committer & PMC
>>>>> Apache ServiceMix <http://servicemix.apache.org/> Committer
>>>>> *
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> James
>>>> -------
>>>> FuseSource
>>>> Email: james@fusesource.com
>>>> Web: http://fusesource.com
>>>> Twitter: jstrachan, fusenews
>>>> Blog: http://macstrac.blogspot.com/
>>>>
>>>> Connect at CamelOne May 24-26
>>>> The Open Source Integration Conference
>>>> http://camelone.com/
>>>>
>>>
>>>
>>>
>>> --
>>> Claus Ibsen
>>> -----------------
>>> FuseSource
>>> Email: cibsen@fusesource.com
>>> Web: http://fusesource.com
>>> CamelOne 2011: http://fusesource.com/camelone2011/
>>> Twitter: davsclaus, fusenews
>>> Blog: http://davsclaus.blogspot.com/
>>> Author of Camel in Action: http://www.manning.com/ibsen/
>>>
>>
>>
>>
>> --
>> James
>> -------
>> FuseSource
>> Email: james@fusesource.com
>> Web: http://fusesource.com
>> Twitter: jstrachan, fusenews
>> Blog: http://macstrac.blogspot.com/
>>
>> Connect at CamelOne May 24-26
>> The Open Source Integration Conference
>> http://camelone.com/
>>
>
>
> -----
> Mike Van (aka karafman)
> Karaf Team (Contributor)
> --
> View this message in context: http://karaf.922171.n3.nabble.com/PROPOSAL-Shell-commands-context-support-tp2951532p2952678.html
> Sent from the Karaf - Dev mailing list archive at Nabble.com.
>
--
James
-------
FuseSource
Email: james@fusesource.com
Web: http://fusesource.com
Twitter: jstrachan, fusenews
Blog: http://macstrac.blogspot.com/
Connect at CamelOne May 24-26
The Open Source Integration Conference
http://camelone.com/
Re: [PROPOSAL] Shell commands context support
Posted by mikevan <mv...@comcast.net>.
I think its still misleading. What do we do if Camel's feature repository has
a "camel" feature defined? While we can ensure that camel doesn't define a
"camel" feature, this wont' always be the case. Also, how do we handle the
event where a user types in a command that isn't defined, do we always
assume that command is a context? This will make it difficult to debug. If
a user fat-fingers a command, and they get an error stating that "command"
doesn't exist as a context, it will not tell them what the actual issue is
(the command they typed doesn't exist). For these reasons, I suggest we
make switching contexts more obvious.
karaf@root> ctx:switchContext camel
karaf@root> #camel> route:list
karaf@root> #camel> ctx:switchContext root
karaf@root> la
By creating a command that specifically switches the context, we are making
it clear to the system user exactly what they are doing, and we can provide
errors based on the switching of a context.
James Strachan-2 wrote:
>
> Maybe you need to define a variable for the camel context ID that the
> camel shell uses when listing stuff?
>
> On 17 May 2011 09:53, Claus Ibsen <claus.ibsen@gmail.com> wrote:
>> On Tue, May 17, 2011 at 10:32 AM, James Strachan
>> <james@fusesource.com> wrote:
>>> To feel more unixy, why not just use the name of the shell as the
>>> command?
>>>
>>> karaf@root> camel
>>> karaf@root> #camel> route:list
>>> karaf@root> #camel> route:stop
>>> karaf@root> exit
>>> karaf@root> ace
>>> karaf@root> #ace> distribution:list
>>> karaf@root> exit
>>>
>>> Or failing that "shell" would seem a good choice
>>>
>>> karaf@root> shell camel
>>> karaf@root> #camel> route:list
>>> karaf@root> #camel> route:stop
>>> karaf@root> exit
>>> karaf@root> shell ace
>>> karaf@root> #ace> distribution:list
>>> karaf@root> exit
>>>
>>>
>>
>> So if I have 3 camel apps in Karaf.
>>
>> And they each have an unique camel id. Lets call them
>>
>> wicketCamel
>> fooCamel
>> barCamel
>>
>> So what would that shell command exactly be?
>>
>> shell wicketCamel
>> shell camel
>> shell camel wicketCamel
>>
>> I guess you can either go into
>> - camel mode without having picked a specific camel context to use
>> - camel mode having picked a specific context
>>
>> Or is that overkill
>>
>> shell camel -> camel mode without picking a specific camel context
>> shell camel wicketCamel -> to pick the wicketCamel app
>>
>> So in the latter case, when I do a
>> route-list
>>
>> It only shows the routes from wicketCamel
>>
>>
>>
>>
>>> On 17 May 2011 09:22, Ioannis Canellos <iocanel@gmail.com> wrote:
>>>> +1 for the idea.
>>>>
>>>> I would like to propose however to context switch using an other
>>>> command
>>>> instead of "cd" because "cd" will cause confusion. I would propose ctx
>>>> instead.
>>>>
>>>> --
>>>> *Ioannis Canellos*
>>>> *
>>>> http://iocanel.blogspot.com
>>>>
>>>> Apache Karaf <http://karaf.apache.org/> Committer & PMC
>>>> Apache ServiceMix <http://servicemix.apache.org/> Committer
>>>> *
>>>>
>>>
>>>
>>>
>>> --
>>> James
>>> -------
>>> FuseSource
>>> Email: james@fusesource.com
>>> Web: http://fusesource.com
>>> Twitter: jstrachan, fusenews
>>> Blog: http://macstrac.blogspot.com/
>>>
>>> Connect at CamelOne May 24-26
>>> The Open Source Integration Conference
>>> http://camelone.com/
>>>
>>
>>
>>
>> --
>> Claus Ibsen
>> -----------------
>> FuseSource
>> Email: cibsen@fusesource.com
>> Web: http://fusesource.com
>> CamelOne 2011: http://fusesource.com/camelone2011/
>> Twitter: davsclaus, fusenews
>> Blog: http://davsclaus.blogspot.com/
>> Author of Camel in Action: http://www.manning.com/ibsen/
>>
>
>
>
> --
> James
> -------
> FuseSource
> Email: james@fusesource.com
> Web: http://fusesource.com
> Twitter: jstrachan, fusenews
> Blog: http://macstrac.blogspot.com/
>
> Connect at CamelOne May 24-26
> The Open Source Integration Conference
> http://camelone.com/
>
-----
Mike Van (aka karafman)
Karaf Team (Contributor)
--
View this message in context: http://karaf.922171.n3.nabble.com/PROPOSAL-Shell-commands-context-support-tp2951532p2952678.html
Sent from the Karaf - Dev mailing list archive at Nabble.com.
Re: [PROPOSAL] Shell commands context support
Posted by James Strachan <ja...@fusesource.com>.
Maybe you need to define a variable for the camel context ID that the
camel shell uses when listing stuff?
On 17 May 2011 09:53, Claus Ibsen <cl...@gmail.com> wrote:
> On Tue, May 17, 2011 at 10:32 AM, James Strachan <ja...@fusesource.com> wrote:
>> To feel more unixy, why not just use the name of the shell as the command?
>>
>> karaf@root> camel
>> karaf@root> #camel> route:list
>> karaf@root> #camel> route:stop
>> karaf@root> exit
>> karaf@root> ace
>> karaf@root> #ace> distribution:list
>> karaf@root> exit
>>
>> Or failing that "shell" would seem a good choice
>>
>> karaf@root> shell camel
>> karaf@root> #camel> route:list
>> karaf@root> #camel> route:stop
>> karaf@root> exit
>> karaf@root> shell ace
>> karaf@root> #ace> distribution:list
>> karaf@root> exit
>>
>>
>
> So if I have 3 camel apps in Karaf.
>
> And they each have an unique camel id. Lets call them
>
> wicketCamel
> fooCamel
> barCamel
>
> So what would that shell command exactly be?
>
> shell wicketCamel
> shell camel
> shell camel wicketCamel
>
> I guess you can either go into
> - camel mode without having picked a specific camel context to use
> - camel mode having picked a specific context
>
> Or is that overkill
>
> shell camel -> camel mode without picking a specific camel context
> shell camel wicketCamel -> to pick the wicketCamel app
>
> So in the latter case, when I do a
> route-list
>
> It only shows the routes from wicketCamel
>
>
>
>
>> On 17 May 2011 09:22, Ioannis Canellos <io...@gmail.com> wrote:
>>> +1 for the idea.
>>>
>>> I would like to propose however to context switch using an other command
>>> instead of "cd" because "cd" will cause confusion. I would propose ctx
>>> instead.
>>>
>>> --
>>> *Ioannis Canellos*
>>> *
>>> http://iocanel.blogspot.com
>>>
>>> Apache Karaf <http://karaf.apache.org/> Committer & PMC
>>> Apache ServiceMix <http://servicemix.apache.org/> Committer
>>> *
>>>
>>
>>
>>
>> --
>> James
>> -------
>> FuseSource
>> Email: james@fusesource.com
>> Web: http://fusesource.com
>> Twitter: jstrachan, fusenews
>> Blog: http://macstrac.blogspot.com/
>>
>> Connect at CamelOne May 24-26
>> The Open Source Integration Conference
>> http://camelone.com/
>>
>
>
>
> --
> Claus Ibsen
> -----------------
> FuseSource
> Email: cibsen@fusesource.com
> Web: http://fusesource.com
> CamelOne 2011: http://fusesource.com/camelone2011/
> Twitter: davsclaus, fusenews
> Blog: http://davsclaus.blogspot.com/
> Author of Camel in Action: http://www.manning.com/ibsen/
>
--
James
-------
FuseSource
Email: james@fusesource.com
Web: http://fusesource.com
Twitter: jstrachan, fusenews
Blog: http://macstrac.blogspot.com/
Connect at CamelOne May 24-26
The Open Source Integration Conference
http://camelone.com/
Re: [PROPOSAL] Shell commands context support
Posted by Claus Ibsen <cl...@gmail.com>.
On Tue, May 17, 2011 at 10:32 AM, James Strachan <ja...@fusesource.com> wrote:
> To feel more unixy, why not just use the name of the shell as the command?
>
> karaf@root> camel
> karaf@root> #camel> route:list
> karaf@root> #camel> route:stop
> karaf@root> exit
> karaf@root> ace
> karaf@root> #ace> distribution:list
> karaf@root> exit
>
> Or failing that "shell" would seem a good choice
>
> karaf@root> shell camel
> karaf@root> #camel> route:list
> karaf@root> #camel> route:stop
> karaf@root> exit
> karaf@root> shell ace
> karaf@root> #ace> distribution:list
> karaf@root> exit
>
>
So if I have 3 camel apps in Karaf.
And they each have an unique camel id. Lets call them
wicketCamel
fooCamel
barCamel
So what would that shell command exactly be?
shell wicketCamel
shell camel
shell camel wicketCamel
I guess you can either go into
- camel mode without having picked a specific camel context to use
- camel mode having picked a specific context
Or is that overkill
shell camel -> camel mode without picking a specific camel context
shell camel wicketCamel -> to pick the wicketCamel app
So in the latter case, when I do a
route-list
It only shows the routes from wicketCamel
> On 17 May 2011 09:22, Ioannis Canellos <io...@gmail.com> wrote:
>> +1 for the idea.
>>
>> I would like to propose however to context switch using an other command
>> instead of "cd" because "cd" will cause confusion. I would propose ctx
>> instead.
>>
>> --
>> *Ioannis Canellos*
>> *
>> http://iocanel.blogspot.com
>>
>> Apache Karaf <http://karaf.apache.org/> Committer & PMC
>> Apache ServiceMix <http://servicemix.apache.org/> Committer
>> *
>>
>
>
>
> --
> James
> -------
> FuseSource
> Email: james@fusesource.com
> Web: http://fusesource.com
> Twitter: jstrachan, fusenews
> Blog: http://macstrac.blogspot.com/
>
> Connect at CamelOne May 24-26
> The Open Source Integration Conference
> http://camelone.com/
>
--
Claus Ibsen
-----------------
FuseSource
Email: cibsen@fusesource.com
Web: http://fusesource.com
CamelOne 2011: http://fusesource.com/camelone2011/
Twitter: davsclaus, fusenews
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/
Re: [PROPOSAL] Shell commands context support
Posted by Guillaume Nodet <gn...@gmail.com>.
Sounds good.
>From an implementation pov, gogo has a concept of SCOPE which is a
session variable which contains a colon separated list of command
scope to search.
Simply adding "camel" at the beginning of that list should work I think.
On Tue, May 17, 2011 at 10:35, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> You're right guys.
>
> +1 for the James' proposal, using directly the context name:
>
> karaf@root> camel
> karaf@root> #camel>
>
> If we are all OK about this feature, I will raise the corresponding Jira.
>
> Regards
> JB
>
> On 05/17/2011 10:32 AM, James Strachan wrote:
>>
>> To feel more unixy, why not just use the name of the shell as the command?
>>
>> karaf@root> camel
>> karaf@root> #camel> route:list
>> karaf@root> #camel> route:stop
>> karaf@root> exit
>> karaf@root> ace
>> karaf@root> #ace> distribution:list
>> karaf@root> exit
>>
>> Or failing that "shell" would seem a good choice
>>
>> karaf@root> shell camel
>> karaf@root> #camel> route:list
>> karaf@root> #camel> route:stop
>> karaf@root> exit
>> karaf@root> shell ace
>> karaf@root> #ace> distribution:list
>> karaf@root> exit
>>
>>
>> On 17 May 2011 09:22, Ioannis Canellos<io...@gmail.com> wrote:
>>>
>>> +1 for the idea.
>>>
>>> I would like to propose however to context switch using an other command
>>> instead of "cd" because "cd" will cause confusion. I would propose ctx
>>> instead.
>>>
>>> --
>>> *Ioannis Canellos*
>>> *
>>> http://iocanel.blogspot.com
>>>
>>> Apache Karaf<http://karaf.apache.org/> Committer& PMC
>>> Apache ServiceMix<http://servicemix.apache.org/> Committer
>>> *
>>>
>>
>>
>>
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
Connect at CamelOne May 24-26
The Open Source Integration Conference
http://camelone.com/
Re: [PROPOSAL] Shell commands context support
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Thanks for the update Guillaume.
I will take a look as soon as I raise the Jira.
Regards
JB
On 05/17/2011 10:47 AM, Guillaume Nodet wrote:
> Sounds good.
> From an implementation pov, gogo has a concept of SCOPE which is a
> session variable which contains a colon separated list of command
> scope to search.
> Simply adding "camel" at the beginning of that list should work I think.
>
> On Tue, May 17, 2011 at 10:35, Jean-Baptiste Onofré<jb...@nanthrax.net> wrote:
>> You're right guys.
>>
>> +1 for the James' proposal, using directly the context name:
>>
>> karaf@root> camel
>> karaf@root> #camel>
>>
>> If we are all OK about this feature, I will raise the corresponding Jira.
>>
>> Regards
>> JB
>>
>> On 05/17/2011 10:32 AM, James Strachan wrote:
>>>
>>> To feel more unixy, why not just use the name of the shell as the command?
>>>
>>> karaf@root> camel
>>> karaf@root> #camel> route:list
>>> karaf@root> #camel> route:stop
>>> karaf@root> exit
>>> karaf@root> ace
>>> karaf@root> #ace> distribution:list
>>> karaf@root> exit
>>>
>>> Or failing that "shell" would seem a good choice
>>>
>>> karaf@root> shell camel
>>> karaf@root> #camel> route:list
>>> karaf@root> #camel> route:stop
>>> karaf@root> exit
>>> karaf@root> shell ace
>>> karaf@root> #ace> distribution:list
>>> karaf@root> exit
>>>
>>>
>>> On 17 May 2011 09:22, Ioannis Canellos<io...@gmail.com> wrote:
>>>>
>>>> +1 for the idea.
>>>>
>>>> I would like to propose however to context switch using an other command
>>>> instead of "cd" because "cd" will cause confusion. I would propose ctx
>>>> instead.
>>>>
>>>> --
>>>> *Ioannis Canellos*
>>>> *
>>>> http://iocanel.blogspot.com
>>>>
>>>> Apache Karaf<http://karaf.apache.org/> Committer& PMC
>>>> Apache ServiceMix<http://servicemix.apache.org/> Committer
>>>> *
>>>>
>>>
>>>
>>>
>>
>
>
>
Re: [PROPOSAL] Shell commands context support
Posted by Guillaume Nodet <gn...@gmail.com>.
Sounds good.
>From an implementation pov, gogo has a concept of SCOPE which is a
session variable which contains a colon separated list of command
scope to search.
Simply adding "camel" at the beginning of that list should work I think.
On Tue, May 17, 2011 at 10:35, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> You're right guys.
>
> +1 for the James' proposal, using directly the context name:
>
> karaf@root> camel
> karaf@root> #camel>
>
> If we are all OK about this feature, I will raise the corresponding Jira.
>
> Regards
> JB
>
> On 05/17/2011 10:32 AM, James Strachan wrote:
>>
>> To feel more unixy, why not just use the name of the shell as the command?
>>
>> karaf@root> camel
>> karaf@root> #camel> route:list
>> karaf@root> #camel> route:stop
>> karaf@root> exit
>> karaf@root> ace
>> karaf@root> #ace> distribution:list
>> karaf@root> exit
>>
>> Or failing that "shell" would seem a good choice
>>
>> karaf@root> shell camel
>> karaf@root> #camel> route:list
>> karaf@root> #camel> route:stop
>> karaf@root> exit
>> karaf@root> shell ace
>> karaf@root> #ace> distribution:list
>> karaf@root> exit
>>
>>
>> On 17 May 2011 09:22, Ioannis Canellos<io...@gmail.com> wrote:
>>>
>>> +1 for the idea.
>>>
>>> I would like to propose however to context switch using an other command
>>> instead of "cd" because "cd" will cause confusion. I would propose ctx
>>> instead.
>>>
>>> --
>>> *Ioannis Canellos*
>>> *
>>> http://iocanel.blogspot.com
>>>
>>> Apache Karaf<http://karaf.apache.org/> Committer& PMC
>>> Apache ServiceMix<http://servicemix.apache.org/> Committer
>>> *
>>>
>>
>>
>>
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
Connect at CamelOne May 24-26
The Open Source Integration Conference
http://camelone.com/
Re: [PROPOSAL] Shell commands context support
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
You're right guys.
+1 for the James' proposal, using directly the context name:
karaf@root> camel
karaf@root> #camel>
If we are all OK about this feature, I will raise the corresponding Jira.
Regards
JB
On 05/17/2011 10:32 AM, James Strachan wrote:
> To feel more unixy, why not just use the name of the shell as the command?
>
> karaf@root> camel
> karaf@root> #camel> route:list
> karaf@root> #camel> route:stop
> karaf@root> exit
> karaf@root> ace
> karaf@root> #ace> distribution:list
> karaf@root> exit
>
> Or failing that "shell" would seem a good choice
>
> karaf@root> shell camel
> karaf@root> #camel> route:list
> karaf@root> #camel> route:stop
> karaf@root> exit
> karaf@root> shell ace
> karaf@root> #ace> distribution:list
> karaf@root> exit
>
>
> On 17 May 2011 09:22, Ioannis Canellos<io...@gmail.com> wrote:
>> +1 for the idea.
>>
>> I would like to propose however to context switch using an other command
>> instead of "cd" because "cd" will cause confusion. I would propose ctx
>> instead.
>>
>> --
>> *Ioannis Canellos*
>> *
>> http://iocanel.blogspot.com
>>
>> Apache Karaf<http://karaf.apache.org/> Committer& PMC
>> Apache ServiceMix<http://servicemix.apache.org/> Committer
>> *
>>
>
>
>
Re: [PROPOSAL] Shell commands context support
Posted by James Strachan <ja...@fusesource.com>.
To feel more unixy, why not just use the name of the shell as the command?
karaf@root> camel
karaf@root> #camel> route:list
karaf@root> #camel> route:stop
karaf@root> exit
karaf@root> ace
karaf@root> #ace> distribution:list
karaf@root> exit
Or failing that "shell" would seem a good choice
karaf@root> shell camel
karaf@root> #camel> route:list
karaf@root> #camel> route:stop
karaf@root> exit
karaf@root> shell ace
karaf@root> #ace> distribution:list
karaf@root> exit
On 17 May 2011 09:22, Ioannis Canellos <io...@gmail.com> wrote:
> +1 for the idea.
>
> I would like to propose however to context switch using an other command
> instead of "cd" because "cd" will cause confusion. I would propose ctx
> instead.
>
> --
> *Ioannis Canellos*
> *
> http://iocanel.blogspot.com
>
> Apache Karaf <http://karaf.apache.org/> Committer & PMC
> Apache ServiceMix <http://servicemix.apache.org/> Committer
> *
>
--
James
-------
FuseSource
Email: james@fusesource.com
Web: http://fusesource.com
Twitter: jstrachan, fusenews
Blog: http://macstrac.blogspot.com/
Connect at CamelOne May 24-26
The Open Source Integration Conference
http://camelone.com/
Re: [PROPOSAL] Shell commands context support
Posted by Ioannis Canellos <io...@gmail.com>.
+1 for the idea.
I would like to propose however to context switch using an other command
instead of "cd" because "cd" will cause confusion. I would propose ctx
instead.
--
*Ioannis Canellos*
*
http://iocanel.blogspot.com
Apache Karaf <http://karaf.apache.org/> Committer & PMC
Apache ServiceMix <http://servicemix.apache.org/> Committer
*
Re: [PROPOSAL] Shell commands context support
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Yes, good idea.
FYI, we had this kind of feature in ServiceMix Kernel but we "lost" that
when we switched to gogo.
Regards
JB
On 05/17/2011 10:07 AM, Achim Nierbeck wrote:
> Hi JB,
>
> I really like that Idea.
> I think it should also be possible to do a camel:list-contexts like
> command for a quick glance.
>
> For example a /camel/route:list ?
>
> Regards, Achim
>
>
>
> 2011/5/17 Jean-Baptiste Onofré<jb...@nanthrax.net>:
>> Hi all,
>>
>> Thanks the high Karaf adoption level, we have projects that provide Karaf
>> shell commands.
>> For instance, I added Karaf commands for Camel and I'm working in the same
>> area for ACE.
>>
>> Currently, Camel Karaf commands look like:
>> camel:list-contexts
>> camel:list-routes
>> camel:stop-route
>> camel:info-route
>> camel:show-route
>> camel:info-context
>>
>> What do you think about supporting a kind of commands context ?
>>
>> For instance, the user could do:
>>
>> karaf@root> cd camel
>> karaf@root> #camel> route:list
>> karaf@root> #camel> route:stop
>> karaf@root> cd ..
>> karaf@root> cd ace
>> karaf@root> #ace> distribution:list
>> karaf@root> cd ..
>>
>> Regards
>> JB
>>
>
>
>
Re: [PROPOSAL] Shell commands context support
Posted by Achim Nierbeck <bc...@googlemail.com>.
Hi JB,
I really like that Idea.
I think it should also be possible to do a camel:list-contexts like
command for a quick glance.
For example a /camel/route:list ?
Regards, Achim
2011/5/17 Jean-Baptiste Onofré <jb...@nanthrax.net>:
> Hi all,
>
> Thanks the high Karaf adoption level, we have projects that provide Karaf
> shell commands.
> For instance, I added Karaf commands for Camel and I'm working in the same
> area for ACE.
>
> Currently, Camel Karaf commands look like:
> camel:list-contexts
> camel:list-routes
> camel:stop-route
> camel:info-route
> camel:show-route
> camel:info-context
>
> What do you think about supporting a kind of commands context ?
>
> For instance, the user could do:
>
> karaf@root> cd camel
> karaf@root> #camel> route:list
> karaf@root> #camel> route:stop
> karaf@root> cd ..
> karaf@root> cd ace
> karaf@root> #ace> distribution:list
> karaf@root> cd ..
>
> Regards
> JB
>
--
--
*Achim Nierbeck*
Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
Committer & Project Lead
Re: [PROPOSAL] Shell commands context support
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi all,
FYI, I committed a first version of sub-shell.
The two following tasks should be done quickly:
- command completer should complete only commands from the current shell
- the prompt should display the shell part only when in a sub-shell
I will try to commit these changes tonight.
Regards
JB
On 05/17/2011 09:45 AM, Jean-Baptiste Onofré wrote:
> Hi all,
>
> Thanks the high Karaf adoption level, we have projects that provide
> Karaf shell commands.
> For instance, I added Karaf commands for Camel and I'm working in the
> same area for ACE.
>
> Currently, Camel Karaf commands look like:
> camel:list-contexts
> camel:list-routes
> camel:stop-route
> camel:info-route
> camel:show-route
> camel:info-context
>
> What do you think about supporting a kind of commands context ?
>
> For instance, the user could do:
>
> karaf@root> cd camel
> karaf@root> #camel> route:list
> karaf@root> #camel> route:stop
> karaf@root> cd ..
> karaf@root> cd ace
> karaf@root> #ace> distribution:list
> karaf@root> cd ..
>
> Regards
> JB
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com