[jira] [Created] (YARN-10849) Clarify testcase documentation for TestServiceAM#testContainersReleasedWhenPreLaunchFails

["Szilard Nemeth (Jira)" <ji...@apache.org>]

Szilard Nemeth created YARN-10849:
-------------------------------------

             Summary: Clarify testcase documentation for TestServiceAM#testContainersReleasedWhenPreLaunchFails
                 Key: YARN-10849
                 URL: https://issues.apache.org/jira/browse/YARN-10849
             Project: Hadoop YARN
          Issue Type: Improvement
            Reporter: Szilard Nemeth
            Assignee: Szilard Nemeth


There's a small comment added to testcase: org.apache.hadoop.yarn.service.TestServiceAM#testContainersReleasedWhenPreLaunchFails:
{code}
  // Test to verify that the containers are released and the
  // component instance is added to the pending queue when building the launch
  // context fails.
{code}

However, it was not clear for me why the "launch context" would fail.
While the test passes, it throws an Exception that tells the story. 

{code}
2021-07-06 18:31:04,438 ERROR [pool-275-thread-1] containerlaunch.ContainerLaunchService (ContainerLaunchService.java:run(122)) - [COMPINSTANCE compa-0 : container_1625589063422_0001_01_000001]: Failed to launch container.
java.lang.IllegalArgumentException: Can not create a Path from a null string
	at org.apache.hadoop.fs.Path.checkPathArg(Path.java:164)
	at org.apache.hadoop.fs.Path.<init>(Path.java:180)
	at org.apache.hadoop.yarn.service.provider.tarball.TarballProviderService.processArtifact(TarballProviderService.java:39)
	at org.apache.hadoop.yarn.service.provider.AbstractProviderService.buildContainerLaunchContext(AbstractProviderService.java:144)
	at org.apache.hadoop.yarn.service.containerlaunch.ContainerLaunchService$ContainerLauncher.run(ContainerLaunchService.java:107)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
{code}

This exception is thrown because the id of the Artifact object is unset (null) and TarballProviderService.processArtifact verifies it and it does not allow such artifacts.
The aim of this jira is to add a clarification comment or javadoc to this method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org