You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/30 01:35:46 UTC

[GitHub] [spark] maropu commented on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

maropu commented on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719117239


   > The main point is grouping with map(...) to remove disambiguity when we attached #5.
   
   This update seems fine to me. But, as @viirya suggested above, since consistent string forms for maps looks better, I also think it might be worth fixing it in future work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org