You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/04/17 19:09:00 UTC
Review Request 33290: DRILL-2782: 1-Hygiene before: Decide,
implement behavior for transaction-related JDBC methods
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33290/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Repository: drill-git
Description
-------
- Fixed/moved checkNotClosed to after constructor.
- Removed redundant "public"; "privatized" logger.
- Purged unused imports.
- A little commenting, editing, wrapping.
Diffs
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java a52644d
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 3fdbf84
exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 78ca221
Diff: https://reviews.apache.org/r/33290/diff/
Testing
-------
Ran existing tests; no new problems.
Thanks,
Daniel Barclay
Re: Review Request 33290: DRILL-2782: 1-Hygiene before: Decide,
implement behavior for transaction-related JDBC methods
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33290/#review80901
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On April 20, 2015, 3:03 a.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33290/
> -----------------------------------------------------------
>
> (Updated April 20, 2015, 3:03 a.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2782
> https://issues.apache.org/jira/browse/DRILL-2782
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> - Fixed/moved checkNotClosed to after constructor.
> - Removed redundant "public"; "privatized" logger.
> - Purged unused imports.
> - A little commenting, editing, wrapping.
>
>
> Diffs
> -----
>
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java a52644d
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 3fdbf84
> exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 78ca221
>
> Diff: https://reviews.apache.org/r/33290/diff/
>
>
> Testing
> -------
>
> Ran existing tests; no new problems.
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 33290: DRILL-2782: 1-Hygiene before: Decide,
implement behavior for transaction-related JDBC methods
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33290/
-----------------------------------------------------------
(Updated April 20, 2015, 3:03 a.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2782
https://issues.apache.org/jira/browse/DRILL-2782
Repository: drill-git
Description
-------
- Fixed/moved checkNotClosed to after constructor.
- Removed redundant "public"; "privatized" logger.
- Purged unused imports.
- A little commenting, editing, wrapping.
Diffs (updated)
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java a52644d
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 3fdbf84
exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 78ca221
Diff: https://reviews.apache.org/r/33290/diff/
Testing
-------
Ran existing tests; no new problems.
Thanks,
Daniel Barclay