You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2017/08/25 19:40:00 UTC

[jira] [Commented] (HBASE-18519) Use builder pattern to create cell

    [ https://issues.apache.org/jira/browse/HBASE-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142088#comment-16142088 ] 

stack commented on HBASE-18519:
-------------------------------

bq. We can add a static method which accepts configuration to pick different builder impl.
bq. I don't find use case that we set all cell's fields one by one for building a ByteBufferCell, so i leave a TODO in ExtendedCellBuilder.

Both sounds good to me. +1 from me. Get a look from [~anoop.hbase] or [~ram_krish] I'd say before commit; these are the Cell-Chucker Extrordinaires. Nice work [~chia7712] 



> Use builder pattern to create cell
> ----------------------------------
>
>                 Key: HBASE-18519
>                 URL: https://issues.apache.org/jira/browse/HBASE-18519
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>             Fix For: 2.0.0
>
>         Attachments: HBASE-18519.v0.patch, HBASE-18519.v1.patch, HBASE-18519.v2.patch
>
>
> The IndividualBytesFieldCell, which is introduced by HBASE-14882, carries the input arguments without copying.  We can substitute IndividualBytesFieldCell for CellUtil.createCell.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)