You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "csthomas1 (via GitHub)" <gi...@apache.org> on 2023/02/21 19:13:20 UTC
[GitHub] [pulsar] csthomas1 opened a new pull request, #19584: [fix][fn] Make KubernetesRuntime translate characters in function tenant, namespace, and name during function removal to avoid label errors
csthomas1 opened a new pull request, #19584:
URL: https://github.com/apache/pulsar/pull/19584
Make KubernetesRuntime translate tenant, namespace, and function name characters that are not allowed within Kubernetes labels as part of function removal.
Fixes #19583
### Motivation
See linked issue ticket.
### Modifications
Updated KubernetesRuntime.deleteStatefulSet() to pass function tenant, namespace, and name values through the pre-existing getLabels() function to replace disallowed characters.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [X] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #19584: [fix][fn] Make KubernetesRuntime translate characters in function tenant, namespace, and name during function removal to avoid label errors
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19584:
URL: https://github.com/apache/pulsar/pull/19584#issuecomment-1482143131
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #19584: [fix][fn] Make KubernetesRuntime translate characters in function tenant, namespace, and name during function removal to avoid label errors
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #19584:
URL: https://github.com/apache/pulsar/pull/19584#issuecomment-1542067246
@csthomas1 would you mind merging changes from master (or rebasing the changes) and fixing the issues with current master?
Kubernetes client version was upgraded from 12.0.1 version to 18.0.0 version in 93fb4f8eb6bd12872f05d7c5ec6c00b719d53009 . There are minor API changes which need to be addressed.
```
Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project pulsar-functions-runtime: Compilation failure
Error: /home/runner/work/pulsar/pulsar/pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeTest.java:[1313,21] method readNamespacedStatefulSet in class io.kubernetes.client.openapi.apis.AppsV1Api cannot be applied to given types;
Error: required: java.lang.String,java.lang.String,java.lang.String
Error: found: java.lang.String,java.lang.String,java.lang.Object,java.lang.Object,java.lang.Object
Error: reason: actual and formal argument lists differ in length
Error: -> [Help 1]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #19584: [fix][fn] Make KubernetesRuntime translate characters in function tenant, namespace, and name during function removal to avoid label errors
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #19584:
URL: https://github.com/apache/pulsar/pull/19584#issuecomment-1588527146
Merging...
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #19584: [fix][fn] Make KubernetesRuntime translate characters in function tenant, namespace, and name during function removal to avoid label errors
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #19584:
URL: https://github.com/apache/pulsar/pull/19584#issuecomment-1496989106
Closing and reopening to get a new build with a fresh merge commit for master branch in the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari closed pull request #19584: [fix][fn] Make KubernetesRuntime translate characters in function tenant, namespace, and name during function removal to avoid label errors
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari closed pull request #19584: [fix][fn] Make KubernetesRuntime translate characters in function tenant, namespace, and name during function removal to avoid label errors
URL: https://github.com/apache/pulsar/pull/19584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari closed pull request #19584: [fix][fn] Make KubernetesRuntime translate characters in function tenant, namespace, and name during function removal to avoid label errors
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari closed pull request #19584: [fix][fn] Make KubernetesRuntime translate characters in function tenant, namespace, and name during function removal to avoid label errors
URL: https://github.com/apache/pulsar/pull/19584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #19584: [fix][fn] Make KubernetesRuntime translate characters in function tenant, namespace, and name during function removal to avoid label errors
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #19584:
URL: https://github.com/apache/pulsar/pull/19584#issuecomment-1541897048
Closing and re-opening to trigger a new CI build with changes from master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #19584: [fix][fn] Make KubernetesRuntime translate characters in function tenant, namespace, and name during function removal to avoid label errors
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19584:
URL: https://github.com/apache/pulsar/pull/19584#issuecomment-1588502719
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/19584?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#19584](https://app.codecov.io/gh/apache/pulsar/pull/19584?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (83c5752) into [master](https://app.codecov.io/gh/apache/pulsar/commit/51c2bb4dfbd088810a76963ba86afeec2b193776?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (51c2bb4) will **increase** coverage by `39.52%`.
> The diff coverage is `100.00%`.
[](https://app.codecov.io/gh/apache/pulsar/pull/19584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #19584 +/- ##
=============================================
+ Coverage 33.50% 73.02% +39.52%
- Complexity 12053 31941 +19888
=============================================
Files 1613 1867 +254
Lines 126120 138591 +12471
Branches 13749 15222 +1473
=============================================
+ Hits 42254 101210 +58956
+ Misses 78332 29345 -48987
- Partials 5534 8036 +2502
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.25% <0.00%> (+0.08%)` | :arrow_up: |
| systests | `25.09% <0.00%> (?)` | |
| unittests | `72.27% <100.00%> (+40.35%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pulsar/pull/19584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...unctions/runtime/kubernetes/KubernetesRuntime.java](https://app.codecov.io/gh/apache/pulsar/pull/19584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWZ1bmN0aW9ucy9ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvZnVuY3Rpb25zL3J1bnRpbWUva3ViZXJuZXRlcy9LdWJlcm5ldGVzUnVudGltZS5qYXZh) | `49.16% <100.00%> (+49.16%)` | :arrow_up: |
... and [1521 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/19584/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun merged pull request #19584: [fix][fn] Make KubernetesRuntime translate characters in function tenant, namespace, and name during function removal to avoid label errors
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #19584:
URL: https://github.com/apache/pulsar/pull/19584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] csthomas1 commented on pull request #19584: [fix][fn] Make KubernetesRuntime translate characters in function tenant, namespace, and name during function removal to avoid label errors
Posted by "csthomas1 (via GitHub)" <gi...@apache.org>.
csthomas1 commented on PR #19584:
URL: https://github.com/apache/pulsar/pull/19584#issuecomment-1498987410
Sure!
On Wed, Apr 5, 2023 at 3:24 AM Nicolò Boschi ***@***.***>
wrote:
> ***@***.**** requested changes on this pull request.
>
> good catch! would you mind to add a test case?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/pulsar/pull/19584#pullrequestreview-1372300502>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AQ5QVSJOBEJ2NX5I3JWJL4DW7UMZRANCNFSM6AAAAAAVDNP4DI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org