[jira] [Commented] (AIRFLOW-3124) Broken webserver debug mode (RBAC)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629528#comment-16629528 ] 

ASF GitHub Bot commented on AIRFLOW-3124:
-----------------------------------------

akosel opened a new pull request #3958: [AIRFLOW-3124] Fix RBAC webserver debug mode
URL: https://github.com/apache/incubator-airflow/pull/3958
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-3124) issues and references them in the PR title.
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   The command `airflow webserver -d` crashes when `settings.RBAC == True`. This is because `create_app` currently returns `app, appbuilder`, which causes the app to crash with an `AttributeError`. Reading through the code, it doesn't look like we rely on `appbuilder` being returned by `create_app` anywhere, so it should be safe to remove this. 
   
   ### Tests
   
   - [x] My PR adds the following unit tests
   
   I set up the CLI to pass in the `unit_test_mode` setting to the flask app so we can disable the werkzeug reloader when running tests. If the reloader runs, there is an extra monitoring process left running after killing the main webserver process. This causes conflicts if multiple tests rely on being able to start a webserver (as the process will not be able to bind to the default socket).
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Broken webserver debug mode (RBAC)
> ----------------------------------
>
>                 Key: AIRFLOW-3124
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3124
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: webapp, webserver
>            Reporter: Aaron Kosel
>            Assignee: Aaron Kosel
>            Priority: Minor
>
> {code:java}
> Traceback (most recent call last):
> File "/usr/local/bin/airflow", line 7, in <module>
> exec(compile(f.read(), __file__, 'exec'))
> File "/airflow/airflow/bin/airflow", line 32, in <module>
> args.func(args)
> File "/airflow/airflow/utils/cli.py", line 74, in wrapper
> return f(*args, **kwargs)
> File "/airflow/airflow/bin/cli.py", line 875, in webserver
> app.run(debug=True, port=args.port, host=args.hostname,
> AttributeError: 'tuple' object has no attribute 'run'
> {code}
> Nearly the same issue as https://issues.apache.org/jira/browse/AIRFLOW-2204, but only affecting RBAC debug mode. The problem is that `create_app` returns a tuple, but the `cli` script expects to just receive the flask app back without the appbuilder.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)