You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/01/28 00:02:03 UTC
[GitHub] [helix] desaikomal opened a new pull request #1949: Fix for - Stale message redundant logs #1940
desaikomal opened a new pull request #1949:
URL: https://github.com/apache/helix/pull/1949
Do not generate unnecessary stale messages for irrelevant resource of instances.
We generate all stale messages for instance ignoring resource context.
We need to also verify that the partition is valid. The message can be a
simple message where it can be for a particular partition or message can be
in the form of batch, where we can have list of partitions. We need to skip
generating message only if resource and partition matches.
For now one particular test case: testClusterExpansion() is failing.
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Resolves #1940
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
Fix the log message
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
testClusterExpansion() is failing.
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
It is a bug fix and doesn't change API
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a change in pull request #1949: Fix for - Stale message redundant logs #1940
Posted by GitBox <gi...@apache.org>.
desaikomal commented on a change in pull request #1949:
URL: https://github.com/apache/helix/pull/1949#discussion_r794696721
##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
##########
@@ -53,6 +52,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+
Review comment:
I am using intellij-code-style but since my tests were failing on local machine while worked on linux-box, i did from that box.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal closed pull request #1949: Fix for - Stale message redundant logs #1940
Posted by GitBox <gi...@apache.org>.
desaikomal closed pull request #1949:
URL: https://github.com/apache/helix/pull/1949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 merged pull request #1949: Fix for - Stale message redundant logs #1940
Posted by GitBox <gi...@apache.org>.
NealSun96 merged pull request #1949:
URL: https://github.com/apache/helix/pull/1949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on a change in pull request #1949: Fix for - Stale message redundant logs #1940
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on a change in pull request #1949:
URL: https://github.com/apache/helix/pull/1949#discussion_r794691589
##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
##########
@@ -53,6 +52,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+
Review comment:
@desaikomal It occurred to me that you might not be using helix-style-intellij.xml to format the code. It's a requirement for Helix PRs, and you can find guidelines here: https://github.com/apache/helix/wiki/Helix-Code-Style-in-Intellij-IDE :)
##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
##########
@@ -200,11 +200,17 @@ private void generateMessage(final Resource resource, final BaseControllerDataPr
}
for (Message staleMessage : staleMessages) {
- if (System.currentTimeMillis() - currentStateOutput
+ if ((System.currentTimeMillis() - currentStateOutput
.getEndTime(resourceName, partition, instanceName)
- > DEFAULT_OBSELETE_MSG_PURGE_DELAY) {
- logAndAddToCleanUp(messagesToCleanUp, staleMessage, instanceName, resourceName,
- partition, currentState, STALE_MESSAGE);
+ > DEFAULT_OBSELETE_MSG_PURGE_DELAY)
+ && staleMessage.getResourceName().equals(resourceName)) {
+ // staleMessage can be simple or batch mode
+ if ((staleMessage.getPartitionName().equals(partition.getPartitionName()))
+ || (staleMessage.getBatchMessageMode()
+ && staleMessage.getPartitionNames().contains(partition.getPartitionName()))) {
Review comment:
Could you please combine the two if conditions into one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on pull request #1949: Fix for - Stale message redundant logs #1940
Posted by GitBox <gi...@apache.org>.
desaikomal commented on pull request #1949:
URL: https://github.com/apache/helix/pull/1949#issuecomment-1024708907
This PR is ready to be merged, approved by @NealSun96
Final commit message:
Avoid printing redundant log messages for unrelated partitions and resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on a change in pull request #1949: Fix for - Stale message redundant logs #1940
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on a change in pull request #1949:
URL: https://github.com/apache/helix/pull/1949#discussion_r794712360
##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
##########
@@ -53,6 +52,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+
Review comment:
Ok, if this is the result from auto styling, I have no objection - usually auto styling will result in no changes on empty lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org