You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/08/07 20:11:30 UTC

[GitHub] [druid] a2l007 opened a new pull request #10255: Set default server.maxsize to the sum of segment cache

a2l007 opened a new pull request #10255:
URL: https://github.com/apache/druid/pull/10255


   <!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
   
   Fixes #6469 and #10007 
   
   `druid.server.maxSize` will now default to the sum of `maxSize` values defined within the `druid.segmentCache.locations`. User can still provide a custom value for `druid.server.maxSize` which will take precedence over the default value.
   
   Since there aren't many usecases where this property needs to be different from the segmentCache size, we could gradually remove this user property in the future.
   <!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
   
   <!-- If you are a committer, follow the PR action item checklist for committers:
   https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
   
   
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [x] been tested in a test Druid cluster.
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
   
   <hr>
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] gianm merged pull request #10255: Set default server.maxsize to the sum of segment cache

Posted by GitBox <gi...@apache.org>.
gianm merged pull request #10255:
URL: https://github.com/apache/druid/pull/10255


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] a2l007 commented on pull request #10255: Set default server.maxsize to the sum of segment cache

Posted by GitBox <gi...@apache.org>.
a2l007 commented on pull request #10255:
URL: https://github.com/apache/druid/pull/10255#issuecomment-671102831


   @gianm Thanks for the review and I've made the changes based on your comments. I haven't touched the blurb about max_size in the [system schema documentation](https://druid.apache.org/docs/latest/querying/sql.html#servers-table) , as it points to the  druid.server.maxSize documentation anyways.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org