You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Swapan Shridhar <ss...@hortonworks.com> on 2015/11/18 01:43:08 UTC

Review Request 40405: AMBARI-13927. Stop-and-Start Upgrade: Falcon server restart failed intermittently during tar command execution in upgrade and downgrade paths

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40405/
-----------------------------------------------------------

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-13927
    https://issues.apache.org/jira/browse/AMBARI-13927


Repository: ambari


Description
-------

AMBARI-13927. Stop-and-Start Upgrade: Falcon server restart failed intermittently during tar command execution in upgrade and downgrade paths

- The retry after the failure works and tar command executes fine and Falcon server comes up.


RESOLUTION : Added a retry of 3 times in Execute running the 'tar related command' .


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py 49caf88 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 422f181 
  ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py df2a50f 

Diff: https://reviews.apache.org/r/40405/diff/


Testing
-------

- Tested the Upgrade and Downgrade path for HDP 2.3.2 <-> 2.3.4 : Din't see the failure.
- UT : Modified the Python UTs as per the new change related to 'tries=3'.
  
  ****** Result: PASS ******
  
  
  ***** Failure of 9 test cases is known and is happenning in trunk for "TestPackageResource.TestPackageResource" **********
  
  FAILED (failures=9)
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ....................................... SUCCESS [10.538s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.034s]
[INFO] Ambari Web ........................................ SUCCESS [47.055s]
[INFO] Ambari Views ...................................... SUCCESS [3.014s]
[INFO] Ambari Admin View ................................. SUCCESS [11.920s]
[INFO] ambari-metrics .................................... SUCCESS [1.229s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.878s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [3.458s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [2.459s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [4.005s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.495s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [1:15.444s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [2.749s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [7.545s]
[INFO] Ambari Server ..................................... SUCCESS [1:02:55.687s]
[INFO] Ambari Agent ...................................... FAILURE [9.204s]
[INFO] Ambari Client ..................................... SKIPPED
[INFO] Ambari Python Client .............................. SKIPPED
[INFO] Ambari Groovy Client .............................. SKIPPED
[INFO] Ambari Shell ...................................... SKIPPED
[INFO] Ambari Python Shell ............................... SKIPPED
[INFO] Ambari Groovy Shell ............................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------


Thanks,

Swapan Shridhar


Re: Review Request 40405: AMBARI-13927. Stop-and-Start Upgrade: Falcon server restart failed intermittently during tar command execution in upgrade and downgrade paths

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40405/#review107065
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Nov. 18, 2015, 6:41 p.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40405/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2015, 6:41 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-13927
>     https://issues.apache.org/jira/browse/AMBARI-13927
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMBARI-13927. Stop-and-Start Upgrade: Falcon server restart failed intermittently during tar command execution in upgrade and downgrade paths
> 
> - The retry after the failure works and tar command executes fine and Falcon server comes up.
> 
> 
> RESOLUTION : Added a retry of 3 times in Execute running the 'tar related command' .
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py 49caf88 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 422f181 
>   ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py df2a50f 
> 
> Diff: https://reviews.apache.org/r/40405/diff/
> 
> 
> Testing
> -------
> 
> - Tested the Upgrade and Downgrade path for HDP 2.3.2 <-> 2.3.4 : Din't see the failure.
> - UT : Modified the Python UTs as per the new change related to 'tries=3'.
>   
>   ****** Result: PASS ******
>   
>   
>   ***** Failure of 9 test cases is known and is happenning in trunk for "TestPackageResource.TestPackageResource" **********
>   
>   FAILED (failures=9)
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [10.538s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.034s]
> [INFO] Ambari Web ........................................ SUCCESS [47.055s]
> [INFO] Ambari Views ...................................... SUCCESS [3.014s]
> [INFO] Ambari Admin View ................................. SUCCESS [11.920s]
> [INFO] ambari-metrics .................................... SUCCESS [1.229s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.878s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [3.458s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [2.459s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [4.005s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.495s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [1:15.444s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [2.749s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [7.545s]
> [INFO] Ambari Server ..................................... SUCCESS [1:02:55.687s]
> [INFO] Ambari Agent ...................................... FAILURE [9.204s]
> [INFO] Ambari Client ..................................... SKIPPED
> [INFO] Ambari Python Client .............................. SKIPPED
> [INFO] Ambari Groovy Client .............................. SKIPPED
> [INFO] Ambari Shell ...................................... SKIPPED
> [INFO] Ambari Python Shell ............................... SKIPPED
> [INFO] Ambari Groovy Shell ............................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>


Re: Review Request 40405: AMBARI-13927. Stop-and-Start Upgrade: Falcon server restart failed intermittently during tar command execution in upgrade and downgrade paths

Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40405/
-----------------------------------------------------------

(Updated Nov. 18, 2015, 6:41 p.m.)


Review request for Ambari and Alejandro Fernandez.


Changes
-------

Added a parameter 'try_sleep' of 1 sec, as multiple things are running in parallel, so as to give fair change that the next retry will succeed.

- Ran Python UT : Success


Bugs: AMBARI-13927
    https://issues.apache.org/jira/browse/AMBARI-13927


Repository: ambari


Description
-------

AMBARI-13927. Stop-and-Start Upgrade: Falcon server restart failed intermittently during tar command execution in upgrade and downgrade paths

- The retry after the failure works and tar command executes fine and Falcon server comes up.


RESOLUTION : Added a retry of 3 times in Execute running the 'tar related command' .


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py 49caf88 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 422f181 
  ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py df2a50f 

Diff: https://reviews.apache.org/r/40405/diff/


Testing
-------

- Tested the Upgrade and Downgrade path for HDP 2.3.2 <-> 2.3.4 : Din't see the failure.
- UT : Modified the Python UTs as per the new change related to 'tries=3'.
  
  ****** Result: PASS ******
  
  
  ***** Failure of 9 test cases is known and is happenning in trunk for "TestPackageResource.TestPackageResource" **********
  
  FAILED (failures=9)
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ....................................... SUCCESS [10.538s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.034s]
[INFO] Ambari Web ........................................ SUCCESS [47.055s]
[INFO] Ambari Views ...................................... SUCCESS [3.014s]
[INFO] Ambari Admin View ................................. SUCCESS [11.920s]
[INFO] ambari-metrics .................................... SUCCESS [1.229s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.878s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [3.458s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [2.459s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [4.005s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.495s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [1:15.444s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [2.749s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [7.545s]
[INFO] Ambari Server ..................................... SUCCESS [1:02:55.687s]
[INFO] Ambari Agent ...................................... FAILURE [9.204s]
[INFO] Ambari Client ..................................... SKIPPED
[INFO] Ambari Python Client .............................. SKIPPED
[INFO] Ambari Groovy Client .............................. SKIPPED
[INFO] Ambari Shell ...................................... SKIPPED
[INFO] Ambari Python Shell ............................... SKIPPED
[INFO] Ambari Groovy Shell ............................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------


Thanks,

Swapan Shridhar