You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/06/20 16:58:17 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3583: Added IDImpl struct

ocket8888 commented on a change in pull request #3583: Added IDImpl struct
URL: https://github.com/apache/trafficcontrol/pull/3583#discussion_r295898136
 
 

 ##########
 File path: lib/go-tc/cdns.go
 ##########
 @@ -83,7 +85,7 @@ type CDNNullable struct {
 	// ID of the CDN
 	//
 	// required: true
-	ID *int `json:"id" db:"id"`
+	impl.ID
 
 Review comment:
   `lib/go-tc/cdns.go:88:2: error: reference to undefined identifier 'impl.ID'`
   I think either this should be `impl.ImplID` or you need to rename the struct to `ID`. Either will work, but I'm partial to the latter, myself; `impl.ImplID` feels redundant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services