You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/07/12 19:59:41 UTC

[GitHub] [ignite] ymolochkov opened a new pull request #9246: Ignite 12749 Fixed unsupported operation exception on node stop if collisionspi not null

ymolochkov opened a new pull request #9246:
URL: https://github.com/apache/ignite/pull/9246


   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] ymolochkov closed pull request #9246: Ignite 12749 Fixed unsupported operation exception on node stop if collisionspi not null

Posted by GitBox <gi...@apache.org>.
ymolochkov closed pull request #9246:
URL: https://github.com/apache/ignite/pull/9246


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] alamar commented on a change in pull request #9246: Ignite 12749 Fixed unsupported operation exception on node stop if collisionspi not null

Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #9246:
URL: https://github.com/apache/ignite/pull/9246#discussion_r667935089



##########
File path: modules/core/src/main/java/org/jsr166/ConcurrentLinkedHashMap.java
##########
@@ -983,6 +983,23 @@ V removeLocked(Object key, int hash, Object val, boolean cleanupQ) {
 
             return oldVal;
         }
+
+        /**
+         *
+         */
+        @SuppressWarnings("ExplicitArrayFilling")

Review comment:
       I'm pretty sure this needs to be synchronous and also that we can't possibly validate that it is thread safe.
   
   Can you please assign a new ConcurrentLinkedHashMap instead of calling clear, where applicable?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] AMashenkov commented on a change in pull request #9246: Ignite 12749 Fixed unsupported operation exception on node stop if collisionspi not null

Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #9246:
URL: https://github.com/apache/ignite/pull/9246#discussion_r667934747



##########
File path: modules/core/src/main/java/org/jsr166/ConcurrentLinkedHashMap.java
##########
@@ -1536,10 +1553,60 @@ public V replacex(K key, V oldVal, V newVal) {
     }
 
     /**
-     * Removes all of the mappings from this map.
+     * Removes all of the mappings from this map. Performs recursive table locking.
      */
     @Override public void clear() {
-        throw new UnsupportedOperationException();
+        int len = segments.length;
+
+        clear(0, len);
+    }
+
+    /**
+     * Recursively locks each segment in consistent order. When all segments are locked method clears them
+     * all and releases locks in reverse order.
+     * @param segIndex segIndex of a segment to lock
+     * @param len length of segments array
+     */
+    private void clear(int segIndex, int len) {
+

Review comment:
       ```suggestion
       private void clear(int segIndex, int len) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] ymolochkov commented on a change in pull request #9246: Ignite 12749 Fixed unsupported operation exception on node stop if collisionspi not null

Posted by GitBox <gi...@apache.org>.
ymolochkov commented on a change in pull request #9246:
URL: https://github.com/apache/ignite/pull/9246#discussion_r667948426



##########
File path: modules/core/src/main/java/org/jsr166/ConcurrentLinkedHashMap.java
##########
@@ -983,6 +983,23 @@ V removeLocked(Object key, int hash, Object val, boolean cleanupQ) {
 
             return oldVal;
         }
+
+        /**
+         *
+         */
+        @SuppressWarnings("ExplicitArrayFilling")

Review comment:
       Ok, will do




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org