You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/11/25 02:55:42 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request #17552: Monorepo stage 2
zhaoyongjie opened a new pull request #17552:
URL: https://github.com/apache/superset/pull/17552
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR implement [SIP-58](https://github.com/apache/superset/issues/13013), move superset-ui to this repo. NOTICE: Please merge [relocation-PR](https://github.com/apache/superset/pull/17445) before merging this PR.
1. Move `packages`, `plugins`, `scripts` directories into `superset_frontend`
2. All remaining files are saved in temporary_superset_ui
3. add `packages/*` and `plugins/*` to lerna packages
3. refactor superset-generator unit test
<img width="649" alt="image" src="https://user-images.githubusercontent.com/2016594/142445846-0a4dc1de-f679-4c83-acc7-21c02a70aecd.png">
-------------------------------------
To ensure that every PR passes the CI, the monorepo-related PR is split into multiple stages.
1. https://github.com/apache/superset/pull/17427
2. https://github.com/apache/superset/pull/17445
3. https://github.com/apache/superset/pull/17437 (this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fcbcca6) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.53%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.41% -8.54%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44423 +814
- Misses 12810 18618 +5808
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `57.08% <50.00%> (-14.01%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.12% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1289 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...fcbcca6](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (508b9a0) into [master](https://codecov.io/gh/apache/superset/commit/870d2ab16f6add45b78759a007d0aca8c4e48b3b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (870d2ab) will **decrease** coverage by `8.21%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.81% 68.59% -8.22%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43529 44537 +1008
- Misses 12889 18501 +5612
- Partials 253 1892 +1639
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.60% <ø> (?)` | |
| javascript | `57.08% <50.00%> (-14.02%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| presto | `81.90% <ø> (?)` | |
| python | `82.52% <ø> (+0.40%)` | :arrow_up: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1292 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [870d2ab...508b9a0](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e330069) into [master](https://codecov.io/gh/apache/superset/commit/74292829726ae9c47ca00889907e9421e8dc2b56?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7429282) will **decrease** coverage by `8.39%`.
> The diff coverage is `86.73%`.
> :exclamation: Current head e330069 differs from pull request most recent head cf6acbf. Consider uploading reports for the commit cf6acbf to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.95% 68.56% -8.40%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43611 44517 +906
- Misses 12807 18530 +5723
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `57.02% <86.73%> (-14.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `95.23% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `94.11% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `85.71% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `92.85% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `100.00% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `100.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1069 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7429282...cf6acbf](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c26d3a9) into [master](https://codecov.io/gh/apache/superset/commit/7353a2bd75ae5c76458615443f530a688e78db1c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7353a2b) will **decrease** coverage by `18.46%`.
> The diff coverage is `71.35%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
===========================================
- Coverage 76.81% 58.34% -18.47%
===========================================
Files 1049 1839 +790
Lines 56653 74838 +18185
Branches 7847 6983 -864
===========================================
+ Hits 43517 43667 +150
- Misses 12883 29271 +16388
- Partials 253 1900 +1647
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.59% <ø> (?)` | |
| javascript | `42.85% <71.35%> (-28.28%)` | :arrow_down: |
| mysql | `82.00% <ø> (ø)` | |
| postgres | `82.01% <ø> (ø)` | |
| python | `82.36% <ø> (+0.26%)` | :arrow_up: |
| sqlite | `81.69% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `83.33% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `80.95% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `82.35% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `39.28% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `28.57% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `68.75% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `80.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1323 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7353a2b...c26d3a9](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e330069) into [master](https://codecov.io/gh/apache/superset/commit/74292829726ae9c47ca00889907e9421e8dc2b56?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7429282) will **decrease** coverage by `8.39%`.
> The diff coverage is `86.73%`.
> :exclamation: Current head e330069 differs from pull request most recent head dfcab95. Consider uploading reports for the commit dfcab95 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.95% 68.56% -8.40%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43611 44517 +906
- Misses 12807 18530 +5723
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `57.02% <86.73%> (-14.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `95.23% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `94.11% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `85.71% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `92.85% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `100.00% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `100.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1069 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7429282...dfcab95](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1213309) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.35%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head 1213309 differs from pull request most recent head 16eb4ce. Consider uploading reports for the commit 16eb4ce to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.59% -8.36%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44542 +933
- Misses 12810 18499 +5689
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.61% <ø> (ø)` | |
| javascript | `57.08% <50.00%> (-14.01%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| presto | `81.90% <ø> (?)` | |
| python | `82.52% <ø> (+0.14%)` | :arrow_up: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1287 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...16eb4ce](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #17552:
URL: https://github.com/apache/superset/pull/17552#discussion_r758111429
##########
File path: superset-frontend/jest.config.js
##########
@@ -16,33 +16,64 @@
* specific language governing permissions and limitations
* under the License.
*/
+
module.exports = {
- testRegex: '(\\/spec|\\/src)\\/.*(_spec|\\.test)\\.(j|t)sx?$',
+ testRegex: '\\/(spec|src|plugins|packages)\\/.*(_spec|\\.test)\\.[jt]sx?$',
+ testPathIgnorePatterns: [
+ 'packages\\/generator-superset\\/.*',
Review comment:
should we add a TODO here to figure out why this was crashing tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16eb4ce) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.35%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head 16eb4ce differs from pull request most recent head 16c965c. Consider uploading reports for the commit 16c965c to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.59% -8.36%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44542 +933
- Misses 12810 18499 +5689
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.61% <ø> (ø)` | |
| javascript | `57.08% <50.00%> (-14.01%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| presto | `81.90% <ø> (?)` | |
| python | `82.52% <ø> (+0.14%)` | :arrow_up: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1286 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...16c965c](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e55550b) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.53%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head e55550b differs from pull request most recent head 16c965c. Consider uploading reports for the commit 16c965c to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.41% -8.54%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44423 +814
- Misses 12810 18618 +5808
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `57.08% <50.00%> (-14.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1286 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...16c965c](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1065a69) into [master](https://codecov.io/gh/apache/superset/commit/7353a2bd75ae5c76458615443f530a688e78db1c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7353a2b) will **decrease** coverage by `8.47%`.
> The diff coverage is `85.96%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.81% 68.33% -8.48%
==========================================
Files 1049 1588 +539
Lines 56653 64916 +8263
Branches 7847 6960 -887
==========================================
+ Hits 43517 44361 +844
- Misses 12883 18672 +5789
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `56.97% <85.96%> (-14.16%)` | :arrow_down: |
| mysql | `82.00% <ø> (ø)` | |
| postgres | `82.01% <ø> (ø)` | |
| python | `82.10% <ø> (ø)` | |
| sqlite | `81.69% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `95.23% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `94.11% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `85.71% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `92.85% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `100.00% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `100.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1065 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7353a2b...1065a69](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (44cbf80) into [master](https://codecov.io/gh/apache/superset/commit/2e29f36e7885b693a0af2cf8b0b8ca86d2970f64?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2e29f36) will **decrease** coverage by `8.59%`.
> The diff coverage is `87.88%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 77.01% 68.42% -8.60%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43648 44428 +780
- Misses 12770 18619 +5849
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `57.11% <87.88%> (-13.98%)` | :arrow_down: |
| mysql | `82.02% <ø> (-0.01%)` | :arrow_down: |
| postgres | `82.03% <ø> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `82.11% <ø> (-0.42%)` | :arrow_down: |
| sqlite | `81.71% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `95.23% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `94.11% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `85.71% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `92.85% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `100.00% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `100.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1075 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2e29f36...44cbf80](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1065a69) into [master](https://codecov.io/gh/apache/superset/commit/7353a2bd75ae5c76458615443f530a688e78db1c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7353a2b) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.81% 76.79% -0.03%
==========================================
Files 1049 1049
Lines 56653 56653
Branches 7847 7847
==========================================
- Hits 43517 43505 -12
- Misses 12883 12895 +12
Partials 253 253
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `?` | |
| postgres | `82.01% <ø> (ø)` | |
| python | `82.06% <ø> (-0.05%)` | :arrow_down: |
| sqlite | `81.69% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `94.04% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.53% <0.00%> (-0.74%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.97% <0.00%> (-0.46%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7353a2b...1065a69](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16c965c) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.53%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.41% -8.54%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44423 +814
- Misses 12810 18618 +5808
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.12% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1290 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...16c965c](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16eb4ce) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.55%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.39% -8.56%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44411 +802
- Misses 12810 18630 +5820
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.08% <ø> (-0.31%)` | :arrow_down: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1293 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...16eb4ce](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (44cbf80) into [master](https://codecov.io/gh/apache/superset/commit/2e29f36e7885b693a0af2cf8b0b8ca86d2970f64?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2e29f36) will **decrease** coverage by `8.61%`.
> The diff coverage is `87.88%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 77.01% 68.40% -8.62%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43648 44416 +768
- Misses 12770 18622 +5852
- Partials 253 1892 +1639
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `57.08% <87.88%> (-14.02%)` | :arrow_down: |
| mysql | `82.02% <ø> (-0.01%)` | :arrow_down: |
| postgres | `82.03% <ø> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `82.11% <ø> (-0.42%)` | :arrow_down: |
| sqlite | `81.71% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `95.23% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `94.11% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `85.71% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `92.85% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `100.00% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `100.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1075 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2e29f36...44cbf80](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (44cbf80) into [master](https://codecov.io/gh/apache/superset/commit/19ffba1efe98c105379aa6cff0c9147c0112bec2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19ffba1) will **decrease** coverage by `8.19%`.
> The diff coverage is `87.88%`.
> :exclamation: Current head 44cbf80 differs from pull request most recent head bfb4a12. Consider uploading reports for the commit bfb4a12 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.81% 68.61% -8.20%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43529 44549 +1020
- Misses 12889 18498 +5609
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.60% <ø> (?)` | |
| javascript | `57.11% <87.88%> (-13.98%)` | :arrow_down: |
| mysql | `82.02% <ø> (-0.01%)` | :arrow_down: |
| postgres | `82.03% <ø> (-0.01%)` | :arrow_down: |
| presto | `81.90% <ø> (?)` | |
| python | `82.52% <ø> (+0.40%)` | :arrow_up: |
| sqlite | `81.71% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `95.23% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `94.11% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `85.71% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `92.85% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `100.00% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `100.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1075 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [19ffba1...bfb4a12](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (508b9a0) into [master](https://codecov.io/gh/apache/superset/commit/870d2ab16f6add45b78759a007d0aca8c4e48b3b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (870d2ab) will **decrease** coverage by `8.40%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.81% 68.40% -8.41%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43529 44418 +889
- Misses 12889 18620 +5731
- Partials 253 1892 +1639
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `57.08% <50.00%> (-14.02%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.12% <ø> (ø)` | |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1284 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [870d2ab...508b9a0](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fcbcca6) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.53%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.41% -8.54%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44423 +814
- Misses 12810 18618 +5808
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.12% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1289 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...fcbcca6](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (508b9a0) into [master](https://codecov.io/gh/apache/superset/commit/61a9517fb8e3ea2e9348913dbb0693093cab4806?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (61a9517) will **decrease** coverage by `2.50%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head 508b9a0 differs from pull request most recent head a5addbb. Consider uploading reports for the commit a5addbb to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 71.09% 68.59% -2.51%
==========================================
Files 682 1588 +906
Lines 27305 64930 +37625
Branches 7851 6963 -888
==========================================
+ Hits 19413 44537 +25124
- Misses 7639 18501 +10862
- Partials 253 1892 +1639
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.60% <ø> (?)` | |
| javascript | `57.08% <50.00%> (-14.02%)` | :arrow_down: |
| mysql | `82.02% <ø> (?)` | |
| postgres | `82.03% <ø> (?)` | |
| presto | `81.90% <ø> (?)` | |
| python | `82.52% <ø> (?)` | |
| sqlite | `81.71% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1649 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [61a9517...a5addbb](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-982162817
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (508b9a0) into [master](https://codecov.io/gh/apache/superset/commit/870d2ab16f6add45b78759a007d0aca8c4e48b3b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (870d2ab) will **decrease** coverage by `8.40%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.81% 68.40% -8.41%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43529 44418 +889
- Misses 12889 18620 +5731
- Partials 253 1892 +1639
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `57.08% <50.00%> (-14.02%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.12% <ø> (ø)` | |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1284 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [870d2ab...508b9a0](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (342d5b0) into [master](https://codecov.io/gh/apache/superset/commit/870d2ab16f6add45b78759a007d0aca8c4e48b3b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (870d2ab) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
=======================================
Coverage 76.81% 76.81%
=======================================
Files 1049 1049
Lines 56671 56671
Branches 7851 7851
=======================================
Hits 43529 43529
Misses 12889 12889
Partials 253 253
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.12% <ø> (ø)` | |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [870d2ab...342d5b0](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16eb4ce) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.53%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.41% -8.54%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44423 +814
- Misses 12810 18618 +5808
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.12% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1290 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...16eb4ce](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-981802037
Tested in local. LGTM. Thanks for the huge improvement!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bfb4a12) into [master](https://codecov.io/gh/apache/superset/commit/870d2ab16f6add45b78759a007d0aca8c4e48b3b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (870d2ab) will **decrease** coverage by `8.38%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head bfb4a12 differs from pull request most recent head 342d5b0. Consider uploading reports for the commit 342d5b0 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.81% 68.42% -8.39%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43529 44428 +899
- Misses 12889 18619 +5730
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `57.11% <50.00%> (-13.98%)` | :arrow_down: |
| mysql | `82.02% <ø> (-0.01%)` | :arrow_down: |
| postgres | `82.03% <ø> (-0.01%)` | :arrow_down: |
| python | `82.11% <ø> (-0.01%)` | :arrow_down: |
| sqlite | `81.71% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1286 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [870d2ab...342d5b0](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5addbb) into [master](https://codecov.io/gh/apache/superset/commit/61a9517fb8e3ea2e9348913dbb0693093cab4806?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (61a9517) will **decrease** coverage by `2.55%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 71.09% 68.54% -2.56%
==========================================
Files 682 1588 +906
Lines 27305 64930 +37625
Branches 7851 6963 -888
==========================================
+ Hits 19413 44505 +25092
- Misses 7639 18542 +10903
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.60% <ø> (?)` | |
| javascript | `57.11% <50.00%> (-13.98%)` | :arrow_down: |
| mysql | `82.02% <ø> (?)` | |
| postgres | `82.03% <ø> (?)` | |
| python | `82.37% <ø> (?)` | |
| sqlite | `81.71% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1651 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [61a9517...a5addbb](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #17552:
URL: https://github.com/apache/superset/pull/17552#discussion_r758105309
##########
File path: superset/translations/babel.cfg
##########
@@ -14,12 +14,18 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# http://babel.pocoo.org/en/latest/messages.html?highlight=mapping%20file#extraction-method-mapping-and-configuration
[ignore: superset-frontend/node_modules/**]
+[ignore: superset-frontend/packages/superset-ui-demo/**]
+[ignore: superset/migrations/**]
+
[python: superset/**.py]
[jinja2: superset/**/templates/**.html]
-[javascript: superset-frontend/src/**.js]
-[javascript: superset-frontend/src/**.jsx]
-[javascript: superset-frontend/src/**.ts]
-[javascript: superset-frontend/src/**.tsx]
+[javascript: superset-frontend/src/**.js?]
+[javascript: superset-frontend/src/**.ts?]
+[javascript: superset-frontend/packages/**.js?]
+[javascript: superset-frontend/packages/**.ts?]
+[javascript: superset-frontend/plugins/**.js?]
+[javascript: superset-frontend/plugins/**.ts?]
Review comment:
I noticed that the `lib` subdirs were also extracted - this seemed to fix it:
```suggestion
[javascript: superset-frontend/packages/**/src/**.js?]
[javascript: superset-frontend/packages/**/src/**.ts?]
[javascript: superset-frontend/plugins/**/src/**.js?]
[javascript: superset-frontend/plugins/**/src/**.ts?]
```
##########
File path: .codecov.yml
##########
@@ -14,6 +15,17 @@ coverage:
# project coverage decrease:
target: auto
threshold: 0%
+ core-packages-ts:
+ target: 95%
Review comment:
Note to other reviewers - this was set to 95 % due to codecov reporting slightly lower coverage stats than on `superset-ui`. This will be fixed in a follow-up PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17552:
URL: https://github.com/apache/superset/pull/17552#discussion_r758138355
##########
File path: superset/translations/babel.cfg
##########
@@ -14,12 +14,18 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# http://babel.pocoo.org/en/latest/messages.html?highlight=mapping%20file#extraction-method-mapping-and-configuration
[ignore: superset-frontend/node_modules/**]
+[ignore: superset-frontend/packages/superset-ui-demo/**]
+[ignore: superset/migrations/**]
+
[python: superset/**.py]
[jinja2: superset/**/templates/**.html]
-[javascript: superset-frontend/src/**.js]
-[javascript: superset-frontend/src/**.jsx]
-[javascript: superset-frontend/src/**.ts]
-[javascript: superset-frontend/src/**.tsx]
+[javascript: superset-frontend/src/**.js?]
+[javascript: superset-frontend/src/**.ts?]
+[javascript: superset-frontend/packages/**.js?]
+[javascript: superset-frontend/packages/**.ts?]
+[javascript: superset-frontend/plugins/**.js?]
+[javascript: superset-frontend/plugins/**.ts?]
Review comment:
Nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1065a69) into [master](https://codecov.io/gh/apache/superset/commit/7353a2bd75ae5c76458615443f530a688e78db1c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7353a2b) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
=======================================
Coverage 76.81% 76.81%
=======================================
Files 1049 1049
Lines 56653 56653
Branches 7847 7847
=======================================
Hits 43517 43517
Misses 12883 12883
Partials 253 253
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `82.00% <ø> (ø)` | |
| postgres | `82.01% <ø> (ø)` | |
| python | `82.10% <ø> (ø)` | |
| sqlite | `81.69% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7353a2b...1065a69](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c26d3a9) into [master](https://codecov.io/gh/apache/superset/commit/7353a2bd75ae5c76458615443f530a688e78db1c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7353a2b) will **increase** coverage by `5.29%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
+ Coverage 76.81% 82.10% +5.29%
==========================================
Files 1049 367 -682
Lines 56653 29349 -27304
Branches 7847 0 -7847
==========================================
- Hits 43517 24097 -19420
+ Misses 12883 5252 -7631
+ Partials 253 0 -253
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| mysql | `82.00% <ø> (ø)` | |
| postgres | `82.01% <ø> (ø)` | |
| python | `82.10% <ø> (ø)` | |
| sqlite | `81.69% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | | |
| [...frontend/src/SqlLab/components/ResultSet/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC9pbmRleC50c3g=) | | |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | | |
| [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | | |
| [...components/controls/FixedOrMetricControl/index.jsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaXhlZE9yTWV0cmljQ29udHJvbC9pbmRleC5qc3g=) | | |
| [...ols/DndColumnSelectControl/utils/optionSelector.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL3V0aWxzL29wdGlvblNlbGVjdG9yLnRz) | | |
| [...end/src/dashboard/components/SliceHeader/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyL2luZGV4LnRzeA==) | | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | | |
| [...end/src/components/Datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9EYXRhc291cmNlRWRpdG9yLmpzeA==) | | |
| [superset-frontend/src/setup/setupColors.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLnRz) | | |
| ... and [672 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7353a2b...c26d3a9](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (44cbf80) into [master](https://codecov.io/gh/apache/superset/commit/2e29f36e7885b693a0af2cf8b0b8ca86d2970f64?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2e29f36) will **increase** coverage by `5.09%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
+ Coverage 77.01% 82.11% +5.09%
==========================================
Files 1049 367 -682
Lines 56671 29366 -27305
Branches 7851 0 -7851
==========================================
- Hits 43648 24114 -19534
+ Misses 12770 5252 -7518
+ Partials 253 0 -253
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `?` | |
| mysql | `82.02% <ø> (-0.01%)` | :arrow_down: |
| postgres | `82.03% <ø> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `82.11% <ø> (-0.42%)` | :arrow_down: |
| sqlite | `81.71% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `70.27% <0.00%> (-16.99%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.50% <0.00%> (-6.48%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `86.85% <0.00%> (-1.58%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `90.13% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.26% <0.00%> (-0.74%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.15% <0.00%> (-0.39%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.64% <0.00%> (-0.12%)` | :arrow_down: |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <0.00%> (ø)` | |
| ... and [682 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2e29f36...44cbf80](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bfb4a12) into [master](https://codecov.io/gh/apache/superset/commit/19ffba1efe98c105379aa6cff0c9147c0112bec2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19ffba1) will **increase** coverage by `5.30%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
+ Coverage 76.81% 82.11% +5.30%
==========================================
Files 1049 367 -682
Lines 56671 29366 -27305
Branches 7851 0 -7851
==========================================
- Hits 43529 24114 -19415
+ Misses 12889 5252 -7637
+ Partials 253 0 -253
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| mysql | `82.02% <ø> (-0.01%)` | :arrow_down: |
| postgres | `82.03% <ø> (-0.01%)` | :arrow_down: |
| python | `82.11% <ø> (-0.01%)` | :arrow_down: |
| sqlite | `81.71% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `90.13% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <0.00%> (ø)` | |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | | |
| [...uperset-frontend/src/explore/controlUtils/index.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2luZGV4LnRz) | | |
| [...perset-frontend/src/dashboard/util/findParentId.js](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2ZpbmRQYXJlbnRJZC5qcw==) | | |
| [...rontend/src/components/ListView/CardCollection.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZENvbGxlY3Rpb24udHN4) | | |
| [...ntend/src/dashboard/util/activeDashboardFilters.js](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2FjdGl2ZURhc2hib2FyZEZpbHRlcnMuanM=) | | |
| [...e/controlPanels/timeGrainSqlaAnimationOverrides.js](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy90aW1lR3JhaW5TcWxhQW5pbWF0aW9uT3ZlcnJpZGVzLmpz) | | |
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | | |
| [superset-frontend/src/utils/downloadAsImage.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Rvd25sb2FkQXNJbWFnZS50cw==) | | |
| ... and [674 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [19ffba1...bfb4a12](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16eb4ce) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.53%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.41% -8.54%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44423 +814
- Misses 12810 18618 +5808
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `57.08% <50.00%> (-14.01%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.12% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1290 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...16eb4ce](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-981812040
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1213309) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.53%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.41% -8.54%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44423 +814
- Misses 12810 18618 +5808
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `57.08% <50.00%> (-14.01%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.12% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1291 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...1213309](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1065a69) into [master](https://codecov.io/gh/apache/superset/commit/5a1c68177ee68f78f8b31877f33f5bf93d5cc6c2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a1c681) will **decrease** coverage by `8.57%`.
> The diff coverage is `85.96%`.
> :exclamation: Current head 1065a69 differs from pull request most recent head 7fb3402. Consider uploading reports for the commit 7fb3402 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 77.03% 68.45% -8.58%
==========================================
Files 1049 1588 +539
Lines 56671 64916 +8245
Branches 7851 6960 -891
==========================================
+ Hits 43655 44438 +783
- Misses 12763 18595 +5832
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.59% <ø> (-0.02%)` | :arrow_down: |
| javascript | `56.97% <85.96%> (-14.15%)` | :arrow_down: |
| mysql | `82.00% <ø> (-0.02%)` | :arrow_down: |
| postgres | `82.01% <ø> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `82.36% <ø> (-0.17%)` | :arrow_down: |
| sqlite | `81.69% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `95.23% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `94.11% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `85.71% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `92.85% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `100.00% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `100.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1095 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5a1c681...7fb3402](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (342d5b0) into [master](https://codecov.io/gh/apache/superset/commit/870d2ab16f6add45b78759a007d0aca8c4e48b3b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (870d2ab) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 342d5b0 differs from pull request most recent head 508b9a0. Consider uploading reports for the commit 508b9a0 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
=======================================
Coverage 76.81% 76.81%
=======================================
Files 1049 1049
Lines 56671 56671
Branches 7851 7851
=======================================
Hits 43529 43529
Misses 12889 12889
Partials 253 253
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.12% <ø> (ø)` | |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [870d2ab...508b9a0](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5addbb) into [master](https://codecov.io/gh/apache/superset/commit/61a9517fb8e3ea2e9348913dbb0693093cab4806?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (61a9517) will **decrease** coverage by `2.48%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 71.09% 68.60% -2.49%
==========================================
Files 682 1588 +906
Lines 27305 64930 +37625
Branches 7851 6963 -888
==========================================
+ Hits 19413 44547 +25134
- Misses 7639 18500 +10861
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.60% <ø> (?)` | |
| javascript | `57.11% <50.00%> (-13.98%)` | :arrow_down: |
| mysql | `82.02% <ø> (?)` | |
| postgres | `82.03% <ø> (?)` | |
| presto | `81.89% <ø> (?)` | |
| python | `82.52% <ø> (?)` | |
| sqlite | `81.71% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1651 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [61a9517...a5addbb](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c26d3a9) into [master](https://codecov.io/gh/apache/superset/commit/7353a2bd75ae5c76458615443f530a688e78db1c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7353a2b) will **decrease** coverage by `18.56%`.
> The diff coverage is `71.35%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
===========================================
- Coverage 76.81% 58.24% -18.57%
===========================================
Files 1049 1839 +790
Lines 56653 74838 +18185
Branches 7847 6983 -864
===========================================
+ Hits 43517 43590 +73
- Misses 12883 29348 +16465
- Partials 253 1900 +1647
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `42.85% <71.35%> (-28.28%)` | :arrow_down: |
| mysql | `82.00% <ø> (ø)` | |
| postgres | `82.01% <ø> (ø)` | |
| python | `82.10% <ø> (ø)` | |
| sqlite | `81.69% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `83.33% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `80.95% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `82.35% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `39.28% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `28.57% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `68.75% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `80.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1316 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7353a2b...c26d3a9](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1065a69) into [master](https://codecov.io/gh/apache/superset/commit/7353a2bd75ae5c76458615443f530a688e78db1c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7353a2b) will **decrease** coverage by `8.35%`.
> The diff coverage is `85.96%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.81% 68.45% -8.36%
==========================================
Files 1049 1588 +539
Lines 56653 64916 +8263
Branches 7847 6960 -887
==========================================
+ Hits 43517 44438 +921
- Misses 12883 18595 +5712
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.59% <ø> (?)` | |
| javascript | `56.97% <85.96%> (-14.16%)` | :arrow_down: |
| mysql | `82.00% <ø> (ø)` | |
| postgres | `82.01% <ø> (ø)` | |
| python | `82.36% <ø> (+0.26%)` | :arrow_up: |
| sqlite | `81.69% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `95.23% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `94.11% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `85.71% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `92.85% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `100.00% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `100.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1072 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7353a2b...1065a69](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16eb4ce) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.41%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.53% -8.42%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44500 +891
- Misses 12810 18541 +5731
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.61% <ø> (ø)` | |
| javascript | `57.08% <50.00%> (-14.01%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.38% <ø> (ø)` | |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1283 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...16eb4ce](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fcbcca6) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.35%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.59% -8.36%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44542 +933
- Misses 12810 18499 +5689
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.61% <ø> (ø)` | |
| javascript | `57.08% <50.00%> (-14.01%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| presto | `81.90% <ø> (?)` | |
| python | `82.52% <ø> (+0.14%)` | :arrow_up: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1285 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...fcbcca6](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (508b9a0) into [master](https://codecov.io/gh/apache/superset/commit/870d2ab16f6add45b78759a007d0aca8c4e48b3b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (870d2ab) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
=======================================
Coverage 76.81% 76.81%
=======================================
Files 1049 1049
Lines 56671 56671
Branches 7851 7851
=======================================
Hits 43529 43529
Misses 12889 12889
Partials 253 253
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.12% <ø> (ø)` | |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [870d2ab...508b9a0](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c26d3a9) into [master](https://codecov.io/gh/apache/superset/commit/7353a2bd75ae5c76458615443f530a688e78db1c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7353a2b) will **decrease** coverage by `18.40%`.
> The diff coverage is `71.35%`.
> :exclamation: Current head c26d3a9 differs from pull request most recent head 1065a69. Consider uploading reports for the commit 1065a69 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
===========================================
- Coverage 76.81% 58.40% -18.41%
===========================================
Files 1049 1839 +790
Lines 56653 74838 +18185
Branches 7847 6983 -864
===========================================
+ Hits 43517 43711 +194
- Misses 12883 29227 +16344
- Partials 253 1900 +1647
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.59% <ø> (?)` | |
| javascript | `42.85% <71.35%> (-28.28%)` | :arrow_down: |
| mysql | `82.00% <ø> (ø)` | |
| postgres | `82.01% <ø> (ø)` | |
| presto | `81.89% <ø> (?)` | |
| python | `82.51% <ø> (+0.41%)` | :arrow_up: |
| sqlite | `81.69% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `83.33% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `80.95% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `82.35% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `39.28% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `28.57% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `68.75% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `80.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1324 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7353a2b...1065a69](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e330069) into [master](https://codecov.io/gh/apache/superset/commit/5a1c68177ee68f78f8b31877f33f5bf93d5cc6c2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a1c681) will **decrease** coverage by `8.47%`.
> The diff coverage is `86.73%`.
> :exclamation: Current head e330069 differs from pull request most recent head 7fb3402. Consider uploading reports for the commit 7fb3402 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 77.03% 68.56% -8.48%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43655 44517 +862
- Misses 12763 18530 +5767
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `57.02% <86.73%> (-14.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `95.23% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `94.11% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `85.71% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `92.85% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `100.00% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `100.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1065 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5a1c681...7fb3402](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1213309) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.81% 76.80% -0.01%
==========================================
Files 1049 1049
Lines 56681 56681
Branches 7851 7851
==========================================
- Hits 43538 43535 -3
- Misses 12890 12893 +3
Partials 253 253
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.02% <ø> (-0.02%)` | :arrow_down: |
| python | `82.11% <ø> (-0.02%)` | :arrow_down: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `85.71% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `89.13% <0.00%> (-2.18%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `90.83% <0.00%> (-0.39%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...1213309](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16eb4ce) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.35%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.59% -8.36%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44542 +933
- Misses 12810 18499 +5689
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.61% <ø> (ø)` | |
| javascript | `57.08% <50.00%> (-14.01%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| presto | `81.90% <ø> (?)` | |
| python | `82.52% <ø> (+0.14%)` | :arrow_up: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1286 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...16eb4ce](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16eb4ce) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.53%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.41% -8.54%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44423 +814
- Misses 12810 18618 +5808
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `57.08% <50.00%> (-14.01%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.12% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1290 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...16eb4ce](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5addbb) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.18%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head a5addbb differs from pull request most recent head 1213309. Consider uploading reports for the commit 1213309 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.79% 68.60% -8.19%
==========================================
Files 1049 1588 +539
Lines 56681 64930 +8249
Branches 7851 6963 -888
==========================================
+ Hits 43526 44547 +1021
- Misses 12902 18500 +5598
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.60% <ø> (?)` | |
| javascript | `57.11% <50.00%> (-13.98%)` | :arrow_down: |
| mysql | `82.02% <ø> (?)` | |
| postgres | `82.03% <ø> (-0.01%)` | :arrow_down: |
| presto | `81.89% <ø> (?)` | |
| python | `82.52% <ø> (+0.43%)` | :arrow_up: |
| sqlite | `81.71% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1298 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...1213309](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c26d3a9) into [master](https://codecov.io/gh/apache/superset/commit/7353a2bd75ae5c76458615443f530a688e78db1c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7353a2b) will **decrease** coverage by `18.40%`.
> The diff coverage is `71.35%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
===========================================
- Coverage 76.81% 58.40% -18.41%
===========================================
Files 1049 1839 +790
Lines 56653 74838 +18185
Branches 7847 6983 -864
===========================================
+ Hits 43517 43711 +194
- Misses 12883 29227 +16344
- Partials 253 1900 +1647
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.59% <ø> (?)` | |
| javascript | `42.85% <71.35%> (-28.28%)` | :arrow_down: |
| mysql | `82.00% <ø> (ø)` | |
| postgres | `82.01% <ø> (ø)` | |
| presto | `81.89% <ø> (?)` | |
| python | `82.51% <ø> (+0.41%)` | :arrow_up: |
| sqlite | `81.69% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `83.33% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `80.95% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `82.35% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `39.28% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `28.57% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `68.75% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `80.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1324 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7353a2b...c26d3a9](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-981813870
@kgabryje Ephemeral environment spinning up at http://35.87.14.131:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17552:
URL: https://github.com/apache/superset/pull/17552#discussion_r758183652
##########
File path: .codecov.yml
##########
@@ -14,6 +15,17 @@ coverage:
# project coverage decrease:
target: auto
threshold: 0%
+ core-packages-ts:
+ target: 95%
Review comment:
Thanks for the reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fcbcca6) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.53%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.41% -8.54%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44423 +814
- Misses 12810 18618 +5808
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `57.08% <50.00%> (-14.01%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.12% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1289 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...fcbcca6](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #17552:
URL: https://github.com/apache/superset/pull/17552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16c965c) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.55%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.39% -8.56%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44407 +798
- Misses 12810 18634 +5824
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `?` | |
| python | `82.07% <ø> (-0.32%)` | :arrow_down: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1296 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...16c965c](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e55550b) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.53%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head e55550b differs from pull request most recent head fcbcca6. Consider uploading reports for the commit fcbcca6 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.41% -8.54%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44423 +814
- Misses 12810 18618 +5808
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `57.08% <50.00%> (-14.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1286 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...fcbcca6](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (44cbf80) into [master](https://codecov.io/gh/apache/superset/commit/2e29f36e7885b693a0af2cf8b0b8ca86d2970f64?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2e29f36) will **decrease** coverage by `8.47%`.
> The diff coverage is `87.88%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 77.01% 68.54% -8.48%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43648 44505 +857
- Misses 12770 18542 +5772
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.60% <ø> (-0.01%)` | :arrow_down: |
| javascript | `57.11% <87.88%> (-13.98%)` | :arrow_down: |
| mysql | `82.02% <ø> (-0.01%)` | :arrow_down: |
| postgres | `82.03% <ø> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `82.37% <ø> (-0.15%)` | :arrow_down: |
| sqlite | `81.71% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `95.23% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `94.11% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `85.71% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `92.85% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `100.00% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `100.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1070 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2e29f36...44cbf80](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bfb4a12) into [master](https://codecov.io/gh/apache/superset/commit/19ffba1efe98c105379aa6cff0c9147c0112bec2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19ffba1) will **decrease** coverage by `8.53%`.
> The diff coverage is `87.88%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.40% -8.54%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43606 44416 +810
- Misses 12812 18622 +5810
- Partials 253 1892 +1639
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `57.08% <87.88%> (-14.02%)` | :arrow_down: |
| mysql | `82.02% <ø> (-0.01%)` | :arrow_down: |
| postgres | `82.03% <ø> (-0.01%)` | :arrow_down: |
| python | `82.11% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `81.71% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `95.23% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `94.11% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `85.71% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `92.85% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `100.00% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `100.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1074 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [19ffba1...bfb4a12](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5addbb) into [master](https://codecov.io/gh/apache/superset/commit/61a9517fb8e3ea2e9348913dbb0693093cab4806?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (61a9517) will **decrease** coverage by `2.69%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 71.09% 68.40% -2.70%
==========================================
Files 682 1588 +906
Lines 27305 64930 +37625
Branches 7851 6963 -888
==========================================
+ Hits 19413 44416 +25003
- Misses 7639 18622 +10983
- Partials 253 1892 +1639
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `57.08% <50.00%> (-14.02%)` | :arrow_down: |
| mysql | `82.02% <ø> (?)` | |
| postgres | `82.03% <ø> (?)` | |
| python | `82.11% <ø> (?)` | |
| sqlite | `81.71% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1651 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [61a9517...a5addbb](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (508b9a0) into [master](https://codecov.io/gh/apache/superset/commit/870d2ab16f6add45b78759a007d0aca8c4e48b3b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (870d2ab) will **decrease** coverage by `8.28%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.81% 68.52% -8.29%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43529 44495 +966
- Misses 12889 18543 +5654
- Partials 253 1892 +1639
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.60% <ø> (?)` | |
| javascript | `57.08% <50.00%> (-14.02%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.38% <ø> (+0.26%)` | :arrow_up: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1291 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [870d2ab...508b9a0](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c26d3a9) into [master](https://codecov.io/gh/apache/superset/commit/7353a2bd75ae5c76458615443f530a688e78db1c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7353a2b) will **decrease** coverage by `18.56%`.
> The diff coverage is `71.35%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
===========================================
- Coverage 76.81% 58.24% -18.57%
===========================================
Files 1049 1839 +790
Lines 56653 74838 +18185
Branches 7847 6983 -864
===========================================
+ Hits 43517 43590 +73
- Misses 12883 29348 +16465
- Partials 253 1900 +1647
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `42.85% <71.35%> (-28.28%)` | :arrow_down: |
| mysql | `82.00% <ø> (ø)` | |
| postgres | `82.01% <ø> (ø)` | |
| python | `82.10% <ø> (ø)` | |
| sqlite | `81.69% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `83.33% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `80.95% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `82.35% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `39.28% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `28.57% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `68.75% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `80.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1316 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7353a2b...c26d3a9](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e330069) into [master](https://codecov.io/gh/apache/superset/commit/2e29f36e7885b693a0af2cf8b0b8ca86d2970f64?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2e29f36) will **decrease** coverage by `8.45%`.
> The diff coverage is `86.73%`.
> :exclamation: Current head e330069 differs from pull request most recent head 44cbf80. Consider uploading reports for the commit 44cbf80 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 77.01% 68.56% -8.46%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43648 44517 +869
- Misses 12770 18530 +5760
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `57.02% <86.73%> (-14.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `95.23% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `94.11% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `85.71% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `92.85% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `100.00% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `100.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1069 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2e29f36...44cbf80](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5addbb) into [master](https://codecov.io/gh/apache/superset/commit/61a9517fb8e3ea2e9348913dbb0693093cab4806?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (61a9517) will **decrease** coverage by `2.67%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 71.09% 68.42% -2.68%
==========================================
Files 682 1588 +906
Lines 27305 64930 +37625
Branches 7851 6963 -888
==========================================
+ Hits 19413 44428 +25015
- Misses 7639 18619 +10980
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `57.11% <50.00%> (-13.98%)` | :arrow_down: |
| mysql | `82.02% <ø> (?)` | |
| postgres | `82.03% <ø> (?)` | |
| python | `82.11% <ø> (?)` | |
| sqlite | `81.71% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1651 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [61a9517...a5addbb](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fcbcca6) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.41%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.53% -8.42%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44500 +891
- Misses 12810 18541 +5731
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.61% <ø> (ø)` | |
| javascript | `57.08% <50.00%> (-14.01%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.38% <ø> (ø)` | |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1282 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...fcbcca6](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16c965c) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.53%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.41% -8.54%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44420 +811
- Misses 12810 18621 +5811
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.02% <ø> (-0.02%)` | :arrow_down: |
| python | `82.11% <ø> (-0.28%)` | :arrow_down: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1293 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...16c965c](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17552:
URL: https://github.com/apache/superset/pull/17552#discussion_r758201323
##########
File path: superset-frontend/jest.config.js
##########
@@ -16,33 +16,64 @@
* specific language governing permissions and limitations
* under the License.
*/
+
module.exports = {
- testRegex: '(\\/spec|\\/src)\\/.*(_spec|\\.test)\\.(j|t)sx?$',
+ testRegex: '\\/(spec|src|plugins|packages)\\/.*(_spec|\\.test)\\.[jt]sx?$',
+ testPathIgnorePatterns: [
+ 'packages\\/generator-superset\\/.*',
Review comment:
I added a step in the [workflow](https://github.com/apache/superset/pull/17552/commits/fcbcca61b6662f9e63161e1184371392c489ef38) of frontend for this unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (44cbf80) into [master](https://codecov.io/gh/apache/superset/commit/2e29f36e7885b693a0af2cf8b0b8ca86d2970f64?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2e29f36) will **decrease** coverage by `8.40%`.
> The diff coverage is `87.88%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 77.01% 68.61% -8.41%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43648 44549 +901
- Misses 12770 18498 +5728
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.60% <ø> (-0.01%)` | :arrow_down: |
| javascript | `57.11% <87.88%> (-13.98%)` | :arrow_down: |
| mysql | `82.02% <ø> (-0.01%)` | :arrow_down: |
| postgres | `82.03% <ø> (-0.01%)` | :arrow_down: |
| presto | `81.90% <ø> (ø)` | |
| python | `82.52% <ø> (ø)` | |
| sqlite | `81.71% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `95.23% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `94.11% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `85.71% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `92.85% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `100.00% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `100.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1068 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2e29f36...44cbf80](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bfb4a12) into [master](https://codecov.io/gh/apache/superset/commit/19ffba1efe98c105379aa6cff0c9147c0112bec2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19ffba1) will **decrease** coverage by `8.52%`.
> The diff coverage is `87.88%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.42% -8.53%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43606 44428 +822
- Misses 12812 18619 +5807
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `57.11% <87.88%> (-13.98%)` | :arrow_down: |
| mysql | `82.02% <ø> (-0.01%)` | :arrow_down: |
| postgres | `82.03% <ø> (-0.01%)` | :arrow_down: |
| python | `82.11% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `81.71% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...es/superset-ui-core/src/time-format/TimeFormats.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHMudHM=) | `100.00% <ø> (ø)` | |
| [...-core/src/time-format/TimeFormatsForGranularity.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHNGb3JHcmFudWxhcml0eS50cw==) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/time-format/TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlci50cw==) | `95.23% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `94.11% <ø> (ø)` | |
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `85.71% <ø> (ø)` | |
| [...rset-ui-core/src/time-format/TimeRangeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZVJhbmdlRm9ybWF0dGVyLnRz) | `92.85% <ø> (ø)` | |
| [...src/time-format/factories/createD3TimeFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZUQzVGltZUZvcm1hdHRlci50cw==) | `100.00% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `100.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| ... and [1074 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [19ffba1...bfb4a12](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bfb4a12) into [master](https://codecov.io/gh/apache/superset/commit/870d2ab16f6add45b78759a007d0aca8c4e48b3b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (870d2ab) will **decrease** coverage by `8.38%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head bfb4a12 differs from pull request most recent head 508b9a0. Consider uploading reports for the commit 508b9a0 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.80% 68.42% -8.39%
==========================================
Files 1049 1588 +539
Lines 56671 64930 +8259
Branches 7851 6963 -888
==========================================
+ Hits 43526 44428 +902
- Misses 12892 18619 +5727
- Partials 253 1883 +1630
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `57.11% <50.00%> (-13.98%)` | :arrow_down: |
| mysql | `82.02% <ø> (-0.01%)` | :arrow_down: |
| postgres | `82.03% <ø> (+<0.01%)` | :arrow_up: |
| python | `82.11% <ø> (+<0.01%)` | :arrow_up: |
| sqlite | `81.71% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1289 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [870d2ab...508b9a0](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5addbb) into [master](https://codecov.io/gh/apache/superset/commit/61a9517fb8e3ea2e9348913dbb0693093cab4806?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (61a9517) will **increase** coverage by `11.01%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
===========================================
+ Coverage 71.09% 82.11% +11.01%
===========================================
Files 682 367 -315
Lines 27305 29366 +2061
Branches 7851 0 -7851
===========================================
+ Hits 19413 24114 +4701
+ Misses 7639 5252 -2387
+ Partials 253 0 -253
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| mysql | `82.02% <ø> (?)` | |
| postgres | `82.03% <ø> (?)` | |
| python | `82.11% <ø> (?)` | |
| sqlite | `81.71% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | | |
| [...rset-frontend/src/components/Checkbox/Checkbox.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3gudHN4) | | |
| [...ontend/src/components/MessageToasts/withToasts.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVzc2FnZVRvYXN0cy93aXRoVG9hc3RzLnRzeA==) | | |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | | |
| [...rontend/src/visualizations/TimeTable/TimeTable.jsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9UaW1lVGFibGUuanN4) | | |
| [...tend/src/components/CachedLabel/TooltipContent.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwvVG9vbHRpcENvbnRlbnQudHN4) | | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | | |
| [.../src/explore/components/DataTableControl/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sL2luZGV4LnRzeA==) | | |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | | |
| [...t-frontend/src/dashboard/reducers/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9zbGljZUVudGl0aWVzLmpz) | | |
| ... and [1039 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [61a9517...a5addbb](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1213309) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
=======================================
Coverage 76.81% 76.81%
=======================================
Files 1049 1049
Lines 56681 56681
Branches 7851 7851
=======================================
Hits 43538 43538
Misses 12890 12890
Partials 253 253
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.12% <ø> (ø)` | |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...1213309](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1213309) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.35%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.59% -8.36%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44542 +933
- Misses 12810 18499 +5689
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.61% <ø> (ø)` | |
| javascript | `57.08% <50.00%> (-14.01%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| presto | `81.90% <ø> (?)` | |
| python | `82.52% <ø> (+0.14%)` | :arrow_up: |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1287 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...1213309](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17552: refactor(monorepo): move superset-ui to superset(stage 2)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17552:
URL: https://github.com/apache/superset/pull/17552#issuecomment-978795110
# [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17552](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1213309) into [master](https://codecov.io/gh/apache/superset/commit/6604a6ab28eb4818d973ae7e76d045fec132e403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6604a6a) will **decrease** coverage by `8.41%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/17552/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17552 +/- ##
==========================================
- Coverage 76.94% 68.53% -8.42%
==========================================
Files 1049 1588 +539
Lines 56672 64931 +8259
Branches 7849 6961 -888
==========================================
+ Hits 43609 44500 +891
- Misses 12810 18541 +5731
- Partials 253 1890 +1637
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.61% <ø> (ø)` | |
| javascript | `57.08% <50.00%> (-14.01%)` | :arrow_down: |
| mysql | `82.02% <ø> (ø)` | |
| postgres | `82.03% <ø> (ø)` | |
| python | `82.38% <ø> (ø)` | |
| sqlite | `81.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntrols/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `88.88% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/ColumnOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLnRzeA==) | `91.30% <ø> (ø)` | |
| [...-chart-controls/src/components/ColumnTypeLabel.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLnRzeA==) | `90.00% <ø> (ø)` | |
| [...ols/src/components/ControlForm/ControlFormItem.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vQ29udHJvbEZvcm1JdGVtLnRzeA==) | `24.24% <ø> (ø)` | |
| [...t-controls/src/components/ControlForm/controls.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vY29udHJvbHMudHN4) | `100.00% <ø> (ø)` | |
| [...hart-controls/src/components/ControlForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEZvcm0vaW5kZXgudHN4) | `14.28% <ø> (ø)` | |
| [...ui-chart-controls/src/components/ControlHeader.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29udHJvbEhlYWRlci50c3g=) | `19.23% <ø> (ø)` | |
| [...controls/src/components/InfoTooltipWithTrigger.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXBXaXRoVHJpZ2dlci50c3g=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `95.83% <ø> (ø)` | |
| [...perset-ui-chart-controls/src/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | `14.28% <ø> (ø)` | |
| ... and [1284 more](https://codecov.io/gh/apache/superset/pull/17552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6604a6a...1213309](https://codecov.io/gh/apache/superset/pull/17552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org