You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Daniel Gómez Ferro (Created JIRA)" <ji...@apache.org> on 2011/11/29 17:35:40 UTC

[jira] [Created] (HBASE-4889) HRegionInfo.isMetaTable() should be true for -ROOT- regions

HRegionInfo.isMetaTable() should be true for -ROOT- regions
-----------------------------------------------------------

                 Key: HBASE-4889
                 URL: https://issues.apache.org/jira/browse/HBASE-4889
             Project: HBase
          Issue Type: Bug
            Reporter: Daniel Gómez Ferro


According to its javadoc, HRegionInfo.isMetaTable() should return true if the region is either a .META. or -ROOT- region, but only does so for .META. regions.

The change in behavior happened in HBASE-451

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-4889) HRegionInfo.isMetaTable() should be true for -ROOT- regions

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159744#comment-13159744 ] 

Hudson commented on HBASE-4889:
-------------------------------

Integrated in HBase-TRUNK-security #15 (See [https://builds.apache.org/job/HBase-TRUNK-security/15/])
    HBASE-4889 HRegionInfo.isMetaTable() should be true for -ROOT- regions

stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java

                
> HRegionInfo.isMetaTable() should be true for -ROOT- regions
> -----------------------------------------------------------
>
>                 Key: HBASE-4889
>                 URL: https://issues.apache.org/jira/browse/HBASE-4889
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Daniel Gómez Ferro
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4889.patch
>
>
> According to its javadoc, HRegionInfo.isMetaTable() should return true if the region is either a .META. or -ROOT- region, but only does so for .META. regions.
> The change in behavior happened in HBASE-451

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (HBASE-4889) HRegionInfo.isMetaTable() should be true for -ROOT- regions

Posted by "Daniel Gómez Ferro (Updated JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Gómez Ferro updated HBASE-4889:
--------------------------------------

    Status: Patch Available  (was: Open)
    
> HRegionInfo.isMetaTable() should be true for -ROOT- regions
> -----------------------------------------------------------
>
>                 Key: HBASE-4889
>                 URL: https://issues.apache.org/jira/browse/HBASE-4889
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-4889.patch
>
>
> According to its javadoc, HRegionInfo.isMetaTable() should return true if the region is either a .META. or -ROOT- region, but only does so for .META. regions.
> The change in behavior happened in HBASE-451

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (HBASE-4889) HRegionInfo.isMetaTable() should be true for -ROOT- regions

Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-4889:
-------------------------

       Resolution: Fixed
    Fix Version/s: 0.92.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Thanks for fixing regression Daniel.  Committed to trunk and 0.92 branch.
                
> HRegionInfo.isMetaTable() should be true for -ROOT- regions
> -----------------------------------------------------------
>
>                 Key: HBASE-4889
>                 URL: https://issues.apache.org/jira/browse/HBASE-4889
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Daniel Gómez Ferro
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4889.patch
>
>
> According to its javadoc, HRegionInfo.isMetaTable() should return true if the region is either a .META. or -ROOT- region, but only does so for .META. regions.
> The change in behavior happened in HBASE-451

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-4889) HRegionInfo.isMetaTable() should be true for -ROOT- regions

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159789#comment-13159789 ] 

Hudson commented on HBASE-4889:
-------------------------------

Integrated in HBase-0.92 #163 (See [https://builds.apache.org/job/HBase-0.92/163/])
    HBASE-4889 HRegionInfo.isMetaTable() should be true for -ROOT- regions

stack : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java

                
> HRegionInfo.isMetaTable() should be true for -ROOT- regions
> -----------------------------------------------------------
>
>                 Key: HBASE-4889
>                 URL: https://issues.apache.org/jira/browse/HBASE-4889
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Daniel Gómez Ferro
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4889.patch
>
>
> According to its javadoc, HRegionInfo.isMetaTable() should return true if the region is either a .META. or -ROOT- region, but only does so for .META. regions.
> The change in behavior happened in HBASE-451

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-4889) HRegionInfo.isMetaTable() should be true for -ROOT- regions

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159839#comment-13159839 ] 

Hudson commented on HBASE-4889:
-------------------------------

Integrated in HBase-0.92-security #26 (See [https://builds.apache.org/job/HBase-0.92-security/26/])
    HBASE-4889 HRegionInfo.isMetaTable() should be true for -ROOT- regions

stack : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java

                
> HRegionInfo.isMetaTable() should be true for -ROOT- regions
> -----------------------------------------------------------
>
>                 Key: HBASE-4889
>                 URL: https://issues.apache.org/jira/browse/HBASE-4889
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Daniel Gómez Ferro
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4889.patch
>
>
> According to its javadoc, HRegionInfo.isMetaTable() should return true if the region is either a .META. or -ROOT- region, but only does so for .META. regions.
> The change in behavior happened in HBASE-451

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-4889) HRegionInfo.isMetaTable() should be true for -ROOT- regions

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159517#comment-13159517 ] 

Hudson commented on HBASE-4889:
-------------------------------

Integrated in HBase-TRUNK #2498 (See [https://builds.apache.org/job/HBase-TRUNK/2498/])
    HBASE-4889 HRegionInfo.isMetaTable() should be true for -ROOT- regions

stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java

                
> HRegionInfo.isMetaTable() should be true for -ROOT- regions
> -----------------------------------------------------------
>
>                 Key: HBASE-4889
>                 URL: https://issues.apache.org/jira/browse/HBASE-4889
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Daniel Gómez Ferro
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4889.patch
>
>
> According to its javadoc, HRegionInfo.isMetaTable() should return true if the region is either a .META. or -ROOT- region, but only does so for .META. regions.
> The change in behavior happened in HBASE-451

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-4889) HRegionInfo.isMetaTable() should be true for -ROOT- regions

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159368#comment-13159368 ] 

Hadoop QA commented on HBASE-4889:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12505496/HBASE-4889.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 15 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated -162 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 67 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/403//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/403//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/403//console

This message is automatically generated.
                
> HRegionInfo.isMetaTable() should be true for -ROOT- regions
> -----------------------------------------------------------
>
>                 Key: HBASE-4889
>                 URL: https://issues.apache.org/jira/browse/HBASE-4889
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-4889.patch
>
>
> According to its javadoc, HRegionInfo.isMetaTable() should return true if the region is either a .META. or -ROOT- region, but only does so for .META. regions.
> The change in behavior happened in HBASE-451

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (HBASE-4889) HRegionInfo.isMetaTable() should be true for -ROOT- regions

Posted by "Daniel Gómez Ferro (Updated JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Gómez Ferro updated HBASE-4889:
--------------------------------------

    Attachment: HBASE-4889.patch

Attach a test case and a possible fix.

The patch also uses .isMetaTable() when possible.

                
> HRegionInfo.isMetaTable() should be true for -ROOT- regions
> -----------------------------------------------------------
>
>                 Key: HBASE-4889
>                 URL: https://issues.apache.org/jira/browse/HBASE-4889
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-4889.patch
>
>
> According to its javadoc, HRegionInfo.isMetaTable() should return true if the region is either a .META. or -ROOT- region, but only does so for .META. regions.
> The change in behavior happened in HBASE-451

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira