[GitHub] [fineract] MurphyLaw commented on a change in pull request #450: Adding a compress response filter, registering filter

[GitBox <gi...@apache.org>]

MurphyLaw commented on a change in pull request #450: Adding a compress response filter,registering filter
URL: https://github.com/apache/fineract/pull/450#discussion_r273765503
 
 

 ##########
 File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/boot/WebXmlConfiguration.java
 ##########
 @@ -63,6 +64,8 @@ public ServletRegistrationBean jersey() {
         jerseyServletRegistration.addInitParameter("com.sun.jersey.spi.container.ContainerResponseFilters",
                 ResponseCorsFilter.class.getName());
         jerseyServletRegistration.addInitParameter("com.sun.jersey.config.feature.DisableWADL", "true");
+        jerseyServletRegistration.addInitParameter("com.sun.jersey.spi.container.ContainerResponseFilters",
+                ResponseCompressFilter.class.getName());
 
 Review comment:
   @avikganguly01 I have a question about the implementation of the ResponseCompressFilter, since ResponseCompressFilter's and ResponseCorsFilter's addInitParameter to the same Map, which is "com.sun.jersey.spi.container.ContainerRequestFilters".
   does it overwrite the InitParameter of ResponseCorsFilter?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services