You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pixelherodev (via GitHub)" <gi...@apache.org> on 2025/10/23 21:41:05 UTC
[PR] cookie test: use maps.Equal instead of reflect.DeepEquals [arrow-go]
pixelherodev opened a new pull request, #544:
URL: https://github.com/apache/arrow-go/pull/544
This is a drive-by patch; the test was failing for the other optimization, and I noticed this when I went to take a look and figured I'd just send the patch.
### Rationale for this change
map.Equals, for two values known to both be of type map[string]string, is a strictly faster and smaller operation than reflect.DeepEquals. This patch isn't really necessary, since it's only for a test, but it's good practice.
### Are these changes tested?
The test is passing on my machine, yes.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cookie test: use maps.Equal instead of reflect.DeepEquals [arrow-go]
Posted by "pixelherodev (via GitHub)" <gi...@apache.org>.
pixelherodev closed pull request #544: cookie test: use maps.Equal instead of reflect.DeepEquals
URL: https://github.com/apache/arrow-go/pull/544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cookie test: use maps.Equal instead of reflect.DeepEquals [arrow-go]
Posted by "pixelherodev (via GitHub)" <gi...@apache.org>.
pixelherodev commented on PR #544:
URL: https://github.com/apache/arrow-go/pull/544#issuecomment-3439366031
Just going to add this to the other one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org