[jira] [Commented] (MCHANGES-379) [REGRESSION] Authentication does not work after Upgrade

["Guillaume Boué (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MCHANGES-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884464#comment-15884464 ] 

Guillaume Boué commented on MCHANGES-379:
-----------------------------------------

Fixed in [r1784412|http://svn.apache.org/viewvc?rev=1784412&view=rev].

> [REGRESSION] Authentication does not work after Upgrade
> -------------------------------------------------------
>
>                 Key: MCHANGES-379
>                 URL: https://issues.apache.org/jira/browse/MCHANGES-379
>             Project: Maven Changes Plugin
>          Issue Type: Bug
>          Components: github
>    Affects Versions: 2.12, 2.12.1
>            Reporter: Karl Heinz Marbaise
>            Priority: Blocker
>             Fix For: backlog
>
>
> I have upgraded from maven-changes-plugin version:2.11 to 2.12 (also tested to 2.12.1). Using 2.11 the github-report worked without any issue. After upgrading to 2.12 it produces:
> {code}
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.6:site (default-site) on project smpp: Error generating maven-changes-plugin:2.12.1:github-report: Bad credentials (401) -> [Help 1]
> {code}
> I have my credentials stored in {{settings.xml}} file encrypted using the {{id:github}}. After taking a deeper [look into the code|http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/github/GitHubDownloader.java?r1=1654113&r2=1654112&pathrev=1654113] it looks like the encrypted password will directly given to the github api without decrypting it via Mavens mechanisms...Before that change it worked. 
> Furthermore I have tested to store the password in {{settings.xml}} in clear text which means not encrypted it worked with version 2.12 and 2.12.1.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)